Blame SOURCES/netpbm-security-scripts.patch

780b59
diff -urNp old/converter/other/anytopnm neew/converter/other/anytopnm
780b59
--- old/converter/other/anytopnm	2017-09-05 12:58:26.795741945 +0200
780b59
+++ neew/converter/other/anytopnm	2017-09-05 13:03:12.985472566 +0200
780b59
@@ -537,9 +537,8 @@ else
780b59
 
1ab173
 fi
1ab173
 
780b59
-tempdir=$(mktemp -d "${TMPDIR:-/tmp}/anytopnm.XXXXXXXX") ||
780b59
+tempdir=$(mktemp -d -t anytopnm.XXXXXXXX) ||
780b59
     ( echo "Could not create temporary file. Exiting." 1>&2; exit 1; ) 
1ab173
-trap 'rm -rf $tempdir' 0
1ab173
 
1ab173
 # Take out all spaces
1ab173
 # Find the filename extension for last-ditch efforts later
780b59
@@ -565,9 +564,17 @@ if [ "$filetype" = "unknown" ]; then
1ab173
     echo "$progname: unknown file type.  " \
1ab173
         "'file' says mime type is '$mimeType', " 1>&2
1ab173
     echo "type description is '$typeDescription'" 1>&2
1ab173
+    if [ -d "$tempdir" ] ; then
1ab173
+        rm -rf "$tempdir"
1ab173
+    fi
1ab173
+
1ab173
     exit 1
1ab173
     fi
1ab173
 
1ab173
 convertIt $file $filetype
1ab173
 
1ab173
+if [ -d "$tempdir" ] ; then
1ab173
+    rm -rf "$tempdir"
1ab173
+fi
1ab173
+
1ab173
 exit 0
780b59
diff -urNp old/editor/pamstretch-gen neew/editor/pamstretch-gen
780b59
--- old/editor/pamstretch-gen	2017-09-05 12:58:26.763741946 +0200
780b59
+++ neew/editor/pamstretch-gen	2017-09-05 13:03:12.985472566 +0200
780b59
@@ -34,12 +34,10 @@ if [ "$1" = "" ]; then
1ab173
   exit 1
1ab173
 fi
1ab173
 
780b59
-tempdir=$(mktemp -d "${TMPDIR:-/tmp}/netpbm.XXXXXXXX") ||
780b59
+tempfile=$(mktemp /tmp/pnmig.XXXXXXXX) ||
780b59
     ( echo "Could not create temporary file. Exiting." 1>&2; exit 1; ) 
1ab173
 trap 'rm -rf $tempdir' 0 1 3 15
1ab173
 
1ab173
-tempfile=$tempdir/pnmig
1ab173
-
1ab173
 if ! cat $2 >$tempfile 2>/dev/null; then
1ab173
   echo 'pamstretch-gen: error reading file' 1>&2
1ab173
   exit 1
780b59
diff -urNp old/editor/ppmfade neew/editor/ppmfade
780b59
--- old/editor/ppmfade	2017-09-05 12:58:26.767741946 +0200
780b59
+++ neew/editor/ppmfade	2017-09-05 12:59:14.556731156 +0200
780b59
@@ -40,6 +40,7 @@ exec perl -w -x -S -- "$0" "$@"
1ab173
 #
780b59
 ##############################################################################
1ab173
 use strict;
1ab173
+use File::Temp "tempdir";
1ab173
 
780b59
 sub doVersionHack($) {
780b59
     my ($argvR) = @_;
780b59
@@ -149,20 +149,26 @@ if ($first_file ne "undefined") {
1ab173
 
1ab173
 print("Frames are " . $width . "W x " . $height . "H\n");
1ab173
 
1ab173
+#
1ab173
+# We create a tmp-directory right here
1ab173
+#
1ab173
+my $tmpdir = tempdir("ppmfade.XXXXXX", CLEANUP => 1);
1ab173
+
1ab173
+
1ab173
 if ($first_file eq "undefined") {
1ab173
     print "Fading from black to ";
1ab173
-    system("ppmmake \\#000 $width $height >junk1$$.ppm");
1ab173
+    system("ppmmake \\#000 $width $height >$tmpdir/junk1$$.ppm");
1ab173
 } else {
1ab173
     print "Fading from $first_file to ";
1ab173
-    system("cp", $first_file, "junk1$$.ppm");
1ab173
+    system("cp", $first_file, "$tmpdir/junk1$$.ppm");
1ab173
 }
1ab173
 
1ab173
 if ($last_file eq "undefined") {
1ab173
     print "black.\n";
1ab173
-    system("ppmmake \\#000 $width $height >junk2$$.ppm");
1ab173
+    system("ppmmake \\#000 $width $height >$tmpdir/junk2$$.ppm");
1ab173
 } else {
1ab173
     print "$last_file\n";
1ab173
-    system("cp", $last_file, "junk2$$.ppm");
1ab173
+    system("cp", $last_file, "$tmpdir/junk2$$.ppm");
1ab173
 }
1ab173
 
1ab173
 #
780b59
@@ -170,14 +176,14 @@ if ($last_file eq "undefined") {
1ab173
 #
1ab173
 
1ab173
 # Here's what our temporary files are:
1ab173
-#   junk1$$.ppm: The original (fade-from) image
1ab173
-#   junk2$$.ppm: The target (fade-from) image
1ab173
-#   junk3$$.ppm: The frame of the fade for the current iteration of the 
1ab173
-#                the for loop.
1ab173
-#   junk1a$$.ppm: If the fade involves a ppmmix sequence from one intermediate
1ab173
-#                 image to another, this is the first frame of that 
1ab173
-#                 sequence.
1ab173
-#   junk2a$$.ppm: This is the last frame of the above-mentioned ppmmix sequence
1ab173
+#   $tmpdir/junk1$$.ppm: The original (fade-from) image
1ab173
+#   $tmpdir/junk2$$.ppm: The target (fade-from) image
1ab173
+#   $tmpdir/junk3$$.ppm: The frame of the fade for the current iteration of the 
1ab173
+#                	 the for loop.
1ab173
+#   $tmpdir/junk1a$$.ppm: If the fade involves a ppmmix sequence from one intermediate
1ab173
+#                         image to another, this is the first frame of that 
1ab173
+#                         sequence.
1ab173
+#   $tmpdir/junk2a$$.ppm: This is the last frame of the above-mentioned ppmmix sequence
1ab173
 
1ab173
 my $i;    # Frame number
1ab173
 for ($i = 1; $i <= $nframes; $i++) {
780b59
@@ -185,147 +191,147 @@ for ($i = 1; $i <= $nframes; $i++) {
1ab173
     if ($mode eq $SPREAD) {
1ab173
         if ($i <= 10) {
1ab173
             my $n = $spline20[$i] * 100;
1ab173
-            system("ppmspread $n junk1$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmspread $n $tmpdir/junk1$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } elsif ($i <= 20) {
1ab173
             my $n;
1ab173
             $n = $spline20[$i] * 100;
1ab173
-            system("ppmspread $n junk1$$.ppm >junk1a$$.ppm");
1ab173
+            system("ppmspread $n $tmpdir/junk1$$.ppm >$tmpdir/junk1a$$.ppm");
1ab173
             $n = (1-$spline20[$i-10]) * 100;
1ab173
-            system("ppmspread $n junk2$$.ppm >junk2a$$.ppm");
1ab173
+            system("ppmspread $n $tmpdir/junk2$$.ppm >$tmpdir/junk2a$$.ppm");
1ab173
             $n = $spline10[$i-10];
1ab173
-            system("ppmmix $n junk1a$$.ppm junk2a$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1a$$.ppm $tmpdir/junk2a$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } else {
1ab173
             my $n = (1-$spline20[$i-10])*100;
1ab173
-            system("ppmspread $n junk2$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmspread $n $tmpdir/junk2$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         }
1ab173
     } elsif ($mode eq $SHIFT) {
1ab173
         if ($i <= 10) {
1ab173
             my $n = $spline20[$i] * 100;
1ab173
-            system("ppmshift $n junk1$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmshift $n $tmpdir/junk1$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } elsif ($i <= 20) {
1ab173
             my $n;
1ab173
             $n = $spline20[$i] * 100;
1ab173
-            system("ppmshift $n junk1$$.ppm >junk1a$$.ppm");
1ab173
+            system("ppmshift $n $tmpdir/junk1$$.ppm >$tmpdir/junk1a$$.ppm");
1ab173
             $n = (1-$spline20[$i-10])*100;
1ab173
-            system("ppmshift $n junk2$$.ppm >junk2a$$.ppm");
1ab173
+            system("ppmshift $n $tmpdir/junk2$$.ppm >$tmpdir/junk2a$$.ppm");
1ab173
             $n = $spline10[$i-10];
1ab173
-            system("ppmmix $n junk1a$$.ppm junk2a$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1a$$.ppm $tmpdir/junk2a$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } else {
1ab173
             my $n = (1-$spline20[$i-10]) * 100;
1ab173
-            system("ppmshift $n junk2$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmshift $n $tmpdir/junk2$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         }
1ab173
     } elsif ($mode eq $RELIEF) {
1ab173
         if ($i == 1) {
1ab173
-            system("ppmrelief junk1$$.ppm >junk1r$$.ppm");
1ab173
+            system("ppmrelief $tmpdir/junk1$$.ppm >$tmpdir/junk1r$$.ppm");
1ab173
         }
1ab173
         if ($i <= 10) {
1ab173
             my $n = $spline10[$i];
1ab173
-            system("ppmmix $n junk1$$.ppm junk1r$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1$$.ppm $tmpdir/junk1r$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } elsif ($i <= 20) {
1ab173
             my $n = $spline10[$i-10];
1ab173
-            system("ppmmix $n junk1r$$.ppm junk2r$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1r$$.ppm $tmpdir/junk2r$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } else {
1ab173
             my $n = $spline10[$i-20];
1ab173
-            system("ppmmix $n junk2r$$.ppm junk2$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk2r$$.ppm $tmpdir/junk2$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         }
1ab173
         if ($i == 10) {
1ab173
-            system("ppmrelief junk2$$.ppm >junk2r$$.ppm");
1ab173
+            system("ppmrelief $tmpdir/junk2$$.ppm >$tmpdir/junk2r$$.ppm");
1ab173
         }
1ab173
     } elsif ($mode eq $OIL) {
1ab173
         if ($i == 1) {
1ab173
-            system("ppmtopgm junk1$$.ppm | pgmoil >junko$$.ppm");
1ab173
-            system("rgb3toppm junko$$.ppm junko$$.ppm junko$$.ppm " .
1ab173
-                   ">junk1o$$.ppm");
1ab173
+            system("ppmtopgm $tmpdir/junk1$$.ppm | pgmoil >$tmpdir/junko$$.ppm");
1ab173
+            system("rgb3toppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm " .
1ab173
+                   ">$tmpdir/junk1o$$.ppm");
1ab173
         }
1ab173
         if ($i <= 10) {
1ab173
             my $n = $spline10[$i];
1ab173
-            system("ppmmix $n junk1$$.ppm junk1o$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1$$.ppm $tmpdir/junk1o$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } elsif ($i <= 20) {
1ab173
             my $n = $spline10[$i-10];
1ab173
-            system("ppmmix $n junk1o$$.ppm junk2o$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1o$$.ppm $tmpdir/junk2o$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } else {
1ab173
             my $n = $spline10[$i-20];
1ab173
-            system("ppmmix $n junk2o$$.ppm junk2$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk2o$$.ppm $tmpdir/junk2$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         }
1ab173
         if ($i == 10) {
1ab173
-            system("ppmtopgm junk2$$.ppm | pgmoil >junko$$.ppm");
1ab173
-            system("rgb3toppm junko$$.ppm junko$$.ppm junko$$.ppm " .
1ab173
-                   ">junk2o$$.ppm");
1ab173
+            system("ppmtopgm $tmpdir/junk2$$.ppm | pgmoil >$tmpdir/junko$$.ppm");
1ab173
+            system("rgb3toppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm " .
1ab173
+                   ">$tmpdir/junk2o$$.ppm");
1ab173
         }
1ab173
     } elsif ($mode eq $EDGE) {
1ab173
         if ($i == 1) {
1ab173
-            system("ppmtopgm junk1$$.ppm | pgmedge >junko$$.ppm");
1ab173
-            system("rgb3toppm junko$$.ppm junko$$.ppm junko$$.ppm " .
1ab173
-                   ">junk1o$$.ppm");
1ab173
+            system("ppmtopgm $tmpdir/junk1$$.ppm | pgmedge >$tmpdir/junko$$.ppm");
1ab173
+            system("rgb3toppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm " .
1ab173
+                   ">$tmpdir/junk1o$$.ppm");
1ab173
         }
1ab173
         if ($i <= 10) {
1ab173
             my $n = $spline10[$i];
1ab173
-            system("ppmmix $n junk1$$.ppm junk1o$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1$$.ppm $tmpdir/junk1o$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } elsif ($i <= 20) {
1ab173
             my $n = $spline10[$i-10];
1ab173
-            system("ppmmix $n junk1o$$.ppm junk2o$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1o$$.ppm $tmpdir/junk2o$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } else {
1ab173
             my $n = $spline10[$i-20];
1ab173
-            system("ppmmix $n junk2o$$.ppm junk2$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk2o$$.ppm $tmpdir/junk2$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         }
1ab173
         if ($i == 10) {
1ab173
-            system("ppmtopgm junk2$$.ppm | pgmedge >junko$$.ppm");
1ab173
-            system("rgb3toppm junko$$.ppm junko$$.ppm junko$$.ppm " .
1ab173
-                   ">junk2o$$.ppm");
1ab173
+            system("ppmtopgm $tmpdir/junk2$$.ppm | pgmedge >$tmpdir/junko$$.ppm");
1ab173
+            system("rgb3toppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm " .
1ab173
+                   ">$tmpdir/junk2o$$.ppm");
1ab173
         } 
1ab173
     } elsif ($mode eq $BENTLEY) {
1ab173
         if ($i == 1) {
1ab173
-            system("ppmtopgm junk1$$.ppm | pgmbentley >junko$$.ppm");
1ab173
-            system("rgb3toppm junko$$.ppm junko$$.ppm junko$$.ppm " .
1ab173
-                   ">junk1o$$.ppm");
1ab173
+            system("ppmtopgm $tmpdir/junk1$$.ppm | pgmbentley >$tmpdir/junko$$.ppm");
1ab173
+            system("rgb3toppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm " .
1ab173
+                   ">$tmpdir/junk1o$$.ppm");
1ab173
         }
1ab173
         if ($i <= 10) {
1ab173
             my $n = $spline10[$i];
1ab173
-            system("ppmmix $n junk1$$.ppm junk1o$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1$$.ppm $tmpdir/junk1o$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } elsif ($i <= 20) {
1ab173
             my $n = $spline10[$i-10];
1ab173
-            system("ppmmix $n junk1o$$.ppm junk2o$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1o$$.ppm $tmpdir/junk2o$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } else {
1ab173
             my $n = $spline10[$i-20];
1ab173
-            system("ppmmix $n junk2o$$.ppm junk2$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk2o$$.ppm $tmpdir/junk2$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         }
1ab173
         if ($i == 10) {
1ab173
-            system("ppmtopgm junk2$$.ppm | pgmbentley >junko$$.ppm");
1ab173
-            system("rgb3toppm junko$$.ppm junko$$.ppm junko$$.ppm " .
1ab173
-                   ">junk2o$$.ppm");
1ab173
+            system("ppmtopgm $tmpdir/junk2$$.ppm | pgmbentley >$tmpdir/junko$$.ppm");
1ab173
+            system("rgb3toppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm $tmpdir/junko$$.ppm " .
1ab173
+                   ">$tmpdir/junk2o$$.ppm");
1ab173
         }
1ab173
     } elsif ($mode eq $BLOCK) {
1ab173
         if ($i <= 10) {
1ab173
             my $n = 1 - 1.9*$spline20[$i];
1ab173
-            system("pamscale $n junk1$$.ppm | " .
1ab173
-                   "pamscale -width $width -height $height >junk3$$.ppm");
1ab173
+            system("pamscale $n $tmpdir/junk1$$.ppm | " .
1ab173
+                   "pamscale -width $width -height $height >$tmpdir/junk3$$.ppm");
1ab173
         } elsif ($i <= 20) {
1ab173
             my $n = $spline10[$i-10];
1ab173
-            system("ppmmix $n junk1a$$.ppm junk2a$$.ppm >junk3$$.ppm");
1ab173
+            system("ppmmix $n $tmpdir/junk1a$$.ppm $tmpdir/junk2a$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
         } else {
1ab173
             my $n = 1 - 1.9*$spline20[31-$i];
1ab173
-            system("pamscale $n junk2$$.ppm | " .
1ab173
-                   "pamscale -width $width -height $height >junk3$$.ppm");
1ab173
+            system("pamscale $n $tmpdir/junk2$$.ppm | " .
1ab173
+                   "pamscale -width $width -height $height >$tmpdir/junk3$$.ppm");
1ab173
         }
1ab173
         if ($i == 10) {
1ab173
-            system("cp", "junk3$$.ppm", "junk1a$$.ppm");
1ab173
-            system("pamscale $n junk2$$.ppm | " .
1ab173
-                   "pamscale -width $width -height $height >junk2a$$.ppm");
1ab173
+            system("cp", "$tmpdir/junk3$$.ppm", "$tmpdir/junk1a$$.ppm");
1ab173
+            system("pamscale $n $tmpdir/junk2$$.ppm | " .
1ab173
+                   "pamscale -width $width -height $height >$tmpdir/junk2a$$.ppm");
1ab173
         }    
1ab173
     } elsif ($mode eq $MIX) {
1ab173
         my $fade_factor = sqrt(1/($nframes-$i+1));
1ab173
-        system("ppmmix $fade_factor junk1$$.ppm junk2$$.ppm >junk3$$.ppm");
1ab173
+        system("ppmmix $fade_factor $tmpdir/junk1$$.ppm $tmpdir/junk2$$.ppm >$tmpdir/junk3$$.ppm");
1ab173
     } else {
1ab173
         print("Internal error: impossible mode value '$mode'\n");
1ab173
     }
1ab173
 
1ab173
     my $outfile = sprintf("%s.%04d.ppm", $base_name, $i);
1ab173
-    system("cp", "junk3$$.ppm", $outfile);
1ab173
+    system("cp", "$tmpdir/junk3$$.ppm", $outfile);
1ab173
 }
1ab173
 
1ab173
 #
1ab173
 #  Clean up shop.
1ab173
 #
1ab173
-system("rm junk*$$.ppm");
1ab173
+system("rm $tmpdir/junk*$$.ppm");
1ab173
 
1ab173
 exit(0);
780b59
diff -urNp old/editor/ppmshadow neew/editor/ppmshadow
780b59
--- old/editor/ppmshadow	2017-09-05 12:58:26.768741946 +0200
780b59
+++ neew/editor/ppmshadow	2017-09-05 13:02:51.480507649 +0200
780b59
@@ -171,11 +171,12 @@ my $tmpdir = $ENV{TMPDIR} || "/tmp";
780b59
 my $ourtmp;
1ab173
 
780b59
 if ($keeptemp) {
780b59
-    $ourtmp = "$tmpdir/ppmshadow$$";
780b59
-    mkdir($ourtmp, 0777) or
780b59
-        die("Unable to create directory for temporary files '$ourtmp");
780b59
+    $ourtmp = chomp($ourtmp = `mktemp -d -t PPMshadow.XXXXXX`);
780b59
+    if($? >> 8) {
780b59
+        die "Can't create directory for temporary files";
780b59
+    }
780b59
 } else {
780b59
-    $ourtmp = File::Temp::tempdir("$tmpdir/ppmshadowXXXX", UNLINK=>1);
780b59
+    $ourtmp = File::Temp::tempdir("$tmpdir/PPMshadow.XXXXXX", UNLINK=>1);
780b59
 }
1ab173
 
780b59
 #   Apply defaults for arguments not specified