|
 |
872173 |
From 4589352dac3ae111c7621298cf231742209efd9b Mon Sep 17 00:00:00 2001
|
|
|
872173 |
From: Bill Fenner <fenner@gmail.com>
|
|
|
872173 |
Date: Fri, 25 Nov 2022 08:41:24 -0800
|
|
|
872173 |
Subject: [PATCH 1/3] snmp_agent: disallow SET with NULL varbind
|
|
|
872173 |
|
|
|
872173 |
---
|
|
|
872173 |
agent/snmp_agent.c | 32 ++++++++++++++++++++++++++++++++
|
|
|
872173 |
1 file changed, 32 insertions(+)
|
|
|
872173 |
|
|
|
872173 |
diff --git a/agent/snmp_agent.c b/agent/snmp_agent.c
|
|
|
872173 |
index 867d0c166f..3f678fe2df 100644
|
|
|
872173 |
--- a/agent/snmp_agent.c
|
|
|
872173 |
+++ b/agent/snmp_agent.c
|
|
|
872173 |
@@ -3719,12 +3719,44 @@ netsnmp_handle_request(netsnmp_agent_session *asp, int status)
|
|
|
872173 |
return 1;
|
|
|
872173 |
}
|
|
|
872173 |
|
|
|
872173 |
+static int
|
|
|
872173 |
+check_set_pdu_for_null_varbind(netsnmp_agent_session *asp)
|
|
|
872173 |
+{
|
|
|
872173 |
+ int i;
|
|
|
872173 |
+ netsnmp_variable_list *v = NULL;
|
|
|
872173 |
+
|
|
|
872173 |
+ for (i = 1, v = asp->pdu->variables; v != NULL; i++, v = v->next_variable) {
|
|
|
872173 |
+ if (v->type == ASN_NULL) {
|
|
|
872173 |
+ /*
|
|
|
872173 |
+ * Protect SET implementations that do not protect themselves
|
|
|
872173 |
+ * against wrong type.
|
|
|
872173 |
+ */
|
|
|
872173 |
+ DEBUGMSGTL(("snmp_agent", "disallowing SET with NULL var for varbind %d\n", i));
|
|
|
872173 |
+ asp->index = i;
|
|
|
872173 |
+ return SNMP_ERR_WRONGTYPE;
|
|
|
872173 |
+ }
|
|
|
872173 |
+ }
|
|
|
872173 |
+ return SNMP_ERR_NOERROR;
|
|
|
872173 |
+}
|
|
|
872173 |
+
|
|
|
872173 |
int
|
|
|
872173 |
handle_pdu(netsnmp_agent_session *asp)
|
|
|
872173 |
{
|
|
|
872173 |
int status, inclusives = 0;
|
|
|
872173 |
netsnmp_variable_list *v = NULL;
|
|
|
872173 |
|
|
|
872173 |
+#ifndef NETSNMP_NO_WRITE_SUPPORT
|
|
|
872173 |
+ /*
|
|
|
872173 |
+ * Check for ASN_NULL in SET request
|
|
|
872173 |
+ */
|
|
|
872173 |
+ if (asp->pdu->command == SNMP_MSG_SET) {
|
|
|
872173 |
+ status = check_set_pdu_for_null_varbind(asp);
|
|
|
872173 |
+ if (status != SNMP_ERR_NOERROR) {
|
|
|
872173 |
+ return status;
|
|
|
872173 |
+ }
|
|
|
872173 |
+ }
|
|
|
872173 |
+#endif /* NETSNMP_NO_WRITE_SUPPORT */
|
|
|
872173 |
+
|
|
|
872173 |
/*
|
|
|
872173 |
* for illegal requests, mark all nodes as ASN_NULL
|
|
|
872173 |
*/
|
|
|
872173 |
|
|
|
872173 |
From 7f4ac4051cc7fec6a5944661923acb95cec359c7 Mon Sep 17 00:00:00 2001
|
|
|
872173 |
From: Bill Fenner <fenner@gmail.com>
|
|
|
872173 |
Date: Fri, 25 Nov 2022 08:41:46 -0800
|
|
|
872173 |
Subject: [PATCH 2/3] apps: snmpset: allow SET with NULL varbind for testing
|
|
|
872173 |
|
|
|
872173 |
---
|
|
|
872173 |
apps/snmpset.c | 1 +
|
|
|
872173 |
1 file changed, 1 insertion(+)
|
|
|
872173 |
|
|
|
872173 |
diff --git a/apps/snmpset.c b/apps/snmpset.c
|
|
|
872173 |
index 48e14bd513..d542713e1b 100644
|
|
|
872173 |
--- a/apps/snmpset.c
|
|
|
872173 |
+++ b/apps/snmpset.c
|
|
|
872173 |
@@ -182,6 +182,7 @@ main(int argc, char *argv[])
|
|
|
872173 |
case 'x':
|
|
|
872173 |
case 'd':
|
|
|
872173 |
case 'b':
|
|
|
872173 |
+ case 'n': /* undocumented */
|
|
|
872173 |
#ifdef NETSNMP_WITH_OPAQUE_SPECIAL_TYPES
|
|
|
872173 |
case 'I':
|
|
|
872173 |
case 'U':
|
|
|
872173 |
|
|
|
872173 |
From 15f9d7f7e5b90c9b419832ed8e6413feb6570d83 Mon Sep 17 00:00:00 2001
|
|
|
872173 |
From: Bill Fenner <fenner@gmail.com>
|
|
|
872173 |
Date: Fri, 25 Nov 2022 10:23:32 -0800
|
|
|
872173 |
Subject: [PATCH 3/3] Add test for NULL varbind set
|
|
|
872173 |
|
|
|
872173 |
---
|
|
|
872173 |
.../default/T0142snmpv2csetnull_simple | 31 +++++++++++++++++++
|
|
|
872173 |
1 file changed, 31 insertions(+)
|
|
|
872173 |
create mode 100644 testing/fulltests/default/T0142snmpv2csetnull_simple
|
|
|
872173 |
|
|
|
872173 |
diff --git a/testing/fulltests/default/T0142snmpv2csetnull_simple b/testing/fulltests/default/T0142snmpv2csetnull_simple
|
|
|
872173 |
new file mode 100644
|
|
|
872173 |
index 0000000000..0f1b8f386b
|
|
|
872173 |
--- /dev/null
|
|
|
872173 |
+++ b/testing/fulltests/default/T0142snmpv2csetnull_simple
|
|
|
872173 |
@@ -0,0 +1,31 @@
|
|
|
872173 |
+#!/bin/sh
|
|
|
872173 |
+
|
|
|
872173 |
+. ../support/simple_eval_tools.sh
|
|
|
872173 |
+
|
|
|
872173 |
+HEADER SNMPv2c set of system.sysContact.0 with NULL varbind
|
|
|
872173 |
+
|
|
|
872173 |
+SKIPIF NETSNMP_DISABLE_SET_SUPPORT
|
|
|
872173 |
+SKIPIF NETSNMP_NO_WRITE_SUPPORT
|
|
|
872173 |
+SKIPIF NETSNMP_DISABLE_SNMPV2C
|
|
|
872173 |
+SKIPIFNOT USING_MIBII_SYSTEM_MIB_MODULE
|
|
|
872173 |
+
|
|
|
872173 |
+#
|
|
|
872173 |
+# Begin test
|
|
|
872173 |
+#
|
|
|
872173 |
+
|
|
|
872173 |
+# standard V2C configuration: testcomunnity
|
|
|
872173 |
+snmp_write_access='all'
|
|
|
872173 |
+. ./Sv2cconfig
|
|
|
872173 |
+STARTAGENT
|
|
|
872173 |
+
|
|
|
872173 |
+CAPTURE "snmpget -On $SNMP_FLAGS -c testcommunity -v 2c $SNMP_TRANSPORT_SPEC:$SNMP_TEST_DEST$SNMP_SNMPD_PORT .1.3.6.1.2.1.1.4.0"
|
|
|
872173 |
+
|
|
|
872173 |
+CHECK ".1.3.6.1.2.1.1.4.0 = STRING:"
|
|
|
872173 |
+
|
|
|
872173 |
+CAPTURE "snmpset -On $SNMP_FLAGS -c testcommunity -v 2c $SNMP_TRANSPORT_SPEC:$SNMP_TEST_DEST$SNMP_SNMPD_PORT .1.3.6.1.2.1.1.4.0 n x"
|
|
|
872173 |
+
|
|
|
872173 |
+CHECK "Reason: wrongType"
|
|
|
872173 |
+
|
|
|
872173 |
+STOPAGENT
|
|
|
872173 |
+
|
|
|
872173 |
+FINISHED
|
|
|
872173 |
|