|
 |
26ccd9 |
From 3b5fb8b6428dfaab39bab58d67412427f514c1f4 Mon Sep 17 00:00:00 2001
|
|
|
26ccd9 |
From: Vaibhav Jain <vaibhav@linux.ibm.com>
|
|
|
26ccd9 |
Date: Sat, 26 Feb 2022 17:09:55 +0530
|
|
|
26ccd9 |
Subject: [PATCH 142/217] util/size.h: Fix build error for GCC < 10
|
|
|
26ccd9 |
|
|
|
26ccd9 |
Building with GCC 8.4.1 results in following build error for 'util/size.c':
|
|
|
26ccd9 |
|
|
|
26ccd9 |
../util/size.h:57:16: error: missing binary operator before token "("
|
|
|
26ccd9 |
__has_builtin(__builtin_mul_overflow) && \
|
|
|
26ccd9 |
|
|
|
26ccd9 |
This is caused due to missing '__has_builtin' preprocessor operator in GCC
|
|
|
26ccd9 |
versions < 10.0.0. The patch updates the check for CLANG's availability of
|
|
|
26ccd9 |
__builtin_{mul,add}_overflow to prevent preprocessor from evaluating the
|
|
|
26ccd9 |
expression "___has_builtin(__builtin_mul_overflow) &&
|
|
|
26ccd9 |
__has_builtin(__builtin_add_overflow)".
|
|
|
26ccd9 |
|
|
|
26ccd9 |
Link: https://lore.kernel.org/r/20220226113955.526036-1-vaibhav@linux.ibm.com
|
|
|
26ccd9 |
Fixes:10653a171bc0("util/size.h: fix build for older compilers")
|
|
|
26ccd9 |
Reported-by: Tarun Sahu <tsahu@linux.ibm.com>
|
|
|
26ccd9 |
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
|
|
|
26ccd9 |
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
|
|
|
26ccd9 |
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
|
|
|
26ccd9 |
---
|
|
|
26ccd9 |
util/size.h | 5 +++--
|
|
|
26ccd9 |
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
26ccd9 |
|
|
|
26ccd9 |
diff --git a/util/size.h b/util/size.h
|
|
|
26ccd9 |
index 1cb0669..02baa77 100644
|
|
|
26ccd9 |
--- a/util/size.h
|
|
|
26ccd9 |
+++ b/util/size.h
|
|
|
26ccd9 |
@@ -53,11 +53,12 @@ static inline bool is_power_of_2(unsigned long long v)
|
|
|
26ccd9 |
#define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
|
|
|
26ccd9 |
#endif
|
|
|
26ccd9 |
|
|
|
26ccd9 |
-#if __clang__ && \
|
|
|
26ccd9 |
- __has_builtin(__builtin_mul_overflow) && \
|
|
|
26ccd9 |
+#if __clang__
|
|
|
26ccd9 |
+#if __has_builtin(__builtin_mul_overflow) && \
|
|
|
26ccd9 |
__has_builtin(__builtin_add_overflow)
|
|
|
26ccd9 |
#define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
|
|
|
26ccd9 |
#endif
|
|
|
26ccd9 |
+#endif
|
|
|
26ccd9 |
|
|
|
26ccd9 |
#if COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW
|
|
|
26ccd9 |
|
|
|
26ccd9 |
--
|
|
|
26ccd9 |
2.27.0
|
|
|
26ccd9 |
|