|
 |
26ccd9 |
From 91f78bbcda7fc644041dfabfa679c6a627f90e76 Mon Sep 17 00:00:00 2001
|
|
|
26ccd9 |
From: Dan Williams <dan.j.williams@intel.com>
|
|
|
26ccd9 |
Date: Sun, 23 Jan 2022 16:53:08 -0800
|
|
|
26ccd9 |
Subject: [PATCH 101/217] util/json: Warn on stderr about empty list results
|
|
|
26ccd9 |
|
|
|
26ccd9 |
Help interactive users notice something is wrong with the list parameters
|
|
|
26ccd9 |
by warning that no devices matched the specified filter settings.
|
|
|
26ccd9 |
|
|
|
26ccd9 |
Link: https://lore.kernel.org/r/164298558814.3021641.13051269428355986099.stgit@dwillia2-desk3.amr.corp.intel.com
|
|
|
26ccd9 |
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
|
|
|
26ccd9 |
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
|
|
|
26ccd9 |
---
|
|
|
26ccd9 |
util/json.c | 7 +++++--
|
|
|
26ccd9 |
1 file changed, 5 insertions(+), 2 deletions(-)
|
|
|
26ccd9 |
|
|
|
26ccd9 |
diff --git a/util/json.c b/util/json.c
|
|
|
26ccd9 |
index bd5f8fc..f8cc81f 100644
|
|
|
26ccd9 |
--- a/util/json.c
|
|
|
26ccd9 |
+++ b/util/json.c
|
|
|
26ccd9 |
@@ -3,6 +3,7 @@
|
|
|
26ccd9 |
#include <limits.h>
|
|
|
26ccd9 |
#include <string.h>
|
|
|
26ccd9 |
#include <stdio.h>
|
|
|
26ccd9 |
+#include <util/util.h>
|
|
|
26ccd9 |
#include <util/json.h>
|
|
|
26ccd9 |
#include <json-c/json.h>
|
|
|
26ccd9 |
#include <json-c/printbuf.h>
|
|
|
26ccd9 |
@@ -95,9 +96,11 @@ void util_display_json_array(FILE *f_out, struct json_object *jarray,
|
|
|
26ccd9 |
int len = json_object_array_length(jarray);
|
|
|
26ccd9 |
int jflag = JSON_C_TO_STRING_PRETTY;
|
|
|
26ccd9 |
|
|
|
26ccd9 |
- if (json_object_array_length(jarray) > 1 || !(flags & UTIL_JSON_HUMAN))
|
|
|
26ccd9 |
+ if (len > 1 || !(flags & UTIL_JSON_HUMAN)) {
|
|
|
26ccd9 |
+ if (len == 0)
|
|
|
26ccd9 |
+ warning("no matching devices found\n");
|
|
|
26ccd9 |
fprintf(f_out, "%s\n", json_object_to_json_string_ext(jarray, jflag));
|
|
|
26ccd9 |
- else if (len) {
|
|
|
26ccd9 |
+ } else if (len) {
|
|
|
26ccd9 |
struct json_object *jobj;
|
|
|
26ccd9 |
|
|
|
26ccd9 |
jobj = json_object_array_get_idx(jarray, 0);
|
|
|
26ccd9 |
--
|
|
|
26ccd9 |
2.27.0
|
|
|
26ccd9 |
|