|
 |
26ccd9 |
From 940acf65a61595e8c0db3aebe1c74307acbbef68 Mon Sep 17 00:00:00 2001
|
|
|
26ccd9 |
From: Dan Williams <dan.j.williams@intel.com>
|
|
|
26ccd9 |
Date: Tue, 12 Jan 2021 23:15:14 -0800
|
|
|
26ccd9 |
Subject: [PATCH 006/217] ndctl/test: Exercise soft_offline_page() corner cases
|
|
|
26ccd9 |
|
|
|
26ccd9 |
Test soft-offline injection into PMEM namespace metadata and user mapped
|
|
|
26ccd9 |
space. Both attempts should fail on kernels with a pfn_to_online_page()
|
|
|
26ccd9 |
implementation that considers subsection ZONE_DEVICE ranges.
|
|
|
26ccd9 |
|
|
|
26ccd9 |
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
|
|
|
26ccd9 |
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
|
|
|
26ccd9 |
Link: https://lore.kernel.org/r/161052211455.1804207.13884321454837200896.stgit@dwillia2-desk3.amr.corp.intel.com
|
|
|
26ccd9 |
---
|
|
|
26ccd9 |
test/dax-poison.c | 19 +++++++++++++++++++
|
|
|
26ccd9 |
test/device-dax.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
|
|
|
26ccd9 |
2 files changed, 64 insertions(+)
|
|
|
26ccd9 |
|
|
|
26ccd9 |
diff --git a/test/dax-poison.c b/test/dax-poison.c
|
|
|
26ccd9 |
index a4ef12e..4e09761 100644
|
|
|
26ccd9 |
--- a/test/dax-poison.c
|
|
|
26ccd9 |
+++ b/test/dax-poison.c
|
|
|
26ccd9 |
@@ -5,6 +5,7 @@
|
|
|
26ccd9 |
#include <signal.h>
|
|
|
26ccd9 |
#include <setjmp.h>
|
|
|
26ccd9 |
#include <sys/mman.h>
|
|
|
26ccd9 |
+#include <linux/mman.h>
|
|
|
26ccd9 |
#include <fcntl.h>
|
|
|
26ccd9 |
#include <string.h>
|
|
|
26ccd9 |
#include <errno.h>
|
|
|
26ccd9 |
@@ -49,6 +50,7 @@ int test_dax_poison(struct ndctl_test *test, int dax_fd, unsigned long align,
|
|
|
26ccd9 |
unsigned char *addr = MAP_FAILED;
|
|
|
26ccd9 |
struct sigaction act;
|
|
|
26ccd9 |
unsigned x = x;
|
|
|
26ccd9 |
+ FILE *smaps;
|
|
|
26ccd9 |
void *buf;
|
|
|
26ccd9 |
int rc;
|
|
|
26ccd9 |
|
|
|
26ccd9 |
@@ -94,6 +96,9 @@ int test_dax_poison(struct ndctl_test *test, int dax_fd, unsigned long align,
|
|
|
26ccd9 |
goto out;
|
|
|
26ccd9 |
}
|
|
|
26ccd9 |
|
|
|
26ccd9 |
+ fprintf(stderr, "%s: mmap got %p align: %ld offset: %zd\n",
|
|
|
26ccd9 |
+ __func__, addr, align, offset);
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
if (sigsetjmp(sj_env, 1)) {
|
|
|
26ccd9 |
if (sig_mcerr_ar) {
|
|
|
26ccd9 |
fprintf(stderr, "madvise triggered 'action required' sigbus\n");
|
|
|
26ccd9 |
@@ -104,6 +109,20 @@ int test_dax_poison(struct ndctl_test *test, int dax_fd, unsigned long align,
|
|
|
26ccd9 |
}
|
|
|
26ccd9 |
}
|
|
|
26ccd9 |
|
|
|
26ccd9 |
+ rc = madvise(addr + align / 2, 4096, MADV_SOFT_OFFLINE);
|
|
|
26ccd9 |
+ if (rc == 0) {
|
|
|
26ccd9 |
+ fprintf(stderr, "softoffline should always fail for dax\n");
|
|
|
26ccd9 |
+ smaps = fopen("/proc/self/smaps", "r");
|
|
|
26ccd9 |
+ do {
|
|
|
26ccd9 |
+ rc = fread(buf, 1, 4096, smaps);
|
|
|
26ccd9 |
+ fwrite(buf, 1, rc, stderr);
|
|
|
26ccd9 |
+ } while (rc);
|
|
|
26ccd9 |
+ fclose(smaps);
|
|
|
26ccd9 |
+ fail();
|
|
|
26ccd9 |
+ rc = -ENXIO;
|
|
|
26ccd9 |
+ goto out;
|
|
|
26ccd9 |
+ }
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
rc = madvise(addr + align / 2, 4096, MADV_HWPOISON);
|
|
|
26ccd9 |
if (rc) {
|
|
|
26ccd9 |
fail();
|
|
|
26ccd9 |
diff --git a/test/device-dax.c b/test/device-dax.c
|
|
|
26ccd9 |
index 5f0da29..aad8fa5 100644
|
|
|
26ccd9 |
--- a/test/device-dax.c
|
|
|
26ccd9 |
+++ b/test/device-dax.c
|
|
|
26ccd9 |
@@ -128,6 +128,44 @@ static int verify_data(struct daxctl_dev *dev, char *dax_buf,
|
|
|
26ccd9 |
return 0;
|
|
|
26ccd9 |
}
|
|
|
26ccd9 |
|
|
|
26ccd9 |
+static int test_dax_soft_offline(struct ndctl_test *test, struct ndctl_namespace *ndns)
|
|
|
26ccd9 |
+{
|
|
|
26ccd9 |
+ unsigned long long resource = ndctl_namespace_get_resource(ndns);
|
|
|
26ccd9 |
+ int fd, rc;
|
|
|
26ccd9 |
+ char *buf;
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
+ if (resource == ULLONG_MAX) {
|
|
|
26ccd9 |
+ fprintf(stderr, "failed to get resource: %s\n",
|
|
|
26ccd9 |
+ ndctl_namespace_get_devname(ndns));
|
|
|
26ccd9 |
+ return -ENXIO;
|
|
|
26ccd9 |
+ }
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
+ fd = open("/sys/devices/system/memory/soft_offline_page", O_WRONLY);
|
|
|
26ccd9 |
+ if (fd < 0) {
|
|
|
26ccd9 |
+ fprintf(stderr, "failed to open soft_offline_page\n");
|
|
|
26ccd9 |
+ return -ENOENT;
|
|
|
26ccd9 |
+ }
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
+ rc = asprintf(&buf, "%#llx\n", resource);
|
|
|
26ccd9 |
+ if (rc < 0) {
|
|
|
26ccd9 |
+ fprintf(stderr, "failed to alloc resource\n");
|
|
|
26ccd9 |
+ close(fd);
|
|
|
26ccd9 |
+ return -ENOMEM;
|
|
|
26ccd9 |
+ }
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
+ fprintf(stderr, "%s: try to offline page @%#llx\n", __func__, resource);
|
|
|
26ccd9 |
+ rc = write(fd, buf, rc);
|
|
|
26ccd9 |
+ free(buf);
|
|
|
26ccd9 |
+ close(fd);
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
+ if (rc >= 0) {
|
|
|
26ccd9 |
+ fprintf(stderr, "%s: should have failed\n", __func__);
|
|
|
26ccd9 |
+ return -ENXIO;
|
|
|
26ccd9 |
+ }
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
+ return 0;
|
|
|
26ccd9 |
+}
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
static int __test_device_dax(unsigned long align, int loglevel,
|
|
|
26ccd9 |
struct ndctl_test *test, struct ndctl_ctx *ctx)
|
|
|
26ccd9 |
{
|
|
|
26ccd9 |
@@ -278,6 +316,13 @@ static int __test_device_dax(unsigned long align, int loglevel,
|
|
|
26ccd9 |
goto out;
|
|
|
26ccd9 |
}
|
|
|
26ccd9 |
|
|
|
26ccd9 |
+ rc = test_dax_soft_offline(test, ndns);
|
|
|
26ccd9 |
+ if (rc) {
|
|
|
26ccd9 |
+ fprintf(stderr, "%s: failed dax soft offline\n",
|
|
|
26ccd9 |
+ ndctl_namespace_get_devname(ndns));
|
|
|
26ccd9 |
+ goto out;
|
|
|
26ccd9 |
+ }
|
|
|
26ccd9 |
+
|
|
|
26ccd9 |
rc = test_dax_poison(test, fd, align, NULL, 0, devdax);
|
|
|
26ccd9 |
if (rc) {
|
|
|
26ccd9 |
fprintf(stderr, "%s: failed dax poison\n",
|
|
|
26ccd9 |
--
|
|
|
26ccd9 |
2.27.0
|
|
|
26ccd9 |
|