Blame SOURCES/properties-window-Fix-crashes-when-opened-multiple-t.patch
|
 |
0f37e7 |
From c4b567936ebbba8479f6641c89b3980f7963b765 Mon Sep 17 00:00:00 2001
|
|
|
0f37e7 |
From: Ondrej Holy <oholy@redhat.com>
|
|
|
0f37e7 |
Date: Thu, 26 Sep 2019 11:07:35 +0200
|
|
|
0f37e7 |
Subject: [PATCH] properties-window: Fix crashes when opened multiple times
|
|
|
0f37e7 |
|
|
|
0f37e7 |
Nautilus crashes with segmentation fault when closing the properties dialog
|
|
|
0f37e7 |
after it has been opened mutliple times for the same file. This can't be
|
|
|
0f37e7 |
reproduced over Nautilus as it uses modal dialogs, however, it can be simply
|
|
|
0f37e7 |
reproduced over the Desktop Icons extension. Let's check the pending_key
|
|
|
0f37e7 |
variable before used to be sure it is not NULL to fix this crashes.
|
|
|
0f37e7 |
---
|
|
|
0f37e7 |
src/nautilus-properties-window.c | 5 ++++-
|
|
|
0f37e7 |
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
0f37e7 |
|
|
|
0f37e7 |
diff --git a/src/nautilus-properties-window.c b/src/nautilus-properties-window.c
|
|
|
0f37e7 |
index 0112aeb3c..f6b2f21a6 100644
|
|
|
0f37e7 |
--- a/src/nautilus-properties-window.c
|
|
|
0f37e7 |
+++ b/src/nautilus-properties-window.c
|
|
|
0f37e7 |
@@ -5297,7 +5297,10 @@ remove_pending (StartupData *startup_data,
|
|
|
0f37e7 |
eel_timed_wait_stop
|
|
|
0f37e7 |
(cancel_create_properties_window_callback, startup_data);
|
|
|
0f37e7 |
}
|
|
|
0f37e7 |
- g_hash_table_remove (pending_lists, startup_data->pending_key);
|
|
|
0f37e7 |
+ if (startup_data->pending_key != NULL)
|
|
|
0f37e7 |
+ {
|
|
|
0f37e7 |
+ g_hash_table_remove (pending_lists, startup_data->pending_key);
|
|
|
0f37e7 |
+ }
|
|
|
0f37e7 |
}
|
|
|
0f37e7 |
|
|
|
0f37e7 |
static gboolean
|
|
|
0f37e7 |
--
|
|
|
0f37e7 |
2.23.0
|
|
|
0f37e7 |
|