|
 |
7dc08b |
From b9d87e0deb528817689f1648999a95645b1b19ad Mon Sep 17 00:00:00 2001
|
|
|
7dc08b |
From: Keita SUZUKI <keita@osstech.co.jp>
|
|
|
7dc08b |
Date: Mon, 20 Jan 2020 11:03:14 +0900
|
|
|
7dc08b |
Subject: [PATCH] avoid always set SameSite cookie
|
|
|
7dc08b |
|
|
|
7dc08b |
---
|
|
|
7dc08b |
auth_mellon.h | 5 +++++
|
|
|
7dc08b |
auth_mellon_cookie.c | 22 ++++++++++++++++------
|
|
|
7dc08b |
2 files changed, 21 insertions(+), 6 deletions(-)
|
|
|
7dc08b |
|
|
|
7dc08b |
diff --git a/auth_mellon.h b/auth_mellon.h
|
|
|
7dc08b |
index 5f5a20b..8bb8023 100644
|
|
|
7dc08b |
--- a/auth_mellon.h
|
|
|
7dc08b |
+++ b/auth_mellon.h
|
|
|
7dc08b |
@@ -96,6 +96,11 @@ typedef enum {
|
|
|
7dc08b |
} am_diag_flags_t;
|
|
|
7dc08b |
#endif
|
|
|
7dc08b |
|
|
|
7dc08b |
+
|
|
|
7dc08b |
+/* Disable SameSite Environment Value */
|
|
|
7dc08b |
+#define AM_DISABLE_SAMESITE_ENV_VAR "MELLON_DISABLE_SAMESITE"
|
|
|
7dc08b |
+
|
|
|
7dc08b |
+
|
|
|
7dc08b |
/* This is the length of the id we use (for session IDs and
|
|
|
7dc08b |
* replaying POST data).
|
|
|
7dc08b |
*/
|
|
|
7dc08b |
diff --git a/auth_mellon_cookie.c b/auth_mellon_cookie.c
|
|
|
7dc08b |
index b2c8535..55f77a5 100644
|
|
|
7dc08b |
--- a/auth_mellon_cookie.c
|
|
|
7dc08b |
+++ b/auth_mellon_cookie.c
|
|
|
7dc08b |
@@ -59,6 +59,7 @@ static const char *am_cookie_params(request_rec *r)
|
|
|
7dc08b |
const char *cookie_domain = ap_get_server_name(r);
|
|
|
7dc08b |
const char *cookie_path = "/";
|
|
|
7dc08b |
const char *cookie_samesite = "";
|
|
|
7dc08b |
+ const char *env_var_value = NULL;
|
|
|
7dc08b |
am_dir_cfg_rec *cfg = am_get_dir_cfg(r);
|
|
|
7dc08b |
|
|
|
7dc08b |
if (cfg->cookie_domain) {
|
|
|
7dc08b |
@@ -69,12 +70,21 @@ static const char *am_cookie_params(request_rec *r)
|
|
|
7dc08b |
cookie_path = cfg->cookie_path;
|
|
|
7dc08b |
}
|
|
|
7dc08b |
|
|
|
7dc08b |
- if (cfg->cookie_samesite == am_samesite_lax) {
|
|
|
7dc08b |
- cookie_samesite = "; SameSite=Lax";
|
|
|
7dc08b |
- } else if (cfg->cookie_samesite == am_samesite_strict) {
|
|
|
7dc08b |
- cookie_samesite = "; SameSite=Strict";
|
|
|
7dc08b |
- } else if (cfg->cookie_samesite == am_samesite_none) {
|
|
|
7dc08b |
- cookie_samesite = "; SameSite=None";
|
|
|
7dc08b |
+ if (r->subprocess_env != NULL){
|
|
|
7dc08b |
+ env_var_value = apr_table_get(r->subprocess_env,
|
|
|
7dc08b |
+ AM_DISABLE_SAMESITE_ENV_VAR);
|
|
|
7dc08b |
+ ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, r->server,
|
|
|
7dc08b |
+ "%s : %s", AM_DISABLE_SAMESITE_ENV_VAR, env_var_value);
|
|
|
7dc08b |
+ }
|
|
|
7dc08b |
+
|
|
|
7dc08b |
+ if (env_var_value == NULL){
|
|
|
7dc08b |
+ if (cfg->cookie_samesite == am_samesite_lax) {
|
|
|
7dc08b |
+ cookie_samesite = "; SameSite=Lax";
|
|
|
7dc08b |
+ } else if (cfg->cookie_samesite == am_samesite_strict) {
|
|
|
7dc08b |
+ cookie_samesite = "; SameSite=Strict";
|
|
|
7dc08b |
+ } else if (cfg->cookie_samesite == am_samesite_none) {
|
|
|
7dc08b |
+ cookie_samesite = "; SameSite=None";
|
|
|
7dc08b |
+ }
|
|
|
7dc08b |
}
|
|
|
7dc08b |
|
|
|
7dc08b |
secure_cookie = cfg->secure;
|
|
|
7dc08b |
--
|
|
|
7dc08b |
2.21.0
|
|
|
7dc08b |
|