|
 |
5c8506 |
From abc0836d587862ba512acf4d4fafcf8cb121bf0a Mon Sep 17 00:00:00 2001
|
|
|
5c8506 |
From: =?UTF-8?q?Ond=C5=99ej=20Lyson=C4=9Bk?= <olysonek@redhat.com>
|
|
|
5c8506 |
Date: Mon, 13 Aug 2018 14:39:44 +0200
|
|
|
5c8506 |
Subject: [PATCH 3/7] Fix file descriptor leaks
|
|
|
5c8506 |
MIME-Version: 1.0
|
|
|
5c8506 |
Content-Type: text/plain; charset=UTF-8
|
|
|
5c8506 |
Content-Transfer-Encoding: 8bit
|
|
|
5c8506 |
|
|
|
5c8506 |
Signed-off-by: Ondřej Lysoněk <olysonek@redhat.com>
|
|
|
5c8506 |
---
|
|
|
5c8506 |
src/dial.c | 5 +++++
|
|
|
5c8506 |
1 file changed, 5 insertions(+)
|
|
|
5c8506 |
|
|
|
5c8506 |
diff --git a/src/dial.c b/src/dial.c
|
|
|
5c8506 |
index a3337e5..eada5ee 100644
|
|
|
5c8506 |
--- a/src/dial.c
|
|
|
5c8506 |
+++ b/src/dial.c
|
|
|
5c8506 |
@@ -912,6 +912,7 @@ int readdialdir(void)
|
|
|
5c8506 |
if (fread(&dial_ver, sizeof(dial_ver), 1, fp) != 1)
|
|
|
5c8506 |
{
|
|
|
5c8506 |
werror(_("Failed to read dialing directory\n"));
|
|
|
5c8506 |
+ fclose(fp);
|
|
|
5c8506 |
return -1;
|
|
|
5c8506 |
}
|
|
|
5c8506 |
if (dial_ver.magic != DIALMAGIC) {
|
|
|
5c8506 |
@@ -947,12 +948,14 @@ int readdialdir(void)
|
|
|
5c8506 |
dial_ver.size > sizeof(struct v4_dialent)) {
|
|
|
5c8506 |
werror(_("Phonelist garbled (unknown version?)"));
|
|
|
5c8506 |
dialents = mkstdent();
|
|
|
5c8506 |
+ fclose(fp);
|
|
|
5c8506 |
return -1;
|
|
|
5c8506 |
}
|
|
|
5c8506 |
break;
|
|
|
5c8506 |
case 5:
|
|
|
5c8506 |
if (dial_ver.size != sizeof(struct dialent)) {
|
|
|
5c8506 |
werror(_("Phonelist corrupted"));
|
|
|
5c8506 |
+ fclose(fp);
|
|
|
5c8506 |
return -1;
|
|
|
5c8506 |
}
|
|
|
5c8506 |
break;
|
|
|
5c8506 |
@@ -961,6 +964,7 @@ int readdialdir(void)
|
|
|
5c8506 |
// have different size on 32 and 64bit systems
|
|
|
5c8506 |
if (dial_ver.size != sizeof(struct dialent) - sizeof(void *)) {
|
|
|
5c8506 |
werror(_("Phonelist corrupted"));
|
|
|
5c8506 |
+ fclose(fp);
|
|
|
5c8506 |
return -1;
|
|
|
5c8506 |
}
|
|
|
5c8506 |
break;
|
|
|
5c8506 |
@@ -968,6 +972,7 @@ int readdialdir(void)
|
|
|
5c8506 |
werror(_("Unknown dialing directory version"));
|
|
|
5c8506 |
dendd = 1;
|
|
|
5c8506 |
dialents = mkstdent();
|
|
|
5c8506 |
+ fclose(fp);
|
|
|
5c8506 |
return -1;
|
|
|
5c8506 |
}
|
|
|
5c8506 |
|
|
|
5c8506 |
--
|
|
|
5c8506 |
2.14.4
|
|
|
5c8506 |
|