|
 |
b7f731 |
From 9db2ab4e9b1ad79b9364b6e03bdd675716a688a5 Mon Sep 17 00:00:00 2001
|
|
|
b7f731 |
From: Jes Sorensen <jsorensen@fb.com>
|
|
|
b7f731 |
Date: Wed, 3 May 2017 14:25:57 -0400
|
|
|
b7f731 |
Subject: [RHEL7.5 PATCH 106/169] util: md_array_valid(): Introduce
|
|
|
b7f731 |
md_array_valid() helper
|
|
|
b7f731 |
|
|
|
b7f731 |
Using md_get_array_info() to determine if an array is valid is broken
|
|
|
b7f731 |
during creation, since the ioctl() returns -ENODEV if the device is
|
|
|
b7f731 |
valid but not active.
|
|
|
b7f731 |
|
|
|
b7f731 |
Where did I leave my stash of brown paper bags?
|
|
|
b7f731 |
|
|
|
b7f731 |
Fixes: ("40b054e mdopen/open_mddev: Use md_get_array_info() to determine valid array")
|
|
|
b7f731 |
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
|
|
|
b7f731 |
---
|
|
|
b7f731 |
mdadm.h | 1 +
|
|
|
b7f731 |
mdopen.c | 3 +--
|
|
|
b7f731 |
util.c | 24 ++++++++++++++++++++++++
|
|
|
b7f731 |
3 files changed, 26 insertions(+), 2 deletions(-)
|
|
|
b7f731 |
|
|
|
b7f731 |
diff --git a/mdadm.h b/mdadm.h
|
|
|
b7f731 |
index 6a382a7..07ee963 100644
|
|
|
b7f731 |
--- a/mdadm.h
|
|
|
b7f731 |
+++ b/mdadm.h
|
|
|
b7f731 |
@@ -1415,6 +1415,7 @@ extern int Dump_metadata(char *dev, char *dir, struct context *c,
|
|
|
b7f731 |
extern int Restore_metadata(char *dev, char *dir, struct context *c,
|
|
|
b7f731 |
struct supertype *st, int only);
|
|
|
b7f731 |
|
|
|
b7f731 |
+int md_array_valid(int fd);
|
|
|
b7f731 |
int md_array_active(int fd);
|
|
|
b7f731 |
int md_get_array_info(int fd, struct mdu_array_info_s *array);
|
|
|
b7f731 |
int md_set_array_info(int fd, struct mdu_array_info_s *array);
|
|
|
b7f731 |
diff --git a/mdopen.c b/mdopen.c
|
|
|
b7f731 |
index 099efa0..c4f1c12 100644
|
|
|
b7f731 |
--- a/mdopen.c
|
|
|
b7f731 |
+++ b/mdopen.c
|
|
|
b7f731 |
@@ -442,7 +442,6 @@ int create_mddev(char *dev, char *name, int autof, int trustworthy,
|
|
|
b7f731 |
*/
|
|
|
b7f731 |
int open_mddev(char *dev, int report_errors)
|
|
|
b7f731 |
{
|
|
|
b7f731 |
- struct mdu_array_info_s array;
|
|
|
b7f731 |
int mdfd = open(dev, O_RDONLY);
|
|
|
b7f731 |
|
|
|
b7f731 |
if (mdfd < 0) {
|
|
|
b7f731 |
@@ -452,7 +451,7 @@ int open_mddev(char *dev, int report_errors)
|
|
|
b7f731 |
return -1;
|
|
|
b7f731 |
}
|
|
|
b7f731 |
|
|
|
b7f731 |
- if (md_get_array_info(mdfd, &array) != 0) {
|
|
|
b7f731 |
+ if (md_array_valid(mdfd) == 0) {
|
|
|
b7f731 |
close(mdfd);
|
|
|
b7f731 |
if (report_errors)
|
|
|
b7f731 |
pr_err("%s does not appear to be an md device\n", dev);
|
|
|
b7f731 |
diff --git a/util.c b/util.c
|
|
|
b7f731 |
index 21a63c9..c7585ac 100644
|
|
|
b7f731 |
--- a/util.c
|
|
|
b7f731 |
+++ b/util.c
|
|
|
b7f731 |
@@ -200,6 +200,30 @@ out:
|
|
|
b7f731 |
return ret;
|
|
|
b7f731 |
}
|
|
|
b7f731 |
|
|
|
b7f731 |
+int md_array_valid(int fd)
|
|
|
b7f731 |
+{
|
|
|
b7f731 |
+ struct mdinfo *sra;
|
|
|
b7f731 |
+ int ret;
|
|
|
b7f731 |
+
|
|
|
b7f731 |
+ sra = sysfs_read(fd, NULL, GET_ARRAY_STATE);
|
|
|
b7f731 |
+ if (sra) {
|
|
|
b7f731 |
+ if (sra->array_state != ARRAY_UNKNOWN_STATE)
|
|
|
b7f731 |
+ ret = 0;
|
|
|
b7f731 |
+ else
|
|
|
b7f731 |
+ ret = -ENODEV;
|
|
|
b7f731 |
+
|
|
|
b7f731 |
+ free(sra);
|
|
|
b7f731 |
+ } else {
|
|
|
b7f731 |
+ /*
|
|
|
b7f731 |
+ * GET_ARRAY_INFO doesn't provide access to the proper state
|
|
|
b7f731 |
+ * information, so fallback to a basic check for raid_disks != 0
|
|
|
b7f731 |
+ */
|
|
|
b7f731 |
+ ret = ioctl(fd, RAID_VERSION);
|
|
|
b7f731 |
+ }
|
|
|
b7f731 |
+
|
|
|
b7f731 |
+ return !ret;
|
|
|
b7f731 |
+}
|
|
|
b7f731 |
+
|
|
|
b7f731 |
int md_array_active(int fd)
|
|
|
b7f731 |
{
|
|
|
b7f731 |
struct mdinfo *sra;
|
|
|
b7f731 |
--
|
|
|
b7f731 |
2.7.4
|
|
|
b7f731 |
|