|
 |
b33395 |
From 679bd9508a30b2a0a1baecc9a21dd6c7d8d8d7dc Mon Sep 17 00:00:00 2001
|
|
|
b33395 |
From: Logan Gunthorpe <logang@deltatee.com>
|
|
|
b33395 |
Date: Wed, 22 Jun 2022 14:25:07 -0600
|
|
|
2ad819 |
Subject: [PATCH 32/83] DDF: Cleanup validate_geometry_ddf_container()
|
|
|
b33395 |
|
|
|
b33395 |
Move the function up so that the function declaration is not necessary
|
|
|
b33395 |
and remove the unused arguments to the function.
|
|
|
b33395 |
|
|
|
b33395 |
No functional changes are intended but will help with a bug fix in the
|
|
|
b33395 |
next patch.
|
|
|
b33395 |
|
|
|
b33395 |
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
|
|
|
b33395 |
Acked-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
|
|
|
b33395 |
Signed-off-by: Jes Sorensen <jes@trained-monkey.org>
|
|
|
b33395 |
---
|
|
|
b33395 |
super-ddf.c | 88 ++++++++++++++++++++++++-----------------------------
|
|
|
b33395 |
1 file changed, 39 insertions(+), 49 deletions(-)
|
|
|
b33395 |
|
|
|
b33395 |
diff --git a/super-ddf.c b/super-ddf.c
|
|
|
b33395 |
index abbc8b09..9d867f69 100644
|
|
|
b33395 |
--- a/super-ddf.c
|
|
|
b33395 |
+++ b/super-ddf.c
|
|
|
b33395 |
@@ -503,13 +503,6 @@ struct ddf_super {
|
|
|
b33395 |
static int load_super_ddf_all(struct supertype *st, int fd,
|
|
|
b33395 |
void **sbp, char *devname);
|
|
|
b33395 |
static int get_svd_state(const struct ddf_super *, const struct vcl *);
|
|
|
b33395 |
-static int
|
|
|
b33395 |
-validate_geometry_ddf_container(struct supertype *st,
|
|
|
b33395 |
- int level, int layout, int raiddisks,
|
|
|
b33395 |
- int chunk, unsigned long long size,
|
|
|
b33395 |
- unsigned long long data_offset,
|
|
|
b33395 |
- char *dev, unsigned long long *freesize,
|
|
|
b33395 |
- int verbose);
|
|
|
b33395 |
|
|
|
b33395 |
static int validate_geometry_ddf_bvd(struct supertype *st,
|
|
|
b33395 |
int level, int layout, int raiddisks,
|
|
|
b33395 |
@@ -3322,6 +3315,42 @@ static int reserve_space(struct supertype *st, int raiddisks,
|
|
|
b33395 |
return 1;
|
|
|
b33395 |
}
|
|
|
b33395 |
|
|
|
b33395 |
+static int
|
|
|
b33395 |
+validate_geometry_ddf_container(struct supertype *st,
|
|
|
b33395 |
+ int level, int raiddisks,
|
|
|
b33395 |
+ unsigned long long data_offset,
|
|
|
b33395 |
+ char *dev, unsigned long long *freesize,
|
|
|
b33395 |
+ int verbose)
|
|
|
b33395 |
+{
|
|
|
b33395 |
+ int fd;
|
|
|
b33395 |
+ unsigned long long ldsize;
|
|
|
b33395 |
+
|
|
|
b33395 |
+ if (level != LEVEL_CONTAINER)
|
|
|
b33395 |
+ return 0;
|
|
|
b33395 |
+ if (!dev)
|
|
|
b33395 |
+ return 1;
|
|
|
b33395 |
+
|
|
|
b33395 |
+ fd = dev_open(dev, O_RDONLY|O_EXCL);
|
|
|
b33395 |
+ if (fd < 0) {
|
|
|
b33395 |
+ if (verbose)
|
|
|
b33395 |
+ pr_err("ddf: Cannot open %s: %s\n",
|
|
|
b33395 |
+ dev, strerror(errno));
|
|
|
b33395 |
+ return 0;
|
|
|
b33395 |
+ }
|
|
|
b33395 |
+ if (!get_dev_size(fd, dev, &ldsize)) {
|
|
|
b33395 |
+ close(fd);
|
|
|
b33395 |
+ return 0;
|
|
|
b33395 |
+ }
|
|
|
b33395 |
+ close(fd);
|
|
|
b33395 |
+ if (freesize) {
|
|
|
b33395 |
+ *freesize = avail_size_ddf(st, ldsize >> 9, INVALID_SECTORS);
|
|
|
b33395 |
+ if (*freesize == 0)
|
|
|
b33395 |
+ return 0;
|
|
|
b33395 |
+ }
|
|
|
b33395 |
+
|
|
|
b33395 |
+ return 1;
|
|
|
b33395 |
+}
|
|
|
b33395 |
+
|
|
|
b33395 |
static int validate_geometry_ddf(struct supertype *st,
|
|
|
b33395 |
int level, int layout, int raiddisks,
|
|
|
b33395 |
int *chunk, unsigned long long size,
|
|
|
b33395 |
@@ -3347,11 +3376,9 @@ static int validate_geometry_ddf(struct supertype *st,
|
|
|
b33395 |
level = LEVEL_CONTAINER;
|
|
|
b33395 |
if (level == LEVEL_CONTAINER) {
|
|
|
b33395 |
/* Must be a fresh device to add to a container */
|
|
|
b33395 |
- return validate_geometry_ddf_container(st, level, layout,
|
|
|
b33395 |
- raiddisks, *chunk,
|
|
|
b33395 |
- size, data_offset, dev,
|
|
|
b33395 |
- freesize,
|
|
|
b33395 |
- verbose);
|
|
|
b33395 |
+ return validate_geometry_ddf_container(st, level, raiddisks,
|
|
|
b33395 |
+ data_offset, dev,
|
|
|
b33395 |
+ freesize, verbose);
|
|
|
b33395 |
}
|
|
|
b33395 |
|
|
|
b33395 |
if (!dev) {
|
|
|
b33395 |
@@ -3449,43 +3476,6 @@ static int validate_geometry_ddf(struct supertype *st,
|
|
|
b33395 |
return 1;
|
|
|
b33395 |
}
|
|
|
b33395 |
|
|
|
b33395 |
-static int
|
|
|
b33395 |
-validate_geometry_ddf_container(struct supertype *st,
|
|
|
b33395 |
- int level, int layout, int raiddisks,
|
|
|
b33395 |
- int chunk, unsigned long long size,
|
|
|
b33395 |
- unsigned long long data_offset,
|
|
|
b33395 |
- char *dev, unsigned long long *freesize,
|
|
|
b33395 |
- int verbose)
|
|
|
b33395 |
-{
|
|
|
b33395 |
- int fd;
|
|
|
b33395 |
- unsigned long long ldsize;
|
|
|
b33395 |
-
|
|
|
b33395 |
- if (level != LEVEL_CONTAINER)
|
|
|
b33395 |
- return 0;
|
|
|
b33395 |
- if (!dev)
|
|
|
b33395 |
- return 1;
|
|
|
b33395 |
-
|
|
|
b33395 |
- fd = dev_open(dev, O_RDONLY|O_EXCL);
|
|
|
b33395 |
- if (fd < 0) {
|
|
|
b33395 |
- if (verbose)
|
|
|
b33395 |
- pr_err("ddf: Cannot open %s: %s\n",
|
|
|
b33395 |
- dev, strerror(errno));
|
|
|
b33395 |
- return 0;
|
|
|
b33395 |
- }
|
|
|
b33395 |
- if (!get_dev_size(fd, dev, &ldsize)) {
|
|
|
b33395 |
- close(fd);
|
|
|
b33395 |
- return 0;
|
|
|
b33395 |
- }
|
|
|
b33395 |
- close(fd);
|
|
|
b33395 |
- if (freesize) {
|
|
|
b33395 |
- *freesize = avail_size_ddf(st, ldsize >> 9, INVALID_SECTORS);
|
|
|
b33395 |
- if (*freesize == 0)
|
|
|
b33395 |
- return 0;
|
|
|
b33395 |
- }
|
|
|
b33395 |
-
|
|
|
b33395 |
- return 1;
|
|
|
b33395 |
-}
|
|
|
b33395 |
-
|
|
|
b33395 |
static int validate_geometry_ddf_bvd(struct supertype *st,
|
|
|
b33395 |
int level, int layout, int raiddisks,
|
|
|
b33395 |
int *chunk, unsigned long long size,
|
|
|
b33395 |
--
|
|
|
2ad819 |
2.38.1
|
|
|
b33395 |
|