|
 |
1f8cff |
These issues were found by Coverity static analysis tool, for more info
|
|
|
1f8cff |
see messages by particular fixes (messages belong to 5.1.61).
|
|
|
1f8cff |
|
|
|
1f8cff |
Filed upstream at http://bugs.mysql.com/bug.php?id=64631
|
|
|
1f8cff |
|
|
|
1f8cff |
|
|
|
1f8cff |
Error: BUFFER_SIZE_WARNING:
|
|
|
1f8cff |
/builddir/build/BUILD/mysql-5.1.61/sql/sql_prepare.cc:2749: buffer_size_warning: Calling strncpy with a maximum size argument of 512 bytes on destination array "this->stmt->last_error" of size 512 bytes might leave the destination string unterminated.
|
|
|
1f8cff |
|
|
|
1f8cff |
|
|
|
1f8cff |
diff -up mariadb-5.5.28a/sql/sql_prepare.cc.p20 mariadb-5.5.28a/sql/sql_prepare.cc
|
|
|
1f8cff |
--- mariadb-5.5.28a/sql/sql_prepare.cc.p20 2012-11-28 16:49:36.000000000 +0100
|
|
|
1f8cff |
+++ mariadb-5.5.28a/sql/sql_prepare.cc 2012-12-17 17:45:24.232151645 +0100
|
|
|
1f8cff |
@@ -2975,7 +2975,7 @@ void mysql_stmt_get_longdata(THD *thd, c
|
|
|
1f8cff |
{
|
|
|
1f8cff |
stmt->state= Query_arena::STMT_ERROR;
|
|
|
1f8cff |
stmt->last_errno= thd->stmt_da->sql_errno();
|
|
|
1f8cff |
- strncpy(stmt->last_error, thd->stmt_da->message(), MYSQL_ERRMSG_SIZE);
|
|
|
1f8cff |
+ strncpy(stmt->last_error, thd->stmt_da->message(), sizeof(stmt->last_error)-1);
|
|
|
1f8cff |
}
|
|
|
1f8cff |
thd->stmt_da= save_stmt_da;
|
|
|
1f8cff |
thd->warning_info= save_warinig_info;
|
|
|
1f8cff |
|
|
|
1f8cff |
|
|
|
1f8cff |
|
|
|
1f8cff |
|
|
|
1f8cff |
Error: STRING_OVERFLOW:
|
|
|
1f8cff |
/builddir/build/BUILD/mysql-5.1.61/storage/innodb_plugin/handler/ha_innodb.cc:6544: fixed_size_dest: You might overrun the 512 byte fixed-size string "name2" by copying "name" without checking the length.
|
|
|
1f8cff |
/builddir/build/BUILD/mysql-5.1.61/storage/innodb_plugin/handler/ha_innodb.cc:6544: parameter_as_source: Note: This defect has an elevated risk because the source argument is a parameter of the current function.
|
|
|
1f8cff |
|
|
|
1f8cff |
diff -up mariadb-5.5.28a/sql/sql_trigger.cc.p20 mariadb-5.5.28a/sql/sql_trigger.cc
|
|
|
1f8cff |
diff -up mariadb-5.5.28a/storage/innobase/handler/ha_innodb.cc.p20 mariadb-5.5.28a/storage/innobase/handler/ha_innodb.cc
|
|
|
1f8cff |
--- mariadb-5.5.28a/storage/innobase/handler/ha_innodb.cc.p20 2012-11-28 16:49:36.000000000 +0100
|
|
|
1f8cff |
+++ mariadb-5.5.28a/storage/innobase/handler/ha_innodb.cc 2012-12-17 17:45:24.239151651 +0100
|
|
|
1f8cff |
@@ -7094,7 +7094,7 @@ ha_innobase::create(
|
|
|
1f8cff |
|
|
|
1f8cff |
ut_a(strlen(name) < sizeof(name2));
|
|
|
1f8cff |
|
|
|
1f8cff |
- strcpy(name2, name);
|
|
|
1f8cff |
+ strncpy(name2, name, sizeof(name2)-1);
|
|
|
1f8cff |
|
|
|
1f8cff |
normalize_table_name(norm_name, name2);
|
|
|
1f8cff |
|