|
 |
580d49 |
From 2bae8ecf04ec2ba6bb9f0af5b80485dd0edb427d Mon Sep 17 00:00:00 2001
|
|
|
580d49 |
From: Florian Weimer <fweimer@redhat.com>
|
|
|
580d49 |
Date: Mon, 17 Nov 2014 12:48:25 +0100
|
|
|
580d49 |
Subject: [PATCH 3/4] fio.c: Unconditionally require wordexp support
|
|
|
580d49 |
|
|
|
580d49 |
---
|
|
|
580d49 |
fio.c | 67 +++++--------------------------------------------------------------
|
|
|
580d49 |
1 file changed, 5 insertions(+), 62 deletions(-)
|
|
|
580d49 |
|
|
|
580d49 |
diff --git a/fio.c b/fio.c
|
|
|
580d49 |
index 65e8f10..1529236 100644
|
|
|
580d49 |
--- a/fio.c
|
|
|
580d49 |
+++ b/fio.c
|
|
|
580d49 |
@@ -43,12 +43,15 @@ static char sccsid[] = "@(#)fio.c 2.76 (gritter) 9/16/09";
|
|
|
580d49 |
#endif /* not lint */
|
|
|
580d49 |
|
|
|
580d49 |
#include "rcv.h"
|
|
|
580d49 |
+
|
|
|
580d49 |
+#ifndef HAVE_WORDEXP
|
|
|
580d49 |
+#error wordexp support is required
|
|
|
580d49 |
+#endif
|
|
|
580d49 |
+
|
|
|
580d49 |
#include <sys/stat.h>
|
|
|
580d49 |
#include <sys/file.h>
|
|
|
580d49 |
#include <sys/wait.h>
|
|
|
580d49 |
-#ifdef HAVE_WORDEXP
|
|
|
580d49 |
#include <wordexp.h>
|
|
|
580d49 |
-#endif /* HAVE_WORDEXP */
|
|
|
580d49 |
#include <unistd.h>
|
|
|
580d49 |
|
|
|
580d49 |
#if defined (USE_NSS)
|
|
|
580d49 |
@@ -481,7 +484,6 @@ next:
|
|
|
580d49 |
static char *
|
|
|
580d49 |
globname(char *name)
|
|
|
580d49 |
{
|
|
|
580d49 |
-#ifdef HAVE_WORDEXP
|
|
|
580d49 |
wordexp_t we;
|
|
|
580d49 |
char *cp;
|
|
|
580d49 |
sigset_t nset;
|
|
|
580d49 |
@@ -527,65 +529,6 @@ globname(char *name)
|
|
|
580d49 |
}
|
|
|
580d49 |
wordfree(&we);
|
|
|
580d49 |
return cp;
|
|
|
580d49 |
-#else /* !HAVE_WORDEXP */
|
|
|
580d49 |
- char xname[PATHSIZE];
|
|
|
580d49 |
- char cmdbuf[PATHSIZE]; /* also used for file names */
|
|
|
580d49 |
- int pid, l;
|
|
|
580d49 |
- char *cp, *shell;
|
|
|
580d49 |
- int pivec[2];
|
|
|
580d49 |
- extern int wait_status;
|
|
|
580d49 |
- struct stat sbuf;
|
|
|
580d49 |
-
|
|
|
580d49 |
- if (pipe(pivec) < 0) {
|
|
|
580d49 |
- perror("pipe");
|
|
|
580d49 |
- return name;
|
|
|
580d49 |
- }
|
|
|
580d49 |
- snprintf(cmdbuf, sizeof cmdbuf, "echo %s", name);
|
|
|
580d49 |
- if ((shell = value("SHELL")) == NULL)
|
|
|
580d49 |
- shell = SHELL;
|
|
|
580d49 |
- pid = start_command(shell, 0, -1, pivec[1], "-c", cmdbuf, NULL);
|
|
|
580d49 |
- if (pid < 0) {
|
|
|
580d49 |
- close(pivec[0]);
|
|
|
580d49 |
- close(pivec[1]);
|
|
|
580d49 |
- return NULL;
|
|
|
580d49 |
- }
|
|
|
580d49 |
- close(pivec[1]);
|
|
|
580d49 |
-again:
|
|
|
580d49 |
- l = read(pivec[0], xname, sizeof xname);
|
|
|
580d49 |
- if (l < 0) {
|
|
|
580d49 |
- if (errno == EINTR)
|
|
|
580d49 |
- goto again;
|
|
|
580d49 |
- perror("read");
|
|
|
580d49 |
- close(pivec[0]);
|
|
|
580d49 |
- return NULL;
|
|
|
580d49 |
- }
|
|
|
580d49 |
- close(pivec[0]);
|
|
|
580d49 |
- if (wait_child(pid) < 0 && WTERMSIG(wait_status) != SIGPIPE) {
|
|
|
580d49 |
- fprintf(stderr, catgets(catd, CATSET, 81,
|
|
|
580d49 |
- "\"%s\": Expansion failed.\n"), name);
|
|
|
580d49 |
- return NULL;
|
|
|
580d49 |
- }
|
|
|
580d49 |
- if (l == 0) {
|
|
|
580d49 |
- fprintf(stderr, catgets(catd, CATSET, 82,
|
|
|
580d49 |
- "\"%s\": No match.\n"), name);
|
|
|
580d49 |
- return NULL;
|
|
|
580d49 |
- }
|
|
|
580d49 |
- if (l == sizeof xname) {
|
|
|
580d49 |
- fprintf(stderr, catgets(catd, CATSET, 83,
|
|
|
580d49 |
- "\"%s\": Expansion buffer overflow.\n"), name);
|
|
|
580d49 |
- return NULL;
|
|
|
580d49 |
- }
|
|
|
580d49 |
- xname[l] = 0;
|
|
|
580d49 |
- for (cp = &xname[l-1]; *cp == '\n' && cp > xname; cp--)
|
|
|
580d49 |
- ;
|
|
|
580d49 |
- cp[1] = '\0';
|
|
|
580d49 |
- if (strchr(xname, ' ') && stat(xname, &sbuf) < 0) {
|
|
|
580d49 |
- fprintf(stderr, catgets(catd, CATSET, 84,
|
|
|
580d49 |
- "\"%s\": Ambiguous.\n"), name);
|
|
|
580d49 |
- return NULL;
|
|
|
580d49 |
- }
|
|
|
580d49 |
- return savestr(xname);
|
|
|
580d49 |
-#endif /* !HAVE_WORDEXP */
|
|
|
580d49 |
}
|
|
|
580d49 |
|
|
|
580d49 |
/*
|
|
|
580d49 |
--
|
|
|
580d49 |
1.9.3
|
|
|
580d49 |
|