From 16a03878cd39cb1fb0c052a41901b6660f9f674c Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Wed, 8 Apr 2020 11:46:42 +0200 Subject: [PATCH 4/4] lvconvert: no validation for thin-pools not used by lvm2 lvm2 supports thin-pool to be later used by other tools doing virtual volumes themself (i.e. docker) - in this case we shall not validate transaction Id - is this is used by other tools and lvm2 keeps value 0 - so the transationId validation need to be skipped in this case. (cherry picked from commit 1316cafbe988307264e4f87dbcffaf56bc2ab388) (cherry picked from commit ca84deb23f0cfb51dbeba0ffe44f757345e6f8a0) --- tools/lvconvert.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 799e746..bf14eec 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -2330,7 +2330,8 @@ static int _lvconvert_thin_pool_repair(struct cmd_context *cmd, goto deactivate_mlv; } - if (thin_dump[0]) { + /* Check matching transactionId when thin-pool is used by lvm2 (transactionId != 0) */ + if (first_seg(pool_lv)->transaction_id && thin_dump[0]) { argv[0] = thin_dump; argv[1] = pms_path; argv[2] = NULL; -- 1.8.3.1