|
 |
f0aa83 |
From f2365e3e82309056c2921016584a56210da6888b Mon Sep 17 00:00:00 2001
|
|
|
f0aa83 |
From: Zdenek Kabelac <zkabelac@redhat.com>
|
|
|
f0aa83 |
Date: Thu, 11 Jan 2018 10:46:04 +0100
|
|
|
f0aa83 |
Subject: [PATCH 19/25] cleanup: enhance messages
|
|
|
f0aa83 |
|
|
|
f0aa83 |
Add extra info about failing local exlusive activation
|
|
|
f0aa83 |
(as in cluster the LV can be active on some other nodes).
|
|
|
f0aa83 |
|
|
|
f0aa83 |
(cherry picked from commit 38b81e6537a8dc497a4bc616a1f51632b43137ca)
|
|
|
f0aa83 |
---
|
|
|
f0aa83 |
lib/locking/locking.c | 3 ++-
|
|
|
f0aa83 |
tools/pvmove.c | 27 ++++++++++++++-------------
|
|
|
f0aa83 |
2 files changed, 16 insertions(+), 14 deletions(-)
|
|
|
f0aa83 |
|
|
|
f0aa83 |
diff --git a/lib/locking/locking.c b/lib/locking/locking.c
|
|
|
f0aa83 |
index c68d4c7..8daa61e 100644
|
|
|
f0aa83 |
--- a/lib/locking/locking.c
|
|
|
f0aa83 |
+++ b/lib/locking/locking.c
|
|
|
f0aa83 |
@@ -406,7 +406,8 @@ int activate_lvs(struct cmd_context *cmd, struct dm_list *lvs)
|
|
|
f0aa83 |
|
|
|
f0aa83 |
dm_list_iterate_items(lvl, lvs) {
|
|
|
f0aa83 |
if (!activate_lv_excl_local(cmd, lvl->lv)) {
|
|
|
f0aa83 |
- log_error("Failed to activate %s", display_lvname(lvl->lv));
|
|
|
f0aa83 |
+ log_error("Failed to locally exclusively activate %s.",
|
|
|
f0aa83 |
+ display_lvname(lvl->lv));
|
|
|
f0aa83 |
dm_list_uniterate(lvh, lvs, &lvl->list) {
|
|
|
f0aa83 |
lvl = dm_list_item(lvh, struct lv_list);
|
|
|
f0aa83 |
if (!deactivate_lv(cmd, lvl->lv))
|
|
|
f0aa83 |
diff --git a/tools/pvmove.c b/tools/pvmove.c
|
|
|
f0aa83 |
index c5d7e52..af3fec4 100644
|
|
|
f0aa83 |
--- a/tools/pvmove.c
|
|
|
f0aa83 |
+++ b/tools/pvmove.c
|
|
|
f0aa83 |
@@ -375,9 +375,9 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
|
|
|
f0aa83 |
continue;
|
|
|
f0aa83 |
|
|
|
f0aa83 |
if (lv_is_converting(lv) || lv_is_merging(lv)) {
|
|
|
f0aa83 |
- log_error("Unable to pvmove when %s volumes are present.",
|
|
|
f0aa83 |
- lv_is_converting(lv) ?
|
|
|
f0aa83 |
- "converting" : "merging");
|
|
|
f0aa83 |
+ log_error("Unable to pvmove when %s volume %s is present.",
|
|
|
f0aa83 |
+ lv_is_converting(lv) ? "converting" : "merging",
|
|
|
f0aa83 |
+ display_lvname(lv));
|
|
|
f0aa83 |
return NULL;
|
|
|
f0aa83 |
}
|
|
|
f0aa83 |
|
|
|
f0aa83 |
@@ -389,13 +389,13 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
|
|
|
f0aa83 |
return_NULL;
|
|
|
f0aa83 |
|
|
|
f0aa83 |
/*
|
|
|
f0aa83 |
- * Remove any PVs holding SubLV siblings to allow
|
|
|
f0aa83 |
- * for collocation (e.g. *rmeta_0 -> *rimage_0).
|
|
|
f0aa83 |
- *
|
|
|
f0aa83 |
- * Callee checks for lv_name and valid raid segment type.
|
|
|
f0aa83 |
- *
|
|
|
f0aa83 |
- * FIXME: don't rely on namespace
|
|
|
f0aa83 |
- */
|
|
|
f0aa83 |
+ * Remove any PVs holding SubLV siblings to allow
|
|
|
f0aa83 |
+ * for collocation (e.g. *rmeta_0 -> *rimage_0).
|
|
|
f0aa83 |
+ *
|
|
|
f0aa83 |
+ * Callee checks for lv_name and valid raid segment type.
|
|
|
f0aa83 |
+ *
|
|
|
f0aa83 |
+ * FIXME: don't rely on namespace
|
|
|
f0aa83 |
+ */
|
|
|
f0aa83 |
if (!_remove_sibling_pvs_from_trim_list(lv, lv_name, &trim_list))
|
|
|
f0aa83 |
return_NULL;
|
|
|
f0aa83 |
|
|
|
f0aa83 |
@@ -436,7 +436,7 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
|
|
|
f0aa83 |
|
|
|
f0aa83 |
if (lv_is_locked(lv)) {
|
|
|
f0aa83 |
lv_skipped = 1;
|
|
|
f0aa83 |
- log_print_unless_silent("Skipping locked LV %s.", lv->name);
|
|
|
f0aa83 |
+ log_print_unless_silent("Skipping locked LV %s.", display_lvname(lv));
|
|
|
f0aa83 |
continue;
|
|
|
f0aa83 |
}
|
|
|
f0aa83 |
|
|
|
f0aa83 |
@@ -445,8 +445,9 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
|
|
|
f0aa83 |
lv_is_active(lv) &&
|
|
|
f0aa83 |
!lv_is_active_exclusive_locally(lv)) {
|
|
|
f0aa83 |
lv_skipped = 1;
|
|
|
f0aa83 |
- log_print_unless_silent("Skipping LV %s which is activated "
|
|
|
f0aa83 |
- "exclusively on remote node.", lv->name);
|
|
|
f0aa83 |
+ log_print_unless_silent("Skipping LV %s which is active, "
|
|
|
f0aa83 |
+ "but not locally exclusively.",
|
|
|
f0aa83 |
+ display_lvname(lv));
|
|
|
f0aa83 |
continue;
|
|
|
f0aa83 |
}
|
|
|
f0aa83 |
|
|
|
f0aa83 |
--
|
|
|
f0aa83 |
1.8.3.1
|
|
|
f0aa83 |
|