|
 |
ab86b0 |
From 7cb63b05dad453d015bbe462b799fb031dd6952c Mon Sep 17 00:00:00 2001
|
|
|
ab86b0 |
From: Zdenek Kabelac <zkabelac@redhat.com>
|
|
|
ab86b0 |
Date: Tue, 31 May 2022 22:48:38 +0200
|
|
|
ab86b0 |
Subject: [PATCH 52/54] vdo: fix conversion of vdo_slab_size_mb
|
|
|
ab86b0 |
|
|
|
ab86b0 |
When converting VDO volume, the parameter vdo_slabSize was
|
|
|
ab86b0 |
incorrectly copied as vdo_blockMapCacheSize, however this parameter
|
|
|
ab86b0 |
is then no longer used for any table line creation so the wrong
|
|
|
ab86b0 |
value was only stored in metadata.
|
|
|
ab86b0 |
|
|
|
ab86b0 |
Also use just single get_kb_size_with_unit_ and remove it's duplicate
|
|
|
ab86b0 |
functionality with get_mb_size_with_unit_.
|
|
|
ab86b0 |
|
|
|
ab86b0 |
Use $VERB for vdo remove call.
|
|
|
ab86b0 |
---
|
|
|
ab86b0 |
scripts/lvm_import_vdo.sh | 13 ++-----------
|
|
|
ab86b0 |
1 file changed, 2 insertions(+), 11 deletions(-)
|
|
|
ab86b0 |
|
|
|
ab86b0 |
diff --git a/scripts/lvm_import_vdo.sh b/scripts/lvm_import_vdo.sh
|
|
|
ab86b0 |
index 61a82e41e..beb55dbdb 100755
|
|
|
ab86b0 |
--- a/scripts/lvm_import_vdo.sh
|
|
|
ab86b0 |
+++ b/scripts/lvm_import_vdo.sh
|
|
|
ab86b0 |
@@ -125,15 +125,6 @@ get_kb_size_with_unit_() {
|
|
|
ab86b0 |
esac
|
|
|
ab86b0 |
}
|
|
|
ab86b0 |
|
|
|
ab86b0 |
-get_mb_size_with_unit_() {
|
|
|
ab86b0 |
- case "$1" in
|
|
|
ab86b0 |
- *[mM]) echo $(( ${1%[mM]} )) ;;
|
|
|
ab86b0 |
- *[gG]) echo $(( ${1%[gG]} * 1024 )) ;;
|
|
|
ab86b0 |
- *[tT]) echo $(( ${1%[tT]} * 1024 * 1024 )) ;;
|
|
|
ab86b0 |
- *[pP]) echo $(( ${1%[pP]} * 1024 * 1024 * 1024 )) ;;
|
|
|
ab86b0 |
- esac
|
|
|
ab86b0 |
-}
|
|
|
ab86b0 |
-
|
|
|
ab86b0 |
# Figure out largest possible extent size usable for VG
|
|
|
ab86b0 |
# $1 physical size
|
|
|
ab86b0 |
# $2 logical size
|
|
|
ab86b0 |
@@ -328,12 +319,12 @@ allocation {
|
|
|
ab86b0 |
vdo_use_deduplication = $(get_enabled_value_ "$vdo_deduplication")
|
|
|
ab86b0 |
vdo_use_metadata_hints=1
|
|
|
ab86b0 |
vdo_minimum_io_size = $vdo_logicalBlockSize
|
|
|
ab86b0 |
- vdo_block_map_cache_size_mb = $(get_mb_size_with_unit_ "$vdo_blockMapCacheSize")
|
|
|
ab86b0 |
+ vdo_block_map_cache_size_mb = $(( $(get_kb_size_with_unit_ "$vdo_blockMapCacheSize") / 1024 ))
|
|
|
ab86b0 |
vdo_block_map_period = $vdo_blockMapPeriod
|
|
|
ab86b0 |
vdo_check_point_frequency = $vdo_indexCfreq
|
|
|
ab86b0 |
vdo_use_sparse_index = $(get_enabled_value_ "$vdo_indexSparse")
|
|
|
ab86b0 |
vdo_index_memory_size_mb = $(awk "BEGIN {print $vdo_indexMemory * 1024}")
|
|
|
ab86b0 |
- vdo_slab_size_mb = $(get_mb_size_with_unit_ "$vdo_blockMapCacheSize")
|
|
|
ab86b0 |
+ vdo_slab_size_mb = $(( $(get_kb_size_with_unit_ "$vdo_blockMapCacheSize") / 1024 ))
|
|
|
ab86b0 |
vdo_ack_threads = $vdo_ackThreads
|
|
|
ab86b0 |
vdo_bio_threads = $vdo_bioThreads
|
|
|
ab86b0 |
vdo_bio_rotation = $vdo_bioRotationInterval
|
|
|
ab86b0 |
--
|
|
|
ab86b0 |
2.34.3
|
|
|
ab86b0 |
|