|
 |
c4524d |
From 926df1e859345dc9e404ebf6d76599cf5b1e9b25 Mon Sep 17 00:00:00 2001
|
|
|
c4524d |
From: Daniel Stone <daniels@collabora.com>
|
|
|
c4524d |
Date: Mon, 30 Oct 2017 11:21:55 +0000
|
|
|
c4524d |
Subject: [PATCH 10/10] Fail expression lookup on invalid atoms
|
|
|
c4524d |
|
|
|
c4524d |
If we fail atom lookup, then we should not claim that we successfully
|
|
|
c4524d |
looked up the expression.
|
|
|
c4524d |
|
|
|
c4524d |
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
c4524d |
(cherry picked from commit bb4909d2d8fa6b08155e449986a478101e2b2634)
|
|
|
c4524d |
---
|
|
|
c4524d |
src/xkbcomp/expr.c | 6 +++++-
|
|
|
c4524d |
1 file changed, 5 insertions(+), 1 deletion(-)
|
|
|
c4524d |
|
|
|
c4524d |
diff --git a/src/xkbcomp/expr.c b/src/xkbcomp/expr.c
|
|
|
c4524d |
index 6640ed0..1b61ae5 100644
|
|
|
c4524d |
--- a/src/xkbcomp/expr.c
|
|
|
c4524d |
+++ b/src/xkbcomp/expr.c
|
|
|
c4524d |
@@ -47,11 +47,15 @@ ExprResolveLhs(struct xkb_context *ctx, const ExprDef *expr,
|
|
|
c4524d |
*elem_rtrn = xkb_atom_text(ctx, expr->field_ref.element);
|
|
|
c4524d |
*field_rtrn = xkb_atom_text(ctx, expr->field_ref.field);
|
|
|
c4524d |
*index_rtrn = NULL;
|
|
|
c4524d |
- return true;
|
|
|
c4524d |
+ return (*elem_rtrn != NULL && *field_rtrn != NULL);
|
|
|
c4524d |
case EXPR_ARRAY_REF:
|
|
|
c4524d |
*elem_rtrn = xkb_atom_text(ctx, expr->array_ref.element);
|
|
|
c4524d |
*field_rtrn = xkb_atom_text(ctx, expr->array_ref.field);
|
|
|
c4524d |
*index_rtrn = expr->array_ref.entry;
|
|
|
c4524d |
+ if (expr->array_ref.element != XKB_ATOM_NONE && *elem_rtrn == NULL)
|
|
|
c4524d |
+ return false;
|
|
|
c4524d |
+ if (*field_rtrn == NULL)
|
|
|
c4524d |
+ return false;
|
|
|
c4524d |
return true;
|
|
|
c4524d |
default:
|
|
|
c4524d |
break;
|
|
|
c4524d |
--
|
|
|
c4524d |
2.20.1
|