From f649b1f8a050402bbd1d28ee78e1522121347977 Mon Sep 17 00:00:00 2001 Message-Id: From: Laine Stump Date: Thu, 14 Feb 2019 15:26:55 -0500 Subject: [PATCH] network: explicitly allow icmp/icmpv6 in libvirt zonefile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The libvirt zonefile for firewalld (added in commit 3b71f2e4) does the following: 1) lists specific services it wants to allow, then 2) uses a lower priority rule to block all other services to the host, and then finally, 3) relies on the zone's default "accept" policy to, accept all forwarded traffic (since forwarded traffic is ignored by the slightly higher priority rule in (2)). I had assumed that icmp traffic was either being allowed at the top of the rules, or that it would be ignored by the rule and passed by the default accept policy (similar to forwarded traffic), but this assumption was incorrect; the rule does block icmp traffic. This became apparent when DHCPv6 which requires ICMPv6 in addition to udp/dhcpv6) failed to work. This all means that in order to achieve our original goal of "similar behavior to a default reject policy, but also allowing forwarded traffic", we need to add rules to allow all icmp and icmpv6 traffic to the libvirt zone, and that's what this patch does. This is a further refinement of the resolution to https://bugzilla.redhat.com/1650320 Signed-off-by: Laine Stump Acked-by: Eric Garver (cherry picked from commit 41adfe8ca932e9fa34cd1b3f238c17b52e6b3888) Message-Id: <20190214202655.22715-1-laine@redhat.com> Reviewed-by: Ján Tomko --- src/network/libvirt.zone | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/network/libvirt.zone b/src/network/libvirt.zone index bf81db1b6e..b1e84b52ec 100644 --- a/src/network/libvirt.zone +++ b/src/network/libvirt.zone @@ -15,6 +15,8 @@ + + -- 2.20.1