|
|
6ae9ed |
From 6aa6dc215b2f7edbd77a302ead90b85ae481d253 Mon Sep 17 00:00:00 2001
|
|
|
6ae9ed |
Message-Id: <6aa6dc215b2f7edbd77a302ead90b85ae481d253@dist-git>
|
|
|
6ae9ed |
From: Erik Skultety <eskultet@redhat.com>
|
|
|
6ae9ed |
Date: Mon, 1 Aug 2016 16:40:53 +0200
|
|
|
6ae9ed |
Subject: [PATCH] virt-admin: Output srv-threadpool-info data as unsigned int
|
|
|
6ae9ed |
rather than signed
|
|
|
6ae9ed |
|
|
|
6ae9ed |
Internally, all the data are represented as unsigned int, it is also documented
|
|
|
6ae9ed |
in the header file that users should use our exported constants that also
|
|
|
6ae9ed |
indicate that the data should be unsigned int. However, when polling for the
|
|
|
6ae9ed |
current server threadpool's configuration, virt-admin uses an incorrect
|
|
|
6ae9ed |
formatting parameter '%d' for printf. Instead, virt-admin should use formatting
|
|
|
6ae9ed |
parameter '%u'.
|
|
|
6ae9ed |
|
|
|
6ae9ed |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1356769
|
|
|
6ae9ed |
|
|
|
6ae9ed |
Signed-off-by: Erik Skultety <eskultet@redhat.com>
|
|
|
6ae9ed |
(cherry picked from commit a8962f705d5b7973e322b81c38e46eb542cb1ad4)
|
|
|
6ae9ed |
Signed-off-by: Erik Skultety <eskultet@redhat.com>
|
|
|
6ae9ed |
---
|
|
|
6ae9ed |
tools/virt-admin.c | 2 +-
|
|
|
6ae9ed |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
6ae9ed |
|
|
|
6ae9ed |
diff --git a/tools/virt-admin.c b/tools/virt-admin.c
|
|
|
6ae9ed |
index c4ee8f5..a59c4c7 100644
|
|
|
6ae9ed |
--- a/tools/virt-admin.c
|
|
|
6ae9ed |
+++ b/tools/virt-admin.c
|
|
|
6ae9ed |
@@ -458,7 +458,7 @@ cmdSrvThreadpoolInfo(vshControl *ctl, const vshCmd *cmd)
|
|
|
6ae9ed |
}
|
|
|
6ae9ed |
|
|
|
6ae9ed |
for (i = 0; i < nparams; i++)
|
|
|
6ae9ed |
- vshPrint(ctl, "%-15s: %d\n", params[i].field, params[i].value.ui);
|
|
|
6ae9ed |
+ vshPrint(ctl, "%-15s: %u\n", params[i].field, params[i].value.ui);
|
|
|
6ae9ed |
|
|
|
6ae9ed |
ret = true;
|
|
|
6ae9ed |
|
|
|
6ae9ed |
--
|
|
|
6ae9ed |
2.9.2
|
|
|
6ae9ed |
|