c313de
From 6a1f3fdcf13ff1fdcbd1f63443a1e5d05b2ddd1c Mon Sep 17 00:00:00 2001
c313de
Message-Id: <6a1f3fdcf13ff1fdcbd1f63443a1e5d05b2ddd1c@dist-git>
c313de
From: Pavel Hrdina <phrdina@redhat.com>
c313de
Date: Mon, 1 Jul 2019 17:07:43 +0200
c313de
Subject: [PATCH] vircgroup: introduce virCgroupV2(Set|Get)MemorySoftLimit
c313de
MIME-Version: 1.0
c313de
Content-Type: text/plain; charset=UTF-8
c313de
Content-Transfer-Encoding: 8bit
c313de
c313de
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
c313de
(cherry picked from commit 94db4bf86ea10e9853f62c4ea079a432482a58df)
c313de
c313de
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
c313de
c313de
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
c313de
Message-Id: <a59c442f9098898c0196a5fb2a0d3527ce277153.1561993100.git.phrdina@redhat.com>
c313de
Reviewed-by: Ján Tomko <jtomko@redhat.com>
c313de
---
c313de
 src/util/vircgroupv2.c | 61 ++++++++++++++++++++++++++++++++++++++++++
c313de
 1 file changed, 61 insertions(+)
c313de
c313de
diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c
c313de
index 81a577d28f..d8a1d7712f 100644
c313de
--- a/src/util/vircgroupv2.c
c313de
+++ b/src/util/vircgroupv2.c
c313de
@@ -1171,6 +1171,65 @@ virCgroupV2GetMemoryHardLimit(virCgroupPtr group,
c313de
 }
c313de
 
c313de
 
c313de
+static int
c313de
+virCgroupV2SetMemorySoftLimit(virCgroupPtr group,
c313de
+                              unsigned long long kb)
c313de
+{
c313de
+    unsigned long long maxkb = VIR_DOMAIN_MEMORY_PARAM_UNLIMITED;
c313de
+
c313de
+    if (kb > maxkb) {
c313de
+        virReportError(VIR_ERR_INVALID_ARG,
c313de
+                       _("Memory '%llu' must be less than %llu"),
c313de
+                       kb, maxkb);
c313de
+        return -1;
c313de
+    }
c313de
+
c313de
+    if (kb == maxkb) {
c313de
+        return virCgroupSetValueStr(group,
c313de
+                                    VIR_CGROUP_CONTROLLER_MEMORY,
c313de
+                                    "memory.high",
c313de
+                                    "max");
c313de
+    } else {
c313de
+        return virCgroupSetValueU64(group,
c313de
+                                    VIR_CGROUP_CONTROLLER_MEMORY,
c313de
+                                    "memory.high",
c313de
+                                    kb << 10);
c313de
+    }
c313de
+}
c313de
+
c313de
+
c313de
+static int
c313de
+virCgroupV2GetMemorySoftLimit(virCgroupPtr group,
c313de
+                              unsigned long long *kb)
c313de
+{
c313de
+    VIR_AUTOFREE(char *) value = NULL;
c313de
+    unsigned long long high;
c313de
+
c313de
+    if (virCgroupGetValueStr(group,
c313de
+                             VIR_CGROUP_CONTROLLER_MEMORY,
c313de
+                             "memory.high", &value) < 0)
c313de
+        return -1;
c313de
+
c313de
+    if (STREQ(value, "max")) {
c313de
+        *kb = VIR_DOMAIN_MEMORY_PARAM_UNLIMITED;
c313de
+        return 0;
c313de
+    }
c313de
+
c313de
+    if (virStrToLong_ull(value, NULL, 10, &high) < 0) {
c313de
+        virReportError(VIR_ERR_INTERNAL_ERROR,
c313de
+                       _("Failed to parse value '%s' as number."),
c313de
+                       value);
c313de
+        return -1;
c313de
+    }
c313de
+
c313de
+    *kb = high >> 10;
c313de
+    if (*kb >= VIR_DOMAIN_MEMORY_PARAM_UNLIMITED)
c313de
+        *kb = VIR_DOMAIN_MEMORY_PARAM_UNLIMITED;
c313de
+
c313de
+    return 0;
c313de
+}
c313de
+
c313de
+
c313de
 virCgroupBackend virCgroupV2Backend = {
c313de
     .type = VIR_CGROUP_BACKEND_TYPE_V2,
c313de
 
c313de
@@ -1213,6 +1272,8 @@ virCgroupBackend virCgroupV2Backend = {
c313de
     .getMemoryUsage = virCgroupV2GetMemoryUsage,
c313de
     .setMemoryHardLimit = virCgroupV2SetMemoryHardLimit,
c313de
     .getMemoryHardLimit = virCgroupV2GetMemoryHardLimit,
c313de
+    .setMemorySoftLimit = virCgroupV2SetMemorySoftLimit,
c313de
+    .getMemorySoftLimit = virCgroupV2GetMemorySoftLimit,
c313de
 };
c313de
 
c313de
 
c313de
-- 
c313de
2.22.0
c313de