c313de
From 784cb29187b72cd44c528b1435b27ca5f0a36f33 Mon Sep 17 00:00:00 2001
c313de
Message-Id: <784cb29187b72cd44c528b1435b27ca5f0a36f33@dist-git>
c313de
From: Pavel Hrdina <phrdina@redhat.com>
c313de
Date: Mon, 1 Jul 2019 17:06:32 +0200
c313de
Subject: [PATCH] vircgroup: extract virCgroupV1HasController
c313de
MIME-Version: 1.0
c313de
Content-Type: text/plain; charset=UTF-8
c313de
Content-Transfer-Encoding: 8bit
c313de
c313de
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
c313de
Reviewed-by: Ján Tomko <jtomko@redhat.com>
c313de
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
c313de
(cherry picked from commit 5e2df3d07f63128259a9677acdbbbcd983069110)
c313de
c313de
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
c313de
c313de
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
c313de
Message-Id: <e823ddab991e14aa8cb5e9b9d139236eb460b594.1561993100.git.phrdina@redhat.com>
c313de
Reviewed-by: Ján Tomko <jtomko@redhat.com>
c313de
---
c313de
 src/util/vircgroup.c        | 3 ++-
c313de
 src/util/vircgroupbackend.h | 5 +++++
c313de
 src/util/vircgroupv1.c      | 9 +++++++++
c313de
 3 files changed, 16 insertions(+), 1 deletion(-)
c313de
c313de
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
c313de
index 2e74cbbff4..5bbe42b699 100644
c313de
--- a/src/util/vircgroup.c
c313de
+++ b/src/util/vircgroup.c
c313de
@@ -1443,7 +1443,8 @@ virCgroupHasController(virCgroupPtr cgroup, int controller)
c313de
         return false;
c313de
     if (controller < 0 || controller >= VIR_CGROUP_CONTROLLER_LAST)
c313de
         return false;
c313de
-    return cgroup->controllers[controller].mountPoint != NULL;
c313de
+
c313de
+    return cgroup->backend->hasController(cgroup, controller);
c313de
 }
c313de
 
c313de
 
c313de
diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h
c313de
index 011d1b00da..29b2fd119f 100644
c313de
--- a/src/util/vircgroupbackend.h
c313de
+++ b/src/util/vircgroupbackend.h
c313de
@@ -73,6 +73,10 @@ typedef int
c313de
 (*virCgroupDetectControllersCB)(virCgroupPtr group,
c313de
                                 int controllers);
c313de
 
c313de
+typedef bool
c313de
+(*virCgroupHasControllerCB)(virCgroupPtr cgroup,
c313de
+                            int controller);
c313de
+
c313de
 struct _virCgroupBackend {
c313de
     virCgroupBackendType type;
c313de
 
c313de
@@ -86,6 +90,7 @@ struct _virCgroupBackend {
c313de
     virCgroupValidatePlacementCB validatePlacement;
c313de
     virCgroupStealPlacementCB stealPlacement;
c313de
     virCgroupDetectControllersCB detectControllers;
c313de
+    virCgroupHasControllerCB hasController;
c313de
 };
c313de
 typedef struct _virCgroupBackend virCgroupBackend;
c313de
 typedef virCgroupBackend *virCgroupBackendPtr;
c313de
diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
c313de
index 11a86c061a..0638f48d50 100644
c313de
--- a/src/util/vircgroupv1.c
c313de
+++ b/src/util/vircgroupv1.c
c313de
@@ -478,6 +478,14 @@ virCgroupV1DetectControllers(virCgroupPtr group,
c313de
 }
c313de
 
c313de
 
c313de
+static bool
c313de
+virCgroupV1HasController(virCgroupPtr group,
c313de
+                         int controller)
c313de
+{
c313de
+    return group->controllers[controller].mountPoint != NULL;
c313de
+}
c313de
+
c313de
+
c313de
 virCgroupBackend virCgroupV1Backend = {
c313de
     .type = VIR_CGROUP_BACKEND_TYPE_V1,
c313de
 
c313de
@@ -490,6 +498,7 @@ virCgroupBackend virCgroupV1Backend = {
c313de
     .validatePlacement = virCgroupV1ValidatePlacement,
c313de
     .stealPlacement = virCgroupV1StealPlacement,
c313de
     .detectControllers = virCgroupV1DetectControllers,
c313de
+    .hasController = virCgroupV1HasController,
c313de
 };
c313de
 
c313de
 
c313de
-- 
c313de
2.22.0
c313de