c313de
From 86865e9638ec63808b1f68e4bd9b4896b5438ece Mon Sep 17 00:00:00 2001
c313de
Message-Id: <86865e9638ec63808b1f68e4bd9b4896b5438ece@dist-git>
c313de
From: Pavel Hrdina <phrdina@redhat.com>
c313de
Date: Mon, 1 Jul 2019 17:06:56 +0200
c313de
Subject: [PATCH] vircgroup: extract virCgroupV1(Set|Get)CpuShares
c313de
MIME-Version: 1.0
c313de
Content-Type: text/plain; charset=UTF-8
c313de
Content-Transfer-Encoding: 8bit
c313de
c313de
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
c313de
Reviewed-by: Ján Tomko <jtomko@redhat.com>
c313de
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
c313de
(cherry picked from commit 857aac1f55bc1c44be4c03c4b721632caedd2a23)
c313de
c313de
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
c313de
c313de
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
c313de
Message-Id: <d43fdbd54cb3c387df54c11d2bd24483c717bd5a.1561993100.git.phrdina@redhat.com>
c313de
Reviewed-by: Ján Tomko <jtomko@redhat.com>
c313de
---
c313de
 src/util/vircgroup.c        |  8 ++------
c313de
 src/util/vircgroupbackend.h | 11 +++++++++++
c313de
 src/util/vircgroupv1.c      | 23 +++++++++++++++++++++++
c313de
 3 files changed, 36 insertions(+), 6 deletions(-)
c313de
c313de
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
c313de
index 67c68f3dc6..953e353ec3 100644
c313de
--- a/src/util/vircgroup.c
c313de
+++ b/src/util/vircgroup.c
c313de
@@ -2205,18 +2205,14 @@ virCgroupGetDomainTotalCpuStats(virCgroupPtr group,
c313de
 int
c313de
 virCgroupSetCpuShares(virCgroupPtr group, unsigned long long shares)
c313de
 {
c313de
-    return virCgroupSetValueU64(group,
c313de
-                                VIR_CGROUP_CONTROLLER_CPU,
c313de
-                                "cpu.shares", shares);
c313de
+    VIR_CGROUP_BACKEND_CALL(group, setCpuShares, -1, shares);
c313de
 }
c313de
 
c313de
 
c313de
 int
c313de
 virCgroupGetCpuShares(virCgroupPtr group, unsigned long long *shares)
c313de
 {
c313de
-    return virCgroupGetValueU64(group,
c313de
-                                VIR_CGROUP_CONTROLLER_CPU,
c313de
-                                "cpu.shares", shares);
c313de
+    VIR_CGROUP_BACKEND_CALL(group, getCpuShares, -1, shares);
c313de
 }
c313de
 
c313de
 
c313de
diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h
c313de
index 436c83f6fa..54fbead8a2 100644
c313de
--- a/src/util/vircgroupbackend.h
c313de
+++ b/src/util/vircgroupbackend.h
c313de
@@ -276,6 +276,14 @@ typedef int
c313de
 typedef int
c313de
 (*virCgroupDenyAllDevicesCB)(virCgroupPtr group);
c313de
 
c313de
+typedef int
c313de
+(*virCgroupSetCpuSharesCB)(virCgroupPtr group,
c313de
+                           unsigned long long shares);
c313de
+
c313de
+typedef int
c313de
+(*virCgroupGetCpuSharesCB)(virCgroupPtr group,
c313de
+                           unsigned long long *shares);
c313de
+
c313de
 struct _virCgroupBackend {
c313de
     virCgroupBackendType type;
c313de
 
c313de
@@ -330,6 +338,9 @@ struct _virCgroupBackend {
c313de
     virCgroupDenyDeviceCB denyDevice;
c313de
     virCgroupAllowAllDevicesCB allowAllDevices;
c313de
     virCgroupDenyAllDevicesCB denyAllDevices;
c313de
+
c313de
+    virCgroupSetCpuSharesCB setCpuShares;
c313de
+    virCgroupGetCpuSharesCB getCpuShares;
c313de
 };
c313de
 typedef struct _virCgroupBackend virCgroupBackend;
c313de
 typedef virCgroupBackend *virCgroupBackendPtr;
c313de
diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
c313de
index 34393812d2..537845bafe 100644
c313de
--- a/src/util/vircgroupv1.c
c313de
+++ b/src/util/vircgroupv1.c
c313de
@@ -1766,6 +1766,26 @@ virCgroupV1DenyAllDevices(virCgroupPtr group)
c313de
 }
c313de
 
c313de
 
c313de
+static int
c313de
+virCgroupV1SetCpuShares(virCgroupPtr group,
c313de
+                        unsigned long long shares)
c313de
+{
c313de
+    return virCgroupSetValueU64(group,
c313de
+                                VIR_CGROUP_CONTROLLER_CPU,
c313de
+                                "cpu.shares", shares);
c313de
+}
c313de
+
c313de
+
c313de
+static int
c313de
+virCgroupV1GetCpuShares(virCgroupPtr group,
c313de
+                        unsigned long long *shares)
c313de
+{
c313de
+    return virCgroupGetValueU64(group,
c313de
+                                VIR_CGROUP_CONTROLLER_CPU,
c313de
+                                "cpu.shares", shares);
c313de
+}
c313de
+
c313de
+
c313de
 virCgroupBackend virCgroupV1Backend = {
c313de
     .type = VIR_CGROUP_BACKEND_TYPE_V1,
c313de
 
c313de
@@ -1818,6 +1838,9 @@ virCgroupBackend virCgroupV1Backend = {
c313de
     .denyDevice = virCgroupV1DenyDevice,
c313de
     .allowAllDevices = virCgroupV1AllowAllDevices,
c313de
     .denyAllDevices = virCgroupV1DenyAllDevices,
c313de
+
c313de
+    .setCpuShares = virCgroupV1SetCpuShares,
c313de
+    .getCpuShares = virCgroupV1GetCpuShares,
c313de
 };
c313de
 
c313de
 
c313de
-- 
c313de
2.22.0
c313de