|
 |
c480ed |
From 9831bda48172881b14f3c473b625ce5ddbd04300 Mon Sep 17 00:00:00 2001
|
|
|
c480ed |
Message-Id: <9831bda48172881b14f3c473b625ce5ddbd04300@dist-git>
|
|
|
c480ed |
From: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c480ed |
Date: Mon, 1 Jul 2019 17:06:08 +0200
|
|
|
c480ed |
Subject: [PATCH] vircgroup: Call virCgroupRemove inside virCgroupMakeGroup
|
|
|
c480ed |
MIME-Version: 1.0
|
|
|
c480ed |
Content-Type: text/plain; charset=UTF-8
|
|
|
c480ed |
Content-Transfer-Encoding: 8bit
|
|
|
c480ed |
|
|
|
c480ed |
This fixes virCgroupEnableMissingControllers where virCgroupRemove
|
|
|
c480ed |
was not called in case virCgroupMakeGroup failed.
|
|
|
c480ed |
|
|
|
c480ed |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c480ed |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c480ed |
(cherry picked from commit b013bdfd797489e6c254917da299842fe051d058)
|
|
|
c480ed |
|
|
|
c480ed |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
|
|
|
c480ed |
|
|
|
c480ed |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c480ed |
Message-Id: <09accbd84f3da1d7c6682357cf6c9a720631a247.1561993099.git.phrdina@redhat.com>
|
|
|
c480ed |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c480ed |
---
|
|
|
c480ed |
src/util/vircgroup.c | 18 +++++++++---------
|
|
|
c480ed |
1 file changed, 9 insertions(+), 9 deletions(-)
|
|
|
c480ed |
|
|
|
c480ed |
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
|
|
|
c480ed |
index 8646a4a479..dde9ed21a2 100644
|
|
|
c480ed |
--- a/src/util/vircgroup.c
|
|
|
c480ed |
+++ b/src/util/vircgroup.c
|
|
|
c480ed |
@@ -1052,7 +1052,7 @@ virCgroupMakeGroup(virCgroupPtr parent,
|
|
|
c480ed |
}
|
|
|
c480ed |
|
|
|
c480ed |
if (virCgroupPathOfController(group, i, "", &path) < 0)
|
|
|
c480ed |
- return -1;
|
|
|
c480ed |
+ goto error;
|
|
|
c480ed |
|
|
|
c480ed |
/* As of Feb 2011, clang can't see that the above function
|
|
|
c480ed |
* call did not modify group. */
|
|
|
c480ed |
@@ -1076,7 +1076,7 @@ virCgroupMakeGroup(virCgroupPtr parent,
|
|
|
c480ed |
virReportSystemError(errno,
|
|
|
c480ed |
_("Failed to create controller %s for group"),
|
|
|
c480ed |
virCgroupControllerTypeToString(i));
|
|
|
c480ed |
- return -1;
|
|
|
c480ed |
+ goto error;
|
|
|
c480ed |
}
|
|
|
c480ed |
}
|
|
|
c480ed |
if (group->controllers[VIR_CGROUP_CONTROLLER_CPUSET].mountPoint != NULL &&
|
|
|
c480ed |
@@ -1084,7 +1084,7 @@ virCgroupMakeGroup(virCgroupPtr parent,
|
|
|
c480ed |
STREQ(group->controllers[i].mountPoint,
|
|
|
c480ed |
group->controllers[VIR_CGROUP_CONTROLLER_CPUSET].mountPoint))) {
|
|
|
c480ed |
if (virCgroupCpuSetInherit(parent, group) < 0)
|
|
|
c480ed |
- return -1;
|
|
|
c480ed |
+ goto error;
|
|
|
c480ed |
}
|
|
|
c480ed |
/*
|
|
|
c480ed |
* Note that virCgroupSetMemoryUseHierarchy should always be
|
|
|
c480ed |
@@ -1096,13 +1096,17 @@ virCgroupMakeGroup(virCgroupPtr parent,
|
|
|
c480ed |
STREQ(group->controllers[i].mountPoint,
|
|
|
c480ed |
group->controllers[VIR_CGROUP_CONTROLLER_MEMORY].mountPoint))) {
|
|
|
c480ed |
if (virCgroupSetMemoryUseHierarchy(group) < 0)
|
|
|
c480ed |
- return -1;
|
|
|
c480ed |
+ goto error;
|
|
|
c480ed |
}
|
|
|
c480ed |
}
|
|
|
c480ed |
}
|
|
|
c480ed |
|
|
|
c480ed |
VIR_DEBUG("Done making controllers for group");
|
|
|
c480ed |
return 0;
|
|
|
c480ed |
+
|
|
|
c480ed |
+ error:
|
|
|
c480ed |
+ virCgroupRemove(group);
|
|
|
c480ed |
+ return -1;
|
|
|
c480ed |
}
|
|
|
c480ed |
|
|
|
c480ed |
|
|
|
c480ed |
@@ -1316,10 +1320,8 @@ virCgroupNewPartition(const char *path,
|
|
|
c480ed |
if (virCgroupNew(-1, parentPath, NULL, controllers, &parent) < 0)
|
|
|
c480ed |
goto cleanup;
|
|
|
c480ed |
|
|
|
c480ed |
- if (virCgroupMakeGroup(parent, *group, create, VIR_CGROUP_NONE) < 0) {
|
|
|
c480ed |
- virCgroupRemove(*group);
|
|
|
c480ed |
+ if (virCgroupMakeGroup(parent, *group, create, VIR_CGROUP_NONE) < 0)
|
|
|
c480ed |
goto cleanup;
|
|
|
c480ed |
- }
|
|
|
c480ed |
}
|
|
|
c480ed |
|
|
|
c480ed |
ret = 0;
|
|
|
c480ed |
@@ -1389,7 +1391,6 @@ virCgroupNewDomainPartition(virCgroupPtr partition,
|
|
|
c480ed |
*/
|
|
|
c480ed |
if (virCgroupMakeGroup(partition, *group, create,
|
|
|
c480ed |
VIR_CGROUP_MEM_HIERACHY) < 0) {
|
|
|
c480ed |
- virCgroupRemove(*group);
|
|
|
c480ed |
virCgroupFree(group);
|
|
|
c480ed |
return -1;
|
|
|
c480ed |
}
|
|
|
c480ed |
@@ -1446,7 +1447,6 @@ virCgroupNewThread(virCgroupPtr domain,
|
|
|
c480ed |
return -1;
|
|
|
c480ed |
|
|
|
c480ed |
if (virCgroupMakeGroup(domain, *group, create, VIR_CGROUP_NONE) < 0) {
|
|
|
c480ed |
- virCgroupRemove(*group);
|
|
|
c480ed |
virCgroupFree(group);
|
|
|
c480ed |
return -1;
|
|
|
c480ed |
}
|
|
|
c480ed |
--
|
|
|
c480ed |
2.22.0
|
|
|
c480ed |
|