79b470
From 15b1f63574db2100d433d283a975928f83bb0ecb Mon Sep 17 00:00:00 2001
79b470
Message-Id: <15b1f63574db2100d433d283a975928f83bb0ecb@dist-git>
79b470
From: Laine Stump <laine@redhat.com>
79b470
Date: Fri, 15 Jan 2021 22:51:44 -0500
79b470
Subject: [PATCH] util: fix typo in VIR_MOCK_WRAP_RET_ARGS()
79b470
79b470
When virfirewalltest.c was first written in commit 3a0ca7de51 (March
79b470
2013), a conditional accidentally tested for "ipv4" instead of
79b470
"ipv6". Since the file ended up only testing ipv4 rules, this has
79b470
never made any difference in practice, but I'm making some other
79b470
changes in this file and just couldn't let it stand :-)
79b470
79b470
https://bugzilla.redhat.com/1607929
79b470
79b470
Signed-off-by: Laine Stump <laine@redhat.com>
79b470
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
79b470
(cherry picked from commit 28a3deddddfe102b37f2e373bf4581c2ce8d2050)
79b470
Message-Id: <20210116035151.1066734-2-laine@redhat.com>
79b470
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
79b470
---
79b470
 tests/virfirewalltest.c | 2 +-
79b470
 1 file changed, 1 insertion(+), 1 deletion(-)
79b470
79b470
diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c
79b470
index c4827918c3..8aba127610 100644
79b470
--- a/tests/virfirewalltest.c
79b470
+++ b/tests/virfirewalltest.c
79b470
@@ -129,7 +129,7 @@ VIR_MOCK_WRAP_RET_ARGS(dbus_connection_send_with_reply_and_block,
79b470
         if (fwBuf) {
79b470
             if (STREQ(type, "ipv4"))
79b470
                 virBufferAddLit(fwBuf, IPTABLES_PATH);
79b470
-            else if (STREQ(type, "ipv4"))
79b470
+            else if (STREQ(type, "ipv6"))
79b470
                 virBufferAddLit(fwBuf, IP6TABLES_PATH);
79b470
             else
79b470
                 virBufferAddLit(fwBuf, EBTABLES_PATH);
79b470
-- 
79b470
2.30.0
79b470