|
 |
397dc2 |
From 15b1f63574db2100d433d283a975928f83bb0ecb Mon Sep 17 00:00:00 2001
|
|
|
397dc2 |
Message-Id: <15b1f63574db2100d433d283a975928f83bb0ecb@dist-git>
|
|
|
397dc2 |
From: Laine Stump <laine@redhat.com>
|
|
|
397dc2 |
Date: Fri, 15 Jan 2021 22:51:44 -0500
|
|
|
397dc2 |
Subject: [PATCH] util: fix typo in VIR_MOCK_WRAP_RET_ARGS()
|
|
|
397dc2 |
|
|
|
397dc2 |
When virfirewalltest.c was first written in commit 3a0ca7de51 (March
|
|
|
397dc2 |
2013), a conditional accidentally tested for "ipv4" instead of
|
|
|
397dc2 |
"ipv6". Since the file ended up only testing ipv4 rules, this has
|
|
|
397dc2 |
never made any difference in practice, but I'm making some other
|
|
|
397dc2 |
changes in this file and just couldn't let it stand :-)
|
|
|
397dc2 |
|
|
|
397dc2 |
https://bugzilla.redhat.com/1607929
|
|
|
397dc2 |
|
|
|
397dc2 |
Signed-off-by: Laine Stump <laine@redhat.com>
|
|
|
397dc2 |
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
|
|
|
397dc2 |
(cherry picked from commit 28a3deddddfe102b37f2e373bf4581c2ce8d2050)
|
|
|
397dc2 |
Message-Id: <20210116035151.1066734-2-laine@redhat.com>
|
|
|
397dc2 |
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
397dc2 |
---
|
|
|
397dc2 |
tests/virfirewalltest.c | 2 +-
|
|
|
397dc2 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
397dc2 |
|
|
|
397dc2 |
diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c
|
|
|
397dc2 |
index c4827918c3..8aba127610 100644
|
|
|
397dc2 |
--- a/tests/virfirewalltest.c
|
|
|
397dc2 |
+++ b/tests/virfirewalltest.c
|
|
|
397dc2 |
@@ -129,7 +129,7 @@ VIR_MOCK_WRAP_RET_ARGS(dbus_connection_send_with_reply_and_block,
|
|
|
397dc2 |
if (fwBuf) {
|
|
|
397dc2 |
if (STREQ(type, "ipv4"))
|
|
|
397dc2 |
virBufferAddLit(fwBuf, IPTABLES_PATH);
|
|
|
397dc2 |
- else if (STREQ(type, "ipv4"))
|
|
|
397dc2 |
+ else if (STREQ(type, "ipv6"))
|
|
|
397dc2 |
virBufferAddLit(fwBuf, IP6TABLES_PATH);
|
|
|
397dc2 |
else
|
|
|
397dc2 |
virBufferAddLit(fwBuf, EBTABLES_PATH);
|
|
|
397dc2 |
--
|
|
|
397dc2 |
2.30.0
|
|
|
397dc2 |
|