99cbc7
From 7ccf7cf1bb0a2d1783bb98f5fd5aa99738aa912a Mon Sep 17 00:00:00 2001
99cbc7
Message-Id: <7ccf7cf1bb0a2d1783bb98f5fd5aa99738aa912a@dist-git>
99cbc7
From: Pavel Hrdina <phrdina@redhat.com>
99cbc7
Date: Mon, 13 Aug 2018 18:16:10 +0200
99cbc7
Subject: [PATCH] tests: rename hugepages-pages2 into hugepages-numa-default-2M
99cbc7
MIME-Version: 1.0
99cbc7
Content-Type: text/plain; charset=UTF-8
99cbc7
Content-Transfer-Encoding: 8bit
99cbc7
99cbc7
Remove unnecessary XML elements as well.
99cbc7
99cbc7
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
99cbc7
(cherry picked from commit 1abcfa5c17b4ea26f75b2b37281d4990eb6be20f)
99cbc7
99cbc7
Conflicts:
99cbc7
    tests/qemuxml2argvdata/hugepages-numa-default-2M.args
99cbc7
        - missing upstream commit <caccbba64a>
99cbc7
99cbc7
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591235
99cbc7
99cbc7
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
99cbc7
Reviewed-by: Ján Tomko <jtomko@redhat.com>
99cbc7
---
99cbc7
 ...s-pages2.args => hugepages-numa-default-2M.args} |  5 +----
99cbc7
 ...ges-pages2.xml => hugepages-numa-default-2M.xml} |  8 +-------
99cbc7
 tests/qemuxml2argvtest.c                            |  5 +++--
99cbc7
 ...ges-pages2.xml => hugepages-numa-default-2M.xml} | 13 +------------
99cbc7
 tests/qemuxml2xmltest.c                             |  2 +-
99cbc7
 5 files changed, 7 insertions(+), 26 deletions(-)
99cbc7
 rename tests/qemuxml2argvdata/{hugepages-pages2.args => hugepages-numa-default-2M.args} (77%)
99cbc7
 rename tests/qemuxml2argvdata/{hugepages-pages2.xml => hugepages-numa-default-2M.xml} (77%)
99cbc7
 rename tests/qemuxml2xmloutdata/{hugepages-pages2.xml => hugepages-numa-default-2M.xml} (67%)
99cbc7
99cbc7
diff --git a/tests/qemuxml2argvdata/hugepages-pages2.args b/tests/qemuxml2argvdata/hugepages-numa-default-2M.args
99cbc7
similarity index 77%
99cbc7
rename from tests/qemuxml2argvdata/hugepages-pages2.args
99cbc7
rename to tests/qemuxml2argvdata/hugepages-numa-default-2M.args
99cbc7
index 21105ef844..2dfacefe4a 100644
99cbc7
--- a/tests/qemuxml2argvdata/hugepages-pages2.args
99cbc7
+++ b/tests/qemuxml2argvdata/hugepages-numa-default-2M.args
99cbc7
@@ -25,7 +25,4 @@ path=/tmp/lib/domain--1-SomeDummyHugepagesGu/monitor.sock,server,nowait \
99cbc7
 -no-shutdown \
99cbc7
 -no-acpi \
99cbc7
 -boot c \
99cbc7
--usb \
99cbc7
--drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \
99cbc7
--device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
99cbc7
--device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3
99cbc7
+-usb
99cbc7
diff --git a/tests/qemuxml2argvdata/hugepages-pages2.xml b/tests/qemuxml2argvdata/hugepages-numa-default-2M.xml
99cbc7
similarity index 77%
99cbc7
rename from tests/qemuxml2argvdata/hugepages-pages2.xml
99cbc7
rename to tests/qemuxml2argvdata/hugepages-numa-default-2M.xml
99cbc7
index 3b2d72ef3c..357c77da2a 100644
99cbc7
--- a/tests/qemuxml2argvdata/hugepages-pages2.xml
99cbc7
+++ b/tests/qemuxml2argvdata/hugepages-numa-default-2M.xml
99cbc7
@@ -25,16 +25,10 @@
99cbc7
   <on_crash>destroy</on_crash>
99cbc7
   <devices>
99cbc7
     <emulator>/usr/bin/qemu-system-i686</emulator>
99cbc7
-    <disk type='block' device='disk'>
99cbc7
-      <source dev='/dev/HostVG/QEMUGuest1'/>
99cbc7
-      <target dev='hda' bus='ide'/>
99cbc7
-      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
99cbc7
-    </disk>
99cbc7
     <controller type='usb' index='0'/>
99cbc7
-    <controller type='ide' index='0'/>
99cbc7
     <controller type='pci' index='0' model='pci-root'/>
99cbc7
     <input type='mouse' bus='ps2'/>
99cbc7
     <input type='keyboard' bus='ps2'/>
99cbc7
-    <memballoon model='virtio'/>
99cbc7
+    <memballoon model='none'/>
99cbc7
   </devices>
99cbc7
 </domain>
99cbc7
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
99cbc7
index 3bb5efbd8d..6a79918f67 100644
99cbc7
--- a/tests/qemuxml2argvtest.c
99cbc7
+++ b/tests/qemuxml2argvtest.c
99cbc7
@@ -951,14 +951,15 @@ mymain(void)
99cbc7
     DO_TEST("hugepages-default", NONE);
99cbc7
     DO_TEST("hugepages-numa-default",
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
+    DO_TEST("hugepages-numa-default-2M",
99cbc7
+            QEMU_CAPS_OBJECT_MEMORY_RAM,
99cbc7
+            QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
     DO_TEST("hugepages-numa-default-dimm",
99cbc7
             QEMU_CAPS_DEVICE_PC_DIMM,
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
     DO_TEST("hugepages-numa-nodeset",
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_RAM,
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
-    DO_TEST("hugepages-pages2", QEMU_CAPS_OBJECT_MEMORY_RAM,
99cbc7
-            QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
     DO_TEST("hugepages-pages3", QEMU_CAPS_OBJECT_MEMORY_RAM,
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_FILE,
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD);
99cbc7
diff --git a/tests/qemuxml2xmloutdata/hugepages-pages2.xml b/tests/qemuxml2xmloutdata/hugepages-numa-default-2M.xml
99cbc7
similarity index 67%
99cbc7
rename from tests/qemuxml2xmloutdata/hugepages-pages2.xml
99cbc7
rename to tests/qemuxml2xmloutdata/hugepages-numa-default-2M.xml
99cbc7
index cd79960f1b..3777824e1a 100644
99cbc7
--- a/tests/qemuxml2xmloutdata/hugepages-pages2.xml
99cbc7
+++ b/tests/qemuxml2xmloutdata/hugepages-numa-default-2M.xml
99cbc7
@@ -25,23 +25,12 @@
99cbc7
   <on_crash>destroy</on_crash>
99cbc7
   <devices>
99cbc7
     <emulator>/usr/bin/qemu-system-i686</emulator>
99cbc7
-    <disk type='block' device='disk'>
99cbc7
-      <driver name='qemu' type='raw'/>
99cbc7
-      <source dev='/dev/HostVG/QEMUGuest1'/>
99cbc7
-      <target dev='hda' bus='ide'/>
99cbc7
-      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
99cbc7
-    </disk>
99cbc7
     <controller type='usb' index='0'>
99cbc7
       <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
99cbc7
     </controller>
99cbc7
-    <controller type='ide' index='0'>
99cbc7
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
99cbc7
-    </controller>
99cbc7
     <controller type='pci' index='0' model='pci-root'/>
99cbc7
     <input type='mouse' bus='ps2'/>
99cbc7
     <input type='keyboard' bus='ps2'/>
99cbc7
-    <memballoon model='virtio'>
99cbc7
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
99cbc7
-    </memballoon>
99cbc7
+    <memballoon model='none'/>
99cbc7
   </devices>
99cbc7
 </domain>
99cbc7
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
99cbc7
index 2c3d16495e..a4448ff168 100644
99cbc7
--- a/tests/qemuxml2xmltest.c
99cbc7
+++ b/tests/qemuxml2xmltest.c
99cbc7
@@ -332,9 +332,9 @@ mymain(void)
99cbc7
 
99cbc7
     DO_TEST("pages-discard", NONE);
99cbc7
     DO_TEST("hugepages-default", NONE);
99cbc7
+    DO_TEST("hugepages-numa-default-2M", NONE);
99cbc7
     DO_TEST("hugepages-numa-default-dimm", NONE);
99cbc7
     DO_TEST("hugepages-numa-nodeset", NONE);
99cbc7
-    DO_TEST("hugepages-pages2", NONE);
99cbc7
     DO_TEST("hugepages-pages3", NONE);
99cbc7
     DO_TEST("hugepages-pages4", NONE);
99cbc7
     DO_TEST("hugepages-pages5", NONE);
99cbc7
-- 
99cbc7
2.18.0
99cbc7