|
 |
9c6c51 |
From 0f5bad99762f92f7b7a0e65e68fbb83bad787a4a Mon Sep 17 00:00:00 2001
|
|
|
9c6c51 |
Message-Id: <0f5bad99762f92f7b7a0e65e68fbb83bad787a4a@dist-git>
|
|
|
9c6c51 |
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
|
|
|
9c6c51 |
Date: Tue, 28 Aug 2018 12:46:44 +0200
|
|
|
9c6c51 |
Subject: [PATCH] tests: qemu: test more versions for graphics-vnc-tls
|
|
|
9c6c51 |
MIME-Version: 1.0
|
|
|
9c6c51 |
Content-Type: text/plain; charset=UTF-8
|
|
|
9c6c51 |
Content-Transfer-Encoding: 8bit
|
|
|
9c6c51 |
|
|
|
9c6c51 |
Add a test with QEMU 2.4.0 capabilites, as well as the latest caps.
|
|
|
9c6c51 |
|
|
|
9c6c51 |
The code paths for formatting TLS options will be altered and
|
|
|
9c6c51 |
2.4.0 is the newest version where QEMU_CAPS_OBJECT_TLS_CREDS_X509
|
|
|
9c6c51 |
is not supported.
|
|
|
9c6c51 |
|
|
|
9c6c51 |
Signed-off-by: Ján Tomko <jtomko@redhat.com>
|
|
|
9c6c51 |
(cherry picked from commit 11b5396ceabe2ca91d8110f172f3ccf0d3901111)
|
|
|
9c6c51 |
Signed-off-by: Ján Tomko <jtomko@redhat.com>
|
|
|
9c6c51 |
|
|
|
9c6c51 |
https: //bugzilla.redhat.com/show_bug.cgi?id=1598167
|
|
|
9c6c51 |
Reviewed-by: Erik Skultety <eskultet@redhat.com>
|
|
|
9c6c51 |
---
|
|
|
9c6c51 |
.../graphics-vnc-tls.x86_64-2.4.0.args | 28 +++++++++++++++++
|
|
|
9c6c51 |
.../graphics-vnc-tls.x86_64-latest.args | 31 +++++++++++++++++++
|
|
|
9c6c51 |
tests/qemuxml2argvtest.c | 2 ++
|
|
|
9c6c51 |
3 files changed, 61 insertions(+)
|
|
|
9c6c51 |
create mode 100644 tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-2.4.0.args
|
|
|
9c6c51 |
create mode 100644 tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-latest.args
|
|
|
9c6c51 |
|
|
|
9c6c51 |
diff --git a/tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-2.4.0.args b/tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-2.4.0.args
|
|
|
9c6c51 |
new file mode 100644
|
|
|
9c6c51 |
index 0000000000..7b8e3a4aa6
|
|
|
9c6c51 |
--- /dev/null
|
|
|
9c6c51 |
+++ b/tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-2.4.0.args
|
|
|
9c6c51 |
@@ -0,0 +1,28 @@
|
|
|
9c6c51 |
+LC_ALL=C \
|
|
|
9c6c51 |
+PATH=/bin \
|
|
|
9c6c51 |
+HOME=/home/test \
|
|
|
9c6c51 |
+USER=test \
|
|
|
9c6c51 |
+LOGNAME=test \
|
|
|
9c6c51 |
+SASL_CONF_PATH=/root/.sasl2 \
|
|
|
9c6c51 |
+QEMU_AUDIO_DRV=none \
|
|
|
9c6c51 |
+/usr/bin/qemu-system-i686 \
|
|
|
9c6c51 |
+-name guest=QEMUGuest1,debug-threads=on \
|
|
|
9c6c51 |
+-S \
|
|
|
9c6c51 |
+-machine pc-i440fx-2.4,accel=tcg,usb=off,dump-guest-core=off \
|
|
|
9c6c51 |
+-m 214 \
|
|
|
9c6c51 |
+-realtime mlock=off \
|
|
|
9c6c51 |
+-smp 1,sockets=1,cores=1,threads=1 \
|
|
|
9c6c51 |
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
|
|
|
9c6c51 |
+-no-user-config \
|
|
|
9c6c51 |
+-nodefaults \
|
|
|
9c6c51 |
+-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\
|
|
|
9c6c51 |
+server,nowait \
|
|
|
9c6c51 |
+-mon chardev=charmonitor,id=monitor,mode=control \
|
|
|
9c6c51 |
+-rtc base=utc \
|
|
|
9c6c51 |
+-no-shutdown \
|
|
|
9c6c51 |
+-no-acpi \
|
|
|
9c6c51 |
+-boot strict=on \
|
|
|
9c6c51 |
+-device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \
|
|
|
9c6c51 |
+-vnc 127.0.0.1:3,tls,x509verify=/etc/pki/libvirt-vnc,sasl \
|
|
|
9c6c51 |
+-device cirrus-vga,id=video0,bus=pci.0,addr=0x2 \
|
|
|
9c6c51 |
+-msg timestamp=on
|
|
|
9c6c51 |
diff --git a/tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-latest.args b/tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-latest.args
|
|
|
9c6c51 |
new file mode 100644
|
|
|
9c6c51 |
index 0000000000..01743eff2a
|
|
|
9c6c51 |
--- /dev/null
|
|
|
9c6c51 |
+++ b/tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-latest.args
|
|
|
9c6c51 |
@@ -0,0 +1,31 @@
|
|
|
9c6c51 |
+LC_ALL=C \
|
|
|
9c6c51 |
+PATH=/bin \
|
|
|
9c6c51 |
+HOME=/home/test \
|
|
|
9c6c51 |
+USER=test \
|
|
|
9c6c51 |
+LOGNAME=test \
|
|
|
9c6c51 |
+SASL_CONF_PATH=/root/.sasl2 \
|
|
|
9c6c51 |
+QEMU_AUDIO_DRV=none \
|
|
|
9c6c51 |
+/usr/bin/qemu-system-i686 \
|
|
|
9c6c51 |
+-name guest=QEMUGuest1,debug-threads=on \
|
|
|
9c6c51 |
+-S \
|
|
|
9c6c51 |
+-object secret,id=masterKey0,format=raw,\
|
|
|
9c6c51 |
+file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
|
|
|
9c6c51 |
+-machine pc,accel=tcg,usb=off,dump-guest-core=off \
|
|
|
9c6c51 |
+-m 214 \
|
|
|
9c6c51 |
+-realtime mlock=off \
|
|
|
9c6c51 |
+-smp 1,sockets=1,cores=1,threads=1 \
|
|
|
9c6c51 |
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
|
|
|
9c6c51 |
+-no-user-config \
|
|
|
9c6c51 |
+-nodefaults \
|
|
|
9c6c51 |
+-chardev socket,id=charmonitor,fd=1729,server,nowait \
|
|
|
9c6c51 |
+-mon chardev=charmonitor,id=monitor,mode=control \
|
|
|
9c6c51 |
+-rtc base=utc \
|
|
|
9c6c51 |
+-no-shutdown \
|
|
|
9c6c51 |
+-no-acpi \
|
|
|
9c6c51 |
+-boot strict=on \
|
|
|
9c6c51 |
+-device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \
|
|
|
9c6c51 |
+-vnc 127.0.0.1:3,tls,x509verify=/etc/pki/libvirt-vnc,sasl \
|
|
|
9c6c51 |
+-device cirrus-vga,id=video0,bus=pci.0,addr=0x2 \
|
|
|
9c6c51 |
+-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,\
|
|
|
9c6c51 |
+resourcecontrol=deny \
|
|
|
9c6c51 |
+-msg timestamp=on
|
|
|
9c6c51 |
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
|
|
|
9c6c51 |
index 02bb9889ee..608a2b6ce3 100644
|
|
|
9c6c51 |
--- a/tests/qemuxml2argvtest.c
|
|
|
9c6c51 |
+++ b/tests/qemuxml2argvtest.c
|
|
|
9c6c51 |
@@ -1207,6 +1207,8 @@ mymain(void)
|
|
|
9c6c51 |
driver.config->vncTLS = 1;
|
|
|
9c6c51 |
driver.config->vncTLSx509verify = 1;
|
|
|
9c6c51 |
DO_TEST("graphics-vnc-tls", QEMU_CAPS_VNC, QEMU_CAPS_DEVICE_CIRRUS_VGA);
|
|
|
9c6c51 |
+ DO_TEST_CAPS_VER("graphics-vnc-tls", "2.4.0");
|
|
|
9c6c51 |
+ DO_TEST_CAPS_LATEST("graphics-vnc-tls");
|
|
|
9c6c51 |
driver.config->vncSASL = driver.config->vncTLSx509verify = driver.config->vncTLS = 0;
|
|
|
9c6c51 |
VIR_FREE(driver.config->vncSASLdir);
|
|
|
9c6c51 |
VIR_FREE(driver.config->vncTLSx509certdir);
|
|
|
9c6c51 |
--
|
|
|
9c6c51 |
2.18.0
|
|
|
9c6c51 |
|