404507
From d41c109a5c9a6224201acdd0efde034776cfa49e Mon Sep 17 00:00:00 2001
404507
Message-Id: <d41c109a5c9a6224201acdd0efde034776cfa49e@dist-git>
404507
From: Martin Kletzander <mkletzan@redhat.com>
404507
Date: Fri, 2 Feb 2018 15:21:28 +0100
404507
Subject: [PATCH] tests: Add test for properly removing cachetune entries
404507
404507
Cachetune for unavailable vCPUs should be cleared the same way vcpupin and other
404507
things do, so let's add tests for it.
404507
404507
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
404507
(cherry picked from commit 958e0431a93b5d330dcc3fa5984a85e5c789eead)
404507
404507
https://bugzilla.redhat.com/show_bug.cgi?id=1540817
404507
404507
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
404507
---
404507
 .../generic-cachetune-extra-tunes.xml              | 33 ++++++++++++++++++++++
404507
 .../generic-cachetune-extra-tunes.xml              | 30 ++++++++++++++++++++
404507
 tests/genericxml2xmltest.c                         |  1 +
404507
 3 files changed, 64 insertions(+)
404507
 create mode 100644 tests/genericxml2xmlindata/generic-cachetune-extra-tunes.xml
404507
 create mode 100644 tests/genericxml2xmloutdata/generic-cachetune-extra-tunes.xml
404507
404507
diff --git a/tests/genericxml2xmlindata/generic-cachetune-extra-tunes.xml b/tests/genericxml2xmlindata/generic-cachetune-extra-tunes.xml
404507
new file mode 100644
404507
index 0000000000..d3b01a8ecd
404507
--- /dev/null
404507
+++ b/tests/genericxml2xmlindata/generic-cachetune-extra-tunes.xml
404507
@@ -0,0 +1,33 @@
404507
+<domain type='qemu'>
404507
+  <name>QEMUGuest1</name>
404507
+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
404507
+  <memory unit='KiB'>219136</memory>
404507
+  <currentMemory unit='KiB'>219136</currentMemory>
404507
+  <vcpu placement='static'>2</vcpu>
404507
+  <cputune>
404507
+    <cachetune vcpus='0-3'>
404507
+      <cache id='0' level='3' type='code' size='7680' unit='KiB'/>
404507
+      <cache id='1' level='3' type='data' size='3840' unit='KiB'/>
404507
+    </cachetune>
404507
+    <cachetune vcpus='100'>
404507
+      <cache id='1' level='3' type='code' size='6' unit='MiB'/>
404507
+    </cachetune>
404507
+  </cputune>
404507
+  <os>
404507
+    <type arch='i686' machine='pc'>hvm</type>
404507
+    <boot dev='hd'/>
404507
+  </os>
404507
+  <clock offset='utc'/>
404507
+  <on_poweroff>destroy</on_poweroff>
404507
+  <on_reboot>restart</on_reboot>
404507
+  <on_crash>destroy</on_crash>
404507
+  <devices>
404507
+    <emulator>/usr/bin/qemu-system-i686</emulator>
404507
+    <controller type='usb' index='0'/>
404507
+    <controller type='ide' index='0'/>
404507
+    <controller type='pci' index='0' model='pci-root'/>
404507
+    <input type='mouse' bus='ps2'/>
404507
+    <input type='keyboard' bus='ps2'/>
404507
+    <memballoon model='virtio'/>
404507
+  </devices>
404507
+</domain>
404507
diff --git a/tests/genericxml2xmloutdata/generic-cachetune-extra-tunes.xml b/tests/genericxml2xmloutdata/generic-cachetune-extra-tunes.xml
404507
new file mode 100644
404507
index 0000000000..db85af08da
404507
--- /dev/null
404507
+++ b/tests/genericxml2xmloutdata/generic-cachetune-extra-tunes.xml
404507
@@ -0,0 +1,30 @@
404507
+<domain type='qemu'>
404507
+  <name>QEMUGuest1</name>
404507
+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
404507
+  <memory unit='KiB'>219136</memory>
404507
+  <currentMemory unit='KiB'>219136</currentMemory>
404507
+  <vcpu placement='static'>2</vcpu>
404507
+  <cputune>
404507
+    <cachetune vcpus='0-1'>
404507
+      <cache id='0' level='3' type='code' size='7680' unit='KiB'/>
404507
+      <cache id='1' level='3' type='data' size='3840' unit='KiB'/>
404507
+    </cachetune>
404507
+  </cputune>
404507
+  <os>
404507
+    <type arch='i686' machine='pc'>hvm</type>
404507
+    <boot dev='hd'/>
404507
+  </os>
404507
+  <clock offset='utc'/>
404507
+  <on_poweroff>destroy</on_poweroff>
404507
+  <on_reboot>restart</on_reboot>
404507
+  <on_crash>destroy</on_crash>
404507
+  <devices>
404507
+    <emulator>/usr/bin/qemu-system-i686</emulator>
404507
+    <controller type='usb' index='0'/>
404507
+    <controller type='ide' index='0'/>
404507
+    <controller type='pci' index='0' model='pci-root'/>
404507
+    <input type='mouse' bus='ps2'/>
404507
+    <input type='keyboard' bus='ps2'/>
404507
+    <memballoon model='virtio'/>
404507
+  </devices>
404507
+</domain>
404507
diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c
404507
index 4ced5c349c..4c3f32a816 100644
404507
--- a/tests/genericxml2xmltest.c
404507
+++ b/tests/genericxml2xmltest.c
404507
@@ -133,6 +133,7 @@ mymain(void)
404507
     DO_TEST("cachetune");
404507
     DO_TEST("cachetune-small");
404507
     DO_TEST("cachetune-cdp");
404507
+    DO_TEST_DIFFERENT("cachetune-extra-tunes");
404507
     DO_TEST_FULL("cachetune-colliding-allocs", false, true,
404507
                  TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_PARSE);
404507
     DO_TEST_FULL("cachetune-colliding-tunes", false, true,
404507
-- 
404507
2.16.1
404507