99cbc7
From 7f5678ed68f81e6e4a308518aa985af2d3afee04 Mon Sep 17 00:00:00 2001
99cbc7
Message-Id: <7f5678ed68f81e6e4a308518aa985af2d3afee04@dist-git>
99cbc7
From: Michal Privoznik <mprivozn@redhat.com>
99cbc7
Date: Wed, 4 Jul 2018 14:51:18 +0200
99cbc7
Subject: [PATCH] src: Mention DEVICE_REMOVAL_FAILED event in
99cbc7
 virDomainDetachDeviceAlias docs
99cbc7
99cbc7
https://bugzilla.redhat.com/show_bug.cgi?id=1598087
99cbc7
99cbc7
We are mentioning the positive outcome of the function and not
99cbc7
the case when live detaching a device is denied and event is
99cbc7
issued.
99cbc7
99cbc7
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
99cbc7
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
99cbc7
(cherry picked from commit 7152b12c45f69861f41f87916e4b950d2c1ff9fd)
99cbc7
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
99cbc7
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
99cbc7
---
99cbc7
 src/libvirt-domain.c | 4 +++-
99cbc7
 1 file changed, 3 insertions(+), 1 deletion(-)
99cbc7
99cbc7
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
99cbc7
index c71f2e6877..ab7266dc19 100644
99cbc7
--- a/src/libvirt-domain.c
99cbc7
+++ b/src/libvirt-domain.c
99cbc7
@@ -8365,7 +8365,9 @@ virDomainUpdateDeviceFlags(virDomainPtr domain,
99cbc7
  * asynchronous - it returns immediately after sending the detach
99cbc7
  * request to the hypervisor. It's caller's responsibility to
99cbc7
  * wait for VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event to signal
99cbc7
- * actual device removal.
99cbc7
+ * actual device removal or for
99cbc7
+ * VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED to signal rejected
99cbc7
+ * device removal.
99cbc7
  *
99cbc7
  * Returns 0 in case of success, -1 in case of failure.
99cbc7
  */
99cbc7
-- 
99cbc7
2.18.0
99cbc7