397dc2
From 4fd196d6126cb9daeb771522ad23ecba0e9fd5c9 Mon Sep 17 00:00:00 2001
397dc2
Message-Id: <4fd196d6126cb9daeb771522ad23ecba0e9fd5c9@dist-git>
397dc2
From: Michal Privoznik <mprivozn@redhat.com>
397dc2
Date: Wed, 7 Oct 2020 18:45:35 +0200
397dc2
Subject: [PATCH] qemu_command: Rename qemuBuildNumaArgStr()
397dc2
MIME-Version: 1.0
397dc2
Content-Type: text/plain; charset=UTF-8
397dc2
Content-Transfer-Encoding: 8bit
397dc2
397dc2
The function doesn't just build the argument for -numa. Since the
397dc2
-numa can be repeated multiple times, it also puts -numa onto the
397dc2
cmd line. Also, the rest of the functions has 'Command' infix.
397dc2
397dc2
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
397dc2
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
397dc2
(cherry picked from commit 8ba1792785e17736db866d62b68812a9c7e7ca40)
397dc2
397dc2
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1749518
397dc2
397dc2
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
397dc2
Message-Id: <f5e22c8cfce2a9636303e916d97ce0501376137f.1602087923.git.mprivozn@redhat.com>
397dc2
Reviewed-by: Ján Tomko <jtomko@redhat.com>
397dc2
---
397dc2
 src/qemu/qemu_command.c | 10 +++++-----
397dc2
 1 file changed, 5 insertions(+), 5 deletions(-)
397dc2
397dc2
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
397dc2
index ed5f60e82e..8c4f7a015f 100644
397dc2
--- a/src/qemu/qemu_command.c
397dc2
+++ b/src/qemu/qemu_command.c
397dc2
@@ -7363,10 +7363,10 @@ qemuBuildIOThreadCommandLine(virCommandPtr cmd,
397dc2
 
397dc2
 
397dc2
 static int
397dc2
-qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg,
397dc2
-                    virDomainDefPtr def,
397dc2
-                    virCommandPtr cmd,
397dc2
-                    qemuDomainObjPrivatePtr priv)
397dc2
+qemuBuildNumaCommandLine(virQEMUDriverConfigPtr cfg,
397dc2
+                         virDomainDefPtr def,
397dc2
+                         virCommandPtr cmd,
397dc2
+                         qemuDomainObjPrivatePtr priv)
397dc2
 {
397dc2
     size_t i, j;
397dc2
     virQEMUCapsPtr qemuCaps = priv->qemuCaps;
397dc2
@@ -9930,7 +9930,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver,
397dc2
         return NULL;
397dc2
 
397dc2
     if (virDomainNumaGetNodeCount(def->numa) &&
397dc2
-        qemuBuildNumaArgStr(cfg, def, cmd, priv) < 0)
397dc2
+        qemuBuildNumaCommandLine(cfg, def, cmd, priv) < 0)
397dc2
         return NULL;
397dc2
 
397dc2
     if (qemuBuildMemoryDeviceCommandLine(cmd, cfg, def, priv) < 0)
397dc2
-- 
397dc2
2.29.2
397dc2