397dc2
From 4a3d416229ddf600ff985f9a90e3feb669548690 Mon Sep 17 00:00:00 2001
397dc2
Message-Id: <4a3d416229ddf600ff985f9a90e3feb669548690@dist-git>
397dc2
From: Michal Privoznik <mprivozn@redhat.com>
397dc2
Date: Wed, 7 Oct 2020 18:45:36 +0200
397dc2
Subject: [PATCH] qemuBuildMachineCommandLine: Drop needless check
397dc2
MIME-Version: 1.0
397dc2
Content-Type: text/plain; charset=UTF-8
397dc2
Content-Transfer-Encoding: 8bit
397dc2
397dc2
The machine can not be NULL at this point -
397dc2
qemuDomainDefPostParse() makes sure it isn't.
397dc2
397dc2
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
397dc2
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
397dc2
(cherry picked from commit fe43b3a5a5532377f7de40e77ca9ffde5aa2ca7e)
397dc2
397dc2
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1749518
397dc2
397dc2
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
397dc2
Message-Id: <4a0c05b78ac65e598b919acdb66d24a19fcf6251.1602087923.git.mprivozn@redhat.com>
397dc2
Reviewed-by: Ján Tomko <jtomko@redhat.com>
397dc2
---
397dc2
 src/qemu/qemu_command.c | 7 -------
397dc2
 1 file changed, 7 deletions(-)
397dc2
397dc2
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
397dc2
index 8c4f7a015f..1a573c2817 100644
397dc2
--- a/src/qemu/qemu_command.c
397dc2
+++ b/src/qemu/qemu_command.c
397dc2
@@ -6977,13 +6977,6 @@ qemuBuildMachineCommandLine(virCommandPtr cmd,
397dc2
     g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
397dc2
     size_t i;
397dc2
 
397dc2
-    /* This should *never* be NULL, since we always provide
397dc2
-     * a machine in the capabilities data for QEMU. So this
397dc2
-     * check is just here as a safety in case the unexpected
397dc2
-     * happens */
397dc2
-    if (!def->os.machine)
397dc2
-        return 0;
397dc2
-
397dc2
     virCommandAddArg(cmd, "-machine");
397dc2
     virBufferAdd(&buf, def->os.machine, -1);
397dc2
 
397dc2
-- 
397dc2
2.29.2
397dc2