|
 |
6d3351 |
From 657451fe2a5e8b55adbae643ac818b496c9cbc0c Mon Sep 17 00:00:00 2001
|
|
|
6d3351 |
Message-Id: <657451fe2a5e8b55adbae643ac818b496c9cbc0c@dist-git>
|
|
|
6d3351 |
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
|
|
|
6d3351 |
Date: Tue, 16 May 2017 10:44:51 +0200
|
|
|
6d3351 |
Subject: [PATCH] qemu: refactor qemuBuildIOMMUCommandLine
|
|
|
6d3351 |
MIME-Version: 1.0
|
|
|
6d3351 |
Content-Type: text/plain; charset=UTF-8
|
|
|
6d3351 |
Content-Transfer-Encoding: 8bit
|
|
|
6d3351 |
|
|
|
6d3351 |
Introduce a separate buffer for options and use a helper
|
|
|
6d3351 |
variable for def->iommu.
|
|
|
6d3351 |
|
|
|
6d3351 |
(cherry picked from commit b595cc05e83288b743d48904964e4dcb547a2d26)
|
|
|
6d3351 |
Signed-off-by: Ján Tomko <jtomko@redhat.com>
|
|
|
6d3351 |
|
|
|
6d3351 |
https://bugzilla.redhat.com/show_bug.cgi?id=1427005
|
|
|
6d3351 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
6d3351 |
---
|
|
|
6d3351 |
src/qemu/qemu_command.c | 21 +++++++++++++++------
|
|
|
6d3351 |
1 file changed, 15 insertions(+), 6 deletions(-)
|
|
|
6d3351 |
|
|
|
6d3351 |
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
|
|
|
6d3351 |
index 4d3a3d8ca..b27b9f8ad 100644
|
|
|
6d3351 |
--- a/src/qemu/qemu_command.c
|
|
|
6d3351 |
+++ b/src/qemu/qemu_command.c
|
|
|
6d3351 |
@@ -6664,33 +6664,42 @@ qemuBuildIOMMUCommandLine(virCommandPtr cmd,
|
|
|
6d3351 |
const virDomainDef *def,
|
|
|
6d3351 |
virQEMUCapsPtr qemuCaps)
|
|
|
6d3351 |
{
|
|
|
6d3351 |
- if (!def->iommu)
|
|
|
6d3351 |
+ virBuffer opts = VIR_BUFFER_INITIALIZER;
|
|
|
6d3351 |
+ const virDomainIOMMUDef *iommu = def->iommu;
|
|
|
6d3351 |
+ int ret = -1;
|
|
|
6d3351 |
+
|
|
|
6d3351 |
+ if (!iommu)
|
|
|
6d3351 |
return 0;
|
|
|
6d3351 |
|
|
|
6d3351 |
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_IOMMU))
|
|
|
6d3351 |
return 0; /* Already handled via -machine */
|
|
|
6d3351 |
|
|
|
6d3351 |
- switch (def->iommu->model) {
|
|
|
6d3351 |
+ switch (iommu->model) {
|
|
|
6d3351 |
case VIR_DOMAIN_IOMMU_MODEL_INTEL:
|
|
|
6d3351 |
if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_INTEL_IOMMU)) {
|
|
|
6d3351 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
6d3351 |
_("IOMMU device: '%s' is not supported with "
|
|
|
6d3351 |
"this QEMU binary"),
|
|
|
6d3351 |
- virDomainIOMMUModelTypeToString(def->iommu->model));
|
|
|
6d3351 |
+ virDomainIOMMUModelTypeToString(iommu->model));
|
|
|
6d3351 |
return -1;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
if (!qemuDomainIsQ35(def)) {
|
|
|
6d3351 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
6d3351 |
_("IOMMU device: '%s' is only supported with "
|
|
|
6d3351 |
"Q35 machines"),
|
|
|
6d3351 |
- virDomainIOMMUModelTypeToString(def->iommu->model));
|
|
|
6d3351 |
+ virDomainIOMMUModelTypeToString(iommu->model));
|
|
|
6d3351 |
return -1;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
- virCommandAddArgList(cmd, "-device", "intel-iommu", NULL);
|
|
|
6d3351 |
+ virBufferAddLit(&opts, "intel-iommu");
|
|
|
6d3351 |
case VIR_DOMAIN_IOMMU_MODEL_LAST:
|
|
|
6d3351 |
break;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
- return 0;
|
|
|
6d3351 |
+ virCommandAddArg(cmd, "-device");
|
|
|
6d3351 |
+ virCommandAddArgBuffer(cmd, &opts);
|
|
|
6d3351 |
+
|
|
|
6d3351 |
+ ret = 0;
|
|
|
6d3351 |
+ virBufferFreeAndReset(&opts);
|
|
|
6d3351 |
+ return ret;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
|
|
|
6d3351 |
|
|
|
6d3351 |
--
|
|
|
6d3351 |
2.13.0
|
|
|
6d3351 |
|