From 547c0e17e665d7a1051d8670b2f9e44783dbaf58 Mon Sep 17 00:00:00 2001

Message-Id: <547c0e17e665d7a1051d8670b2f9e44783dbaf58@dist-git>

From: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>

Date: Fri, 1 Sep 2017 09:49:31 +0300

Subject: [PATCH] qemu: migration: don't expose incomplete job as complete

In case of real migration (not migrating to file on save, dump etc)

migration info is not complete at time qemu finishes migration

in normal (non postcopy) mode. We need to update disks stats,

downtime info etc. Thus let's not expose this job status as

completed.

To archive this let's set status to 'qemu completed' after

qemu reports migration is finished. It is not visible as complete

job to clients. Cookie code on confirm phase will finally turn

job into completed. As we don't need more things to do when

migrating to file status is set to 'completed' as before

in this case.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

(cherry picked from commit 3f2d6d829eb8de0348fcbd58d654b29d5c5bebc2)

https://bugzilla.redhat.com/show_bug.cgi?id=1530130

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

---

 src/qemu/qemu_domain.c    |  1 +

 src/qemu/qemu_domain.h    |  1 +

 src/qemu/qemu_driver.c    |  1 +

 src/qemu/qemu_migration.c | 13 +++++++++----

 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

index e81d682c00..9a80e409b9 100644

--- a/src/qemu/qemu_domain.c

+++ b/src/qemu/qemu_domain.c

@@ -398,6 +398,7 @@ qemuDomainJobStatusToType(qemuDomainJobStatus status)

     case QEMU_DOMAIN_JOB_STATUS_ACTIVE:

     case QEMU_DOMAIN_JOB_STATUS_MIGRATING:

+    case QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED:

     case QEMU_DOMAIN_JOB_STATUS_POSTCOPY:

         return VIR_DOMAIN_JOB_UNBOUNDED;

diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h

index 0cf54d99ae..cc458e1224 100644

--- a/src/qemu/qemu_domain.h

+++ b/src/qemu/qemu_domain.h

@@ -103,6 +103,7 @@ typedef enum {

     QEMU_DOMAIN_JOB_STATUS_NONE = 0,

     QEMU_DOMAIN_JOB_STATUS_ACTIVE,

     QEMU_DOMAIN_JOB_STATUS_MIGRATING,

+    QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED,

     QEMU_DOMAIN_JOB_STATUS_POSTCOPY,

     QEMU_DOMAIN_JOB_STATUS_COMPLETED,

     QEMU_DOMAIN_JOB_STATUS_FAILED,

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

index 931f3d344d..d2dd704868 100644

--- a/src/qemu/qemu_driver.c

+++ b/src/qemu/qemu_driver.c

@@ -12972,6 +12972,7 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver,

     if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_ACTIVE ||

         jobInfo->status == QEMU_DOMAIN_JOB_STATUS_MIGRATING ||

+        jobInfo->status == QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED ||

         jobInfo->status == QEMU_DOMAIN_JOB_STATUS_POSTCOPY) {

         if (fetch)

             ret = qemuMigrationFetchJobStatus(driver, vm, QEMU_ASYNC_JOB_NONE,

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c

index c8cd7ebfa3..aabd0913ad 100644

--- a/src/qemu/qemu_migration.c

+++ b/src/qemu/qemu_migration.c

@@ -1338,7 +1338,7 @@ qemuMigrationUpdateJobType(qemuDomainJobInfoPtr jobInfo)

         break;

     case QEMU_MONITOR_MIGRATION_STATUS_COMPLETED:

-        jobInfo->status = QEMU_DOMAIN_JOB_STATUS_COMPLETED;

+        jobInfo->status = QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED;

         break;

     case QEMU_MONITOR_MIGRATION_STATUS_INACTIVE:

@@ -1461,6 +1461,7 @@ qemuMigrationCheckJobStatus(virQEMUDriverPtr driver,

     case QEMU_DOMAIN_JOB_STATUS_ACTIVE:

     case QEMU_DOMAIN_JOB_STATUS_MIGRATING:

+    case QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED:

     case QEMU_DOMAIN_JOB_STATUS_POSTCOPY:

         break;

     }

@@ -1527,19 +1528,19 @@ qemuMigrationCompleted(virQEMUDriverPtr driver,

         return 1;

     }

-    if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_COMPLETED)

+    if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED)

         return 1;

     else

         return 0;

  error:

-    /* state can not be active at this point */

+    /* state can not be active or completed at this point */

     if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_MIGRATING ||

         jobInfo->status == QEMU_DOMAIN_JOB_STATUS_POSTCOPY) {

         /* The migration was aborted by us rather than QEMU itself. */

         jobInfo->status = QEMU_DOMAIN_JOB_STATUS_FAILED;

         return -2;

-    } else if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_COMPLETED) {

+    } else if (jobInfo->status == QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED) {

         jobInfo->status = QEMU_DOMAIN_JOB_STATUS_FAILED;

         return -1;

     } else {

@@ -1592,6 +1593,10 @@ qemuMigrationWaitForCompletion(virQEMUDriverPtr driver,

     if (VIR_ALLOC(priv->job.completed) == 0)

         *priv->job.completed = *jobInfo;

+    if (asyncJob != QEMU_ASYNC_JOB_MIGRATION_OUT &&

+        jobInfo->status == QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED)

+        jobInfo->status = QEMU_DOMAIN_JOB_STATUS_COMPLETED;

+

     return 0;

 }

-- 

2.15.1