|
 |
6d3351 |
From 2d773381c7dd2d015a0890db36df64c76a6bfe46 Mon Sep 17 00:00:00 2001
|
|
|
6d3351 |
Message-Id: <2d773381c7dd2d015a0890db36df64c76a6bfe46@dist-git>
|
|
|
6d3351 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
6d3351 |
Date: Tue, 4 Apr 2017 09:31:23 +0200
|
|
|
6d3351 |
Subject: [PATCH] qemu: hotplug: Add validation for coldplug of individual
|
|
|
6d3351 |
vcpus
|
|
|
6d3351 |
|
|
|
6d3351 |
Validate that users don't try to disable vcpu 0.
|
|
|
6d3351 |
|
|
|
6d3351 |
(cherry picked from commit ee86d45de35bff5f75d1583701cc9514b59e747c)
|
|
|
6d3351 |
|
|
|
6d3351 |
https://bugzilla.redhat.com/show_bug.cgi?id=1437010
|
|
|
6d3351 |
---
|
|
|
6d3351 |
src/qemu/qemu_hotplug.c | 20 ++++++++++++++++++++
|
|
|
6d3351 |
1 file changed, 20 insertions(+)
|
|
|
6d3351 |
|
|
|
6d3351 |
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
|
|
|
6d3351 |
index 5488b1dd4..999c8b804 100644
|
|
|
6d3351 |
--- a/src/qemu/qemu_hotplug.c
|
|
|
6d3351 |
+++ b/src/qemu/qemu_hotplug.c
|
|
|
6d3351 |
@@ -5875,6 +5875,21 @@ qemuDomainFilterHotplugVcpuEntities(virDomainDefPtr def,
|
|
|
6d3351 |
}
|
|
|
6d3351 |
|
|
|
6d3351 |
|
|
|
6d3351 |
+static int
|
|
|
6d3351 |
+qemuDomainVcpuValidateConfig(virBitmapPtr map,
|
|
|
6d3351 |
+ bool state)
|
|
|
6d3351 |
+{
|
|
|
6d3351 |
+ /* vcpu 0 can't be disabled */
|
|
|
6d3351 |
+ if (!state && virBitmapIsBitSet(map, 0)) {
|
|
|
6d3351 |
+ virReportError(VIR_ERR_INVALID_ARG, "%s",
|
|
|
6d3351 |
+ _("vCPU '0' must be enabled"));
|
|
|
6d3351 |
+ return -1;
|
|
|
6d3351 |
+ }
|
|
|
6d3351 |
+
|
|
|
6d3351 |
+ return 0;
|
|
|
6d3351 |
+}
|
|
|
6d3351 |
+
|
|
|
6d3351 |
+
|
|
|
6d3351 |
int
|
|
|
6d3351 |
qemuDomainSetVcpuInternal(virQEMUDriverPtr driver,
|
|
|
6d3351 |
virDomainObjPtr vm,
|
|
|
6d3351 |
@@ -5909,6 +5924,11 @@ qemuDomainSetVcpuInternal(virQEMUDriverPtr driver,
|
|
|
6d3351 |
}
|
|
|
6d3351 |
}
|
|
|
6d3351 |
|
|
|
6d3351 |
+ if (persistentDef) {
|
|
|
6d3351 |
+ if (qemuDomainVcpuValidateConfig(map, state) < 0)
|
|
|
6d3351 |
+ goto cleanup;
|
|
|
6d3351 |
+ }
|
|
|
6d3351 |
+
|
|
|
6d3351 |
if (livevcpus &&
|
|
|
6d3351 |
qemuDomainSetVcpusLive(driver, cfg, vm, livevcpus, state) < 0)
|
|
|
6d3351 |
goto cleanup;
|
|
|
6d3351 |
--
|
|
|
6d3351 |
2.12.2
|
|
|
6d3351 |
|