397dc2
From 1b7381da7db7092bf774779a610f153532efa5d4 Mon Sep 17 00:00:00 2001
397dc2
Message-Id: <1b7381da7db7092bf774779a610f153532efa5d4@dist-git>
397dc2
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
397dc2
Date: Tue, 29 Sep 2020 14:43:06 +0200
397dc2
Subject: [PATCH] qemu: agent: set ifname to NULL after freeing
397dc2
MIME-Version: 1.0
397dc2
Content-Type: text/plain; charset=UTF-8
397dc2
Content-Transfer-Encoding: 8bit
397dc2
397dc2
CVE-2020-25637
397dc2
397dc2
Signed-off-by: Ján Tomko <jtomko@redhat.com>
397dc2
Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
397dc2
Fixes: 0977b8aa071de550e1a013d35e2c72615e65d520
397dc2
Reviewed-by: Mauro Matteo Cascella <mcascell@redhat.com>
397dc2
(cherry picked from commit a63b48c5ecef077bf0f909a85f453a605600cf05)
397dc2
Signed-off-by: Ján Tomko <jtomko@redhat.com>
397dc2
397dc2
Conflicts: src/qemu/qemu_agent.c
397dc2
    Commit ee247e1d which switched virStringListFree
397dc2
    to g_strfreev is missing downstream.
397dc2
Message-Id: <01acbf07b5b165b89cc73a127fe7bda666bdf235.1601383236.git.jtomko@redhat.com>
397dc2
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
397dc2
---
397dc2
 src/qemu/qemu_agent.c | 1 +
397dc2
 1 file changed, 1 insertion(+)
397dc2
397dc2
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
397dc2
index f13126aeee..968534b594 100644
397dc2
--- a/src/qemu/qemu_agent.c
397dc2
+++ b/src/qemu/qemu_agent.c
397dc2
@@ -2192,6 +2192,7 @@ qemuAgentGetInterfaces(qemuAgentPtr mon,
397dc2
 
397dc2
         /* Has to be freed for each interface. */
397dc2
         virStringListFree(ifname);
397dc2
+        ifname = NULL;
397dc2
 
397dc2
         /* as well as IP address which - moreover -
397dc2
          * can be presented multiple times */
397dc2
-- 
397dc2
2.28.0
397dc2