fbe740
From 2527410246c5d9f0642087fbd894fdba8d8fa906 Mon Sep 17 00:00:00 2001
fbe740
Message-Id: <2527410246c5d9f0642087fbd894fdba8d8fa906@dist-git>
fbe740
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
fbe740
Date: Mon, 3 Feb 2020 18:07:24 +0000
fbe740
Subject: [PATCH] qemu: add support for specifying CPU "dies" topology
fbe740
 parameter
fbe740
MIME-Version: 1.0
fbe740
Content-Type: text/plain; charset=UTF-8
fbe740
Content-Transfer-Encoding: 8bit
fbe740
fbe740
QEMU since 4.1.0 supports the "dies" parameter for -smp
fbe740
fbe740
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
fbe740
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
fbe740
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
fbe740
(cherry picked from commit 4cf8dd0c57330e9141333a1b9f4e318e3c83a289)
fbe740
fbe740
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1785207
fbe740
Message-Id: <20200203180726.2203691-4-berrange@redhat.com>
fbe740
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
fbe740
---
fbe740
 src/qemu/qemu_capabilities.c                  |  2 ++
fbe740
 src/qemu/qemu_capabilities.h                  |  1 +
fbe740
 src/qemu/qemu_command.c                       |  9 +++--
fbe740
 .../caps_4.1.0.x86_64.xml                     |  1 +
fbe740
 .../caps_4.2.0.aarch64.xml                    |  1 +
fbe740
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
fbe740
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
fbe740
 .../caps_4.2.0.x86_64.xml                     |  1 +
fbe740
 .../hugepages-nvdimm.x86_64-latest.args       |  2 +-
fbe740
 ...memory-default-hugepage.x86_64-latest.args |  2 +-
fbe740
 .../memfd-memory-numa.x86_64-latest.args      |  2 +-
fbe740
 ...y-hotplug-nvdimm-access.x86_64-latest.args |  2 +-
fbe740
 ...ry-hotplug-nvdimm-align.x86_64-latest.args |  2 +-
fbe740
 ...ry-hotplug-nvdimm-label.x86_64-latest.args |  2 +-
fbe740
 ...ory-hotplug-nvdimm-pmem.x86_64-latest.args |  2 +-
fbe740
 ...hotplug-nvdimm-readonly.x86_64-latest.args |  2 +-
fbe740
 .../memory-hotplug-nvdimm.x86_64-latest.args  |  2 +-
fbe740
 tests/qemuxml2argvdata/smp-dies.args          | 29 ++++++++++++++++
fbe740
 tests/qemuxml2argvdata/smp-dies.xml           | 33 +++++++++++++++++++
fbe740
 tests/qemuxml2argvtest.c                      |  1 +
fbe740
 20 files changed, 86 insertions(+), 12 deletions(-)
fbe740
 create mode 100644 tests/qemuxml2argvdata/smp-dies.args
fbe740
 create mode 100644 tests/qemuxml2argvdata/smp-dies.xml
fbe740
fbe740
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
fbe740
index edefb70309..893fc5a1bb 100644
fbe740
--- a/src/qemu/qemu_capabilities.c
fbe740
+++ b/src/qemu/qemu_capabilities.c
fbe740
@@ -553,6 +553,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
fbe740
               "blockdev-file-dynamic-auto-read-only",
fbe740
               "savevm-monitor-nodes",
fbe740
               "drive-nvme",
fbe740
+              "smp-dies",
fbe740
     );
fbe740
 
fbe740
 
fbe740
@@ -3097,6 +3098,7 @@ static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = {
fbe740
     { "sandbox", "elevateprivileges", QEMU_CAPS_SECCOMP_BLACKLIST },
fbe740
     { "chardev", "fd", QEMU_CAPS_CHARDEV_FD_PASS },
fbe740
     { "overcommit", NULL, QEMU_CAPS_OVERCOMMIT },
fbe740
+    { "smp-opts", "dies", QEMU_CAPS_SMP_DIES },
fbe740
 };
fbe740
 
fbe740
 static int
fbe740
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
fbe740
index d76c1dbfa9..5ec8901bb3 100644
fbe740
--- a/src/qemu/qemu_capabilities.h
fbe740
+++ b/src/qemu/qemu_capabilities.h
fbe740
@@ -534,6 +534,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
fbe740
     QEMU_CAPS_BLOCK_FILE_AUTO_READONLY_DYNAMIC, /* the auto-read-only property of block backends for files is dynamic */
fbe740
     QEMU_CAPS_SAVEVM_MONITOR_NODES, /* 'savevm' handles monitor-owned nodes properly */
fbe740
     QEMU_CAPS_DRIVE_NVME, /* -drive file.driver=nvme */
fbe740
+    QEMU_CAPS_SMP_DIES, /*  -smp dies= */
fbe740
 
fbe740
     QEMU_CAPS_LAST /* this must always be the last item */
fbe740
 } virQEMUCapsFlags;
fbe740
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
fbe740
index d7e8216092..7a184c229e 100644
fbe740
--- a/src/qemu/qemu_command.c
fbe740
+++ b/src/qemu/qemu_command.c
fbe740
@@ -7105,7 +7105,8 @@ qemuBuildTSEGCommandLine(virCommandPtr cmd,
fbe740
 
fbe740
 static int
fbe740
 qemuBuildSmpCommandLine(virCommandPtr cmd,
fbe740
-                        virDomainDefPtr def)
fbe740
+                        virDomainDefPtr def,
fbe740
+                        virQEMUCapsPtr qemuCaps)
fbe740
 {
fbe740
     g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
fbe740
     unsigned int maxvcpus = virDomainDefGetVcpusMax(def);
fbe740
@@ -7130,12 +7131,14 @@ qemuBuildSmpCommandLine(virCommandPtr cmd,
fbe740
     /* sockets, cores, and threads are either all zero
fbe740
      * or all non-zero, thus checking one of them is enough */
fbe740
     if (def->cpu && def->cpu->sockets) {
fbe740
-        if (def->cpu->dies != 1) {
fbe740
+        if (def->cpu->dies != 1 && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_SMP_DIES)) {
fbe740
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
fbe740
                            _("Only 1 die per socket is supported"));
fbe740
             return -1;
fbe740
         }
fbe740
         virBufferAsprintf(&buf, ",sockets=%u", def->cpu->sockets);
fbe740
+        if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_SMP_DIES))
fbe740
+            virBufferAsprintf(&buf, ",dies=%u", def->cpu->dies);
fbe740
         virBufferAsprintf(&buf, ",cores=%u", def->cpu->cores);
fbe740
         virBufferAsprintf(&buf, ",threads=%u", def->cpu->threads);
fbe740
     } else {
fbe740
@@ -9823,7 +9826,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver,
fbe740
     if (qemuBuildMemCommandLine(cmd, cfg, def, qemuCaps, priv) < 0)
fbe740
         return NULL;
fbe740
 
fbe740
-    if (qemuBuildSmpCommandLine(cmd, def) < 0)
fbe740
+    if (qemuBuildSmpCommandLine(cmd, def, qemuCaps) < 0)
fbe740
         return NULL;
fbe740
 
fbe740
     if (qemuBuildIOThreadCommandLine(cmd, def) < 0)
fbe740
diff --git a/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml
fbe740
index a98945de0e..54b797a86a 100644
fbe740
--- a/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml
fbe740
+++ b/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml
fbe740
@@ -215,6 +215,7 @@
fbe740
   <flag name='ramfb'/>
fbe740
   <flag name='blockdev-file-dynamic-auto-read-only'/>
fbe740
   <flag name='drive-nvme'/>
fbe740
+  <flag name='smp-dies'/>
fbe740
   <version>4001000</version>
fbe740
   <kvmVersion>0</kvmVersion>
fbe740
   <microcodeVersion>43100241</microcodeVersion>
fbe740
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
fbe740
index a6469073fd..184bb7ff77 100644
fbe740
--- a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
fbe740
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
fbe740
@@ -175,6 +175,7 @@
fbe740
   <flag name='blockdev-file-dynamic-auto-read-only'/>
fbe740
   <flag name='savevm-monitor-nodes'/>
fbe740
   <flag name='drive-nvme'/>
fbe740
+  <flag name='smp-dies'/>
fbe740
   <version>4001050</version>
fbe740
   <kvmVersion>0</kvmVersion>
fbe740
   <microcodeVersion>61700242</microcodeVersion>
fbe740
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
fbe740
index ee9fb23640..7c62546d74 100644
fbe740
--- a/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
fbe740
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
fbe740
@@ -176,6 +176,7 @@
fbe740
   <flag name='machine.pseries.cap-ccf-assist'/>
fbe740
   <flag name='blockdev-file-dynamic-auto-read-only'/>
fbe740
   <flag name='drive-nvme'/>
fbe740
+  <flag name='smp-dies'/>
fbe740
   <version>4001050</version>
fbe740
   <kvmVersion>0</kvmVersion>
fbe740
   <microcodeVersion>42900242</microcodeVersion>
fbe740
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
fbe740
index fdf5cb4ce9..c8746f05ef 100644
fbe740
--- a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
fbe740
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
fbe740
@@ -135,6 +135,7 @@
fbe740
   <flag name='query-cpu-model-comparison'/>
fbe740
   <flag name='blockdev-file-dynamic-auto-read-only'/>
fbe740
   <flag name='drive-nvme'/>
fbe740
+  <flag name='smp-dies'/>
fbe740
   <version>4001050</version>
fbe740
   <kvmVersion>0</kvmVersion>
fbe740
   <microcodeVersion>39100242</microcodeVersion>
fbe740
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
fbe740
index 4857e2f5a5..afd59a269d 100644
fbe740
--- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
fbe740
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
fbe740
@@ -218,6 +218,7 @@
fbe740
   <flag name='blockdev-file-dynamic-auto-read-only'/>
fbe740
   <flag name='savevm-monitor-nodes'/>
fbe740
   <flag name='drive-nvme'/>
fbe740
+  <flag name='smp-dies'/>
fbe740
   <version>4002000</version>
fbe740
   <kvmVersion>0</kvmVersion>
fbe740
   <microcodeVersion>43100242</microcodeVersion>
fbe740
diff --git a/tests/qemuxml2argvdata/hugepages-nvdimm.x86_64-latest.args b/tests/qemuxml2argvdata/hugepages-nvdimm.x86_64-latest.args
fbe740
index 9056e56cb7..0d795dca91 100644
fbe740
--- a/tests/qemuxml2argvdata/hugepages-nvdimm.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/hugepages-nvdimm.x86_64-latest.args
fbe740
@@ -15,7 +15,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
fbe740
 -machine pc,accel=tcg,usb=off,dump-guest-core=off,nvdimm=on \
fbe740
 -m size=1048576k,slots=16,maxmem=1099511627776k \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 2,sockets=2,cores=1,threads=1 \
fbe740
+-smp 2,sockets=2,dies=1,cores=1,threads=1 \
fbe740
 -object memory-backend-file,id=ram-node0,prealloc=yes,\
fbe740
 mem-path=/dev/hugepages2M/libvirt/qemu/-1-QEMUGuest1,share=yes,size=1073741824 \
fbe740
 -numa node,nodeid=0,cpus=0-1,memdev=ram-node0 \
fbe740
diff --git a/tests/qemuxml2argvdata/memfd-memory-default-hugepage.x86_64-latest.args b/tests/qemuxml2argvdata/memfd-memory-default-hugepage.x86_64-latest.args
fbe740
index 998c9f98bd..a655fb1f7c 100644
fbe740
--- a/tests/qemuxml2argvdata/memfd-memory-default-hugepage.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memfd-memory-default-hugepage.x86_64-latest.args
fbe740
@@ -16,7 +16,7 @@ file=/tmp/lib/domain--1-instance-00000092/master-key.aes \
fbe740
 -m 14336 \
fbe740
 -mem-prealloc \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 8,sockets=1,cores=8,threads=1 \
fbe740
+-smp 8,sockets=1,dies=1,cores=8,threads=1 \
fbe740
 -object memory-backend-memfd,id=ram-node0,hugetlb=yes,hugetlbsize=2097152,\
fbe740
 share=yes,size=15032385536,host-nodes=3,policy=preferred \
fbe740
 -numa node,nodeid=0,cpus=0-7,memdev=ram-node0 \
fbe740
diff --git a/tests/qemuxml2argvdata/memfd-memory-numa.x86_64-latest.args b/tests/qemuxml2argvdata/memfd-memory-numa.x86_64-latest.args
fbe740
index 998c9f98bd..a655fb1f7c 100644
fbe740
--- a/tests/qemuxml2argvdata/memfd-memory-numa.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memfd-memory-numa.x86_64-latest.args
fbe740
@@ -16,7 +16,7 @@ file=/tmp/lib/domain--1-instance-00000092/master-key.aes \
fbe740
 -m 14336 \
fbe740
 -mem-prealloc \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 8,sockets=1,cores=8,threads=1 \
fbe740
+-smp 8,sockets=1,dies=1,cores=8,threads=1 \
fbe740
 -object memory-backend-memfd,id=ram-node0,hugetlb=yes,hugetlbsize=2097152,\
fbe740
 share=yes,size=15032385536,host-nodes=3,policy=preferred \
fbe740
 -numa node,nodeid=0,cpus=0-7,memdev=ram-node0 \
fbe740
diff --git a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-access.x86_64-latest.args b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-access.x86_64-latest.args
fbe740
index beac9ab22a..c8a6ec5755 100644
fbe740
--- a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-access.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-access.x86_64-latest.args
fbe740
@@ -15,7 +15,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
fbe740
 -machine pc,accel=tcg,usb=off,dump-guest-core=off,nvdimm=on \
fbe740
 -m size=219136k,slots=16,maxmem=1099511627776k \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 2,sockets=2,cores=1,threads=1 \
fbe740
+-smp 2,sockets=2,dies=1,cores=1,threads=1 \
fbe740
 -numa node,nodeid=0,cpus=0-1,mem=214 \
fbe740
 -object memory-backend-file,id=memnvdimm0,prealloc=yes,mem-path=/tmp/nvdimm,\
fbe740
 share=no,size=536870912 \
fbe740
diff --git a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-align.x86_64-latest.args b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-align.x86_64-latest.args
fbe740
index 3e599098f0..60e9e80039 100644
fbe740
--- a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-align.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-align.x86_64-latest.args
fbe740
@@ -15,7 +15,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
fbe740
 -machine pc,accel=tcg,usb=off,dump-guest-core=off,nvdimm=on \
fbe740
 -m size=219136k,slots=16,maxmem=1099511627776k \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 2,sockets=2,cores=1,threads=1 \
fbe740
+-smp 2,sockets=2,dies=1,cores=1,threads=1 \
fbe740
 -numa node,nodeid=0,cpus=0-1,mem=214 \
fbe740
 -object memory-backend-file,id=memnvdimm0,prealloc=yes,mem-path=/tmp/nvdimm,\
fbe740
 share=no,size=536870912,align=2097152 \
fbe740
diff --git a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-label.x86_64-latest.args b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-label.x86_64-latest.args
fbe740
index 05a473dbcc..8c5e483cbb 100644
fbe740
--- a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-label.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-label.x86_64-latest.args
fbe740
@@ -15,7 +15,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
fbe740
 -machine pc,accel=tcg,usb=off,dump-guest-core=off,nvdimm=on \
fbe740
 -m size=219136k,slots=16,maxmem=1099511627776k \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 2,sockets=2,cores=1,threads=1 \
fbe740
+-smp 2,sockets=2,dies=1,cores=1,threads=1 \
fbe740
 -numa node,nodeid=0,cpus=0-1,mem=214 \
fbe740
 -object memory-backend-file,id=memnvdimm0,prealloc=yes,mem-path=/tmp/nvdimm,\
fbe740
 share=no,size=536870912 \
fbe740
diff --git a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-pmem.x86_64-latest.args b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-pmem.x86_64-latest.args
fbe740
index c3554ac101..7f77ab9fce 100644
fbe740
--- a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-pmem.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-pmem.x86_64-latest.args
fbe740
@@ -15,7 +15,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
fbe740
 -machine pc,accel=tcg,usb=off,dump-guest-core=off,nvdimm=on \
fbe740
 -m size=219136k,slots=16,maxmem=1099511627776k \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 2,sockets=2,cores=1,threads=1 \
fbe740
+-smp 2,sockets=2,dies=1,cores=1,threads=1 \
fbe740
 -numa node,nodeid=0,cpus=0-1,mem=214 \
fbe740
 -object memory-backend-file,id=memnvdimm0,prealloc=yes,mem-path=/tmp/nvdimm,\
fbe740
 share=no,size=536870912,pmem=on \
fbe740
diff --git a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-readonly.x86_64-latest.args b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-readonly.x86_64-latest.args
fbe740
index e1d3fc57a4..631835a380 100644
fbe740
--- a/tests/qemuxml2argvdata/memory-hotplug-nvdimm-readonly.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-readonly.x86_64-latest.args
fbe740
@@ -15,7 +15,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
fbe740
 -machine pc,accel=tcg,usb=off,dump-guest-core=off,nvdimm=on \
fbe740
 -m size=219136k,slots=16,maxmem=1099511627776k \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 2,sockets=2,cores=1,threads=1 \
fbe740
+-smp 2,sockets=2,dies=1,cores=1,threads=1 \
fbe740
 -numa node,nodeid=0,cpus=0-1,mem=214 \
fbe740
 -object memory-backend-file,id=memnvdimm0,prealloc=yes,mem-path=/tmp/nvdimm,\
fbe740
 share=no,size=536870912 \
fbe740
diff --git a/tests/qemuxml2argvdata/memory-hotplug-nvdimm.x86_64-latest.args b/tests/qemuxml2argvdata/memory-hotplug-nvdimm.x86_64-latest.args
fbe740
index dc6ddd3a0e..48221a5526 100644
fbe740
--- a/tests/qemuxml2argvdata/memory-hotplug-nvdimm.x86_64-latest.args
fbe740
+++ b/tests/qemuxml2argvdata/memory-hotplug-nvdimm.x86_64-latest.args
fbe740
@@ -15,7 +15,7 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
fbe740
 -machine pc,accel=tcg,usb=off,dump-guest-core=off,nvdimm=on \
fbe740
 -m size=1048576k,slots=16,maxmem=1099511627776k \
fbe740
 -overcommit mem-lock=off \
fbe740
--smp 2,sockets=2,cores=1,threads=1 \
fbe740
+-smp 2,sockets=2,dies=1,cores=1,threads=1 \
fbe740
 -numa node,nodeid=0,cpus=0-1,mem=1024 \
fbe740
 -object memory-backend-file,id=memnvdimm0,prealloc=yes,mem-path=/tmp/nvdimm,\
fbe740
 size=536870912 \
fbe740
diff --git a/tests/qemuxml2argvdata/smp-dies.args b/tests/qemuxml2argvdata/smp-dies.args
fbe740
new file mode 100644
fbe740
index 0000000000..632e9d8e34
fbe740
--- /dev/null
fbe740
+++ b/tests/qemuxml2argvdata/smp-dies.args
fbe740
@@ -0,0 +1,29 @@
fbe740
+LC_ALL=C \
fbe740
+PATH=/bin \
fbe740
+HOME=/tmp/lib/domain--1-QEMUGuest1 \
fbe740
+USER=test \
fbe740
+LOGNAME=test \
fbe740
+XDG_DATA_HOME=/tmp/lib/domain--1-QEMUGuest1/.local/share \
fbe740
+XDG_CACHE_HOME=/tmp/lib/domain--1-QEMUGuest1/.cache \
fbe740
+XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \
fbe740
+QEMU_AUDIO_DRV=none \
fbe740
+/usr/bin/qemu-system-i386 \
fbe740
+-name QEMUGuest1 \
fbe740
+-S \
fbe740
+-machine pc,accel=tcg,usb=off,dump-guest-core=off \
fbe740
+-m 214 \
fbe740
+-realtime mlock=off \
fbe740
+-smp 1,maxcpus=4,sockets=2,dies=2,cores=1,threads=1 \
fbe740
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
fbe740
+-display none \
fbe740
+-no-user-config \
fbe740
+-nodefaults \
fbe740
+-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\
fbe740
+server,nowait \
fbe740
+-mon chardev=charmonitor,id=monitor,mode=control \
fbe740
+-rtc base=utc \
fbe740
+-no-shutdown \
fbe740
+-no-acpi \
fbe740
+-usb \
fbe740
+-drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \
fbe740
+-device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1
fbe740
diff --git a/tests/qemuxml2argvdata/smp-dies.xml b/tests/qemuxml2argvdata/smp-dies.xml
fbe740
new file mode 100644
fbe740
index 0000000000..caadaef8b5
fbe740
--- /dev/null
fbe740
+++ b/tests/qemuxml2argvdata/smp-dies.xml
fbe740
@@ -0,0 +1,33 @@
fbe740
+<domain type='qemu'>
fbe740
+  <name>QEMUGuest1</name>
fbe740
+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
fbe740
+  <memory unit='KiB'>219136</memory>
fbe740
+  <currentMemory unit='KiB'>219136</currentMemory>
fbe740
+  <vcpu placement='static' current='1'>4</vcpu>
fbe740
+  <os>
fbe740
+    <type arch='i686' machine='pc'>hvm</type>
fbe740
+    <boot dev='hd'/>
fbe740
+  </os>
fbe740
+  <cpu>
fbe740
+    <topology sockets='2' dies='2' cores='1' threads='1'/>
fbe740
+  </cpu>
fbe740
+  <clock offset='utc'/>
fbe740
+  <on_poweroff>destroy</on_poweroff>
fbe740
+  <on_reboot>restart</on_reboot>
fbe740
+  <on_crash>destroy</on_crash>
fbe740
+  <devices>
fbe740
+    <emulator>/usr/bin/qemu-system-i386</emulator>
fbe740
+    <disk type='block' device='disk'>
fbe740
+      <driver name='qemu' type='raw'/>
fbe740
+      <source dev='/dev/HostVG/QEMUGuest1'/>
fbe740
+      <target dev='hda' bus='ide'/>
fbe740
+      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
fbe740
+    </disk>
fbe740
+    <controller type='usb' index='0'/>
fbe740
+    <controller type='ide' index='0'/>
fbe740
+    <controller type='pci' index='0' model='pci-root'/>
fbe740
+    <input type='mouse' bus='ps2'/>
fbe740
+    <input type='keyboard' bus='ps2'/>
fbe740
+    <memballoon model='none'/>
fbe740
+  </devices>
fbe740
+</domain>
fbe740
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
fbe740
index 58b4deefc6..b923590930 100644
fbe740
--- a/tests/qemuxml2argvtest.c
fbe740
+++ b/tests/qemuxml2argvtest.c
fbe740
@@ -1689,6 +1689,7 @@ mymain(void)
fbe740
     DO_TEST("qemu-ns-alt", NONE);
fbe740
 
fbe740
     DO_TEST("smp", NONE);
fbe740
+    DO_TEST("smp-dies", QEMU_CAPS_SMP_DIES);
fbe740
 
fbe740
     DO_TEST("iothreads", QEMU_CAPS_OBJECT_IOTHREAD);
fbe740
     DO_TEST("iothreads-ids", QEMU_CAPS_OBJECT_IOTHREAD);
fbe740
-- 
fbe740
2.25.0
fbe740