99cbc7
From f0ca7633386d603fb49f6445af3bfce464310887 Mon Sep 17 00:00:00 2001
99cbc7
Message-Id: <f0ca7633386d603fb49f6445af3bfce464310887@dist-git>
99cbc7
From: Jiri Denemark <jdenemar@redhat.com>
99cbc7
Date: Thu, 4 Apr 2019 11:16:16 +0200
99cbc7
Subject: [PATCH] qemu: Set job statsType for external memory snapshot
99cbc7
99cbc7
Any job which is able to provide statistics that can be queried via
99cbc7
virDomainGetJob{Stats,Info} has to set an appropriate statsType.
99cbc7
99cbc7
Without a proper statsType qemuDomainJobInfoToParams and
99cbc7
qemuDomainJobInfoToInfo have no idea what statistics should be sent to
99cbc7
the API caller.
99cbc7
99cbc7
https://bugzilla.redhat.com/show_bug.cgi?id=1688774
99cbc7
99cbc7
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
99cbc7
Reviewed-by: Erik Skultety <eskultet@redhat.com>
99cbc7
(cherry picked from commit 1c2a9260e865af8ad7dde9cdd21515800d1864e7)
99cbc7
99cbc7
https://bugzilla.redhat.com/show_bug.cgi?id=1690703
99cbc7
99cbc7
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
99cbc7
Message-Id: <0c6c01d9917a35259f5f6aabf39483ff2bde6461.1554369361.git.jdenemar@redhat.com>
99cbc7
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
99cbc7
---
99cbc7
 src/qemu/qemu_driver.c | 2 ++
99cbc7
 1 file changed, 2 insertions(+)
99cbc7
99cbc7
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
99cbc7
index 99d0dad911..6ab1aa28c5 100644
99cbc7
--- a/src/qemu/qemu_driver.c
99cbc7
+++ b/src/qemu/qemu_driver.c
99cbc7
@@ -15230,6 +15230,8 @@ qemuDomainSnapshotCreateActiveExternal(virQEMUDriverPtr driver,
99cbc7
         if (!qemuMigrationSrcIsAllowed(driver, vm, false, 0))
99cbc7
             goto cleanup;
99cbc7
 
99cbc7
+        priv->job.current->statsType = QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP;
99cbc7
+
99cbc7
         /* allow the migration job to be cancelled or the domain to be paused */
99cbc7
         qemuDomainObjSetAsyncJobMask(vm, (QEMU_JOB_DEFAULT_MASK |
99cbc7
                                           JOB_MASK(QEMU_JOB_SUSPEND) |
99cbc7
-- 
99cbc7
2.21.0
99cbc7