|
 |
6d3351 |
From ec386f59f68c4e66bb41f293f8c7f4e023cae9e0 Mon Sep 17 00:00:00 2001
|
|
|
6d3351 |
Message-Id: <ec386f59f68c4e66bb41f293f8c7f4e023cae9e0@dist-git>
|
|
|
6d3351 |
From: Erik Skultety <eskultet@redhat.com>
|
|
|
6d3351 |
Date: Thu, 11 May 2017 17:05:24 +0200
|
|
|
6d3351 |
Subject: [PATCH] qemu: Provide a much clearer message on device hot-plug
|
|
|
6d3351 |
|
|
|
6d3351 |
Adjust the current message to make it clear, that it is the hotplug
|
|
|
6d3351 |
operation that is unsupported with the given host device type.
|
|
|
6d3351 |
|
|
|
6d3351 |
https://bugzilla.redhat.com/show_bug.cgi?id=1450072
|
|
|
6d3351 |
|
|
|
6d3351 |
Signed-off-by: Erik Skultety <eskultet@redhat.com>
|
|
|
6d3351 |
(cherry picked from commit f4829df9aeb54d246ee9a816921a78e268ba7701)
|
|
|
6d3351 |
Signed-off-by: Erik Skultety <eskultet@redhat.com>
|
|
|
6d3351 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
6d3351 |
---
|
|
|
6d3351 |
src/qemu/qemu_hotplug.c | 8 ++++----
|
|
|
6d3351 |
1 file changed, 4 insertions(+), 4 deletions(-)
|
|
|
6d3351 |
|
|
|
6d3351 |
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
|
|
|
6d3351 |
index 120bcdc62..6e5678f16 100644
|
|
|
6d3351 |
--- a/src/qemu/qemu_hotplug.c
|
|
|
6d3351 |
+++ b/src/qemu/qemu_hotplug.c
|
|
|
6d3351 |
@@ -2694,7 +2694,7 @@ qemuDomainAttachHostDevice(virConnectPtr conn,
|
|
|
6d3351 |
{
|
|
|
6d3351 |
if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {
|
|
|
6d3351 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
6d3351 |
- _("hostdev mode '%s' not supported"),
|
|
|
6d3351 |
+ _("hotplug is not supported for hostdev mode '%s'"),
|
|
|
6d3351 |
virDomainHostdevModeTypeToString(hostdev->mode));
|
|
|
6d3351 |
return -1;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
@@ -2725,7 +2725,7 @@ qemuDomainAttachHostDevice(virConnectPtr conn,
|
|
|
6d3351 |
|
|
|
6d3351 |
default:
|
|
|
6d3351 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
6d3351 |
- _("hostdev subsys type '%s' not supported"),
|
|
|
6d3351 |
+ _("hotplug is not supported for hostdev subsys type '%s'"),
|
|
|
6d3351 |
virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type));
|
|
|
6d3351 |
goto error;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
@@ -4840,7 +4840,7 @@ qemuDomainDetachThisHostDevice(virQEMUDriverPtr driver,
|
|
|
6d3351 |
break;
|
|
|
6d3351 |
default:
|
|
|
6d3351 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
6d3351 |
- _("hostdev subsys type '%s' not supported"),
|
|
|
6d3351 |
+ _("hot unplug is not supported for hostdev subsys type '%s'"),
|
|
|
6d3351 |
virDomainHostdevSubsysTypeToString(detach->source.subsys.type));
|
|
|
6d3351 |
return -1;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
@@ -4872,7 +4872,7 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver,
|
|
|
6d3351 |
|
|
|
6d3351 |
if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {
|
|
|
6d3351 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
6d3351 |
- _("hostdev mode '%s' not supported"),
|
|
|
6d3351 |
+ _("hot unplug is not supported for hostdev mode '%s'"),
|
|
|
6d3351 |
virDomainHostdevModeTypeToString(hostdev->mode));
|
|
|
6d3351 |
return -1;
|
|
|
6d3351 |
}
|
|
|
6d3351 |
--
|
|
|
6d3351 |
2.13.0
|
|
|
6d3351 |
|