|
 |
fbe740 |
From 3959e3ef365e95ee4f5e68eb1ab189d6e8cb189d Mon Sep 17 00:00:00 2001
|
|
|
fbe740 |
Message-Id: <3959e3ef365e95ee4f5e68eb1ab189d6e8cb189d@dist-git>
|
|
|
fbe740 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Date: Tue, 4 Feb 2020 15:07:38 +0100
|
|
|
fbe740 |
Subject: [PATCH] qemu: Fix value of 'device' argument for blockdev-mirror
|
|
|
fbe740 |
MIME-Version: 1.0
|
|
|
fbe740 |
Content-Type: text/plain; charset=UTF-8
|
|
|
fbe740 |
Content-Transfer-Encoding: 8bit
|
|
|
fbe740 |
|
|
|
fbe740 |
When using blockdev configurations the 'device' argument of
|
|
|
fbe740 |
'blockdev-mirror' must correspond to the topmost node in the block node
|
|
|
fbe740 |
graph. Libvirt didn't do this properly in case when 'copy_on_read'
|
|
|
fbe740 |
option was enabled on the disk.
|
|
|
fbe740 |
|
|
|
fbe740 |
Use qemuDomainDiskGetTopNodename to fix it for the blockdev-mirror calls
|
|
|
fbe740 |
in qemuDomainBlockCopy and the non-shared-storage migration.
|
|
|
fbe740 |
|
|
|
fbe740 |
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
fbe740 |
(cherry picked from commit e3137539a9c4af25ab085506d5467ec0847b0ecc)
|
|
|
fbe740 |
|
|
|
fbe740 |
https://bugzilla.redhat.com/show_bug.cgi?id=1792195
|
|
|
fbe740 |
Message-Id: <1b3e7edbec684588424e78ed5009bfcb0ce7e183.1580824112.git.pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
fbe740 |
---
|
|
|
fbe740 |
src/qemu/qemu_driver.c | 2 +-
|
|
|
fbe740 |
src/qemu/qemu_migration.c | 2 +-
|
|
|
fbe740 |
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
fbe740 |
|
|
|
fbe740 |
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
|
|
|
fbe740 |
index 83f24d7231..6a209ccb75 100644
|
|
|
fbe740 |
--- a/src/qemu/qemu_driver.c
|
|
|
fbe740 |
+++ b/src/qemu/qemu_driver.c
|
|
|
fbe740 |
@@ -18388,7 +18388,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm,
|
|
|
fbe740 |
|
|
|
fbe740 |
if (blockdev) {
|
|
|
fbe740 |
ret = qemuMonitorBlockdevMirror(priv->mon, job->name, true,
|
|
|
fbe740 |
- disk->src->nodeformat,
|
|
|
fbe740 |
+ qemuDomainDiskGetTopNodename(disk),
|
|
|
fbe740 |
mirror->nodeformat, bandwidth,
|
|
|
fbe740 |
granularity, buf_size, mirror_shallow);
|
|
|
fbe740 |
} else {
|
|
|
fbe740 |
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
|
|
|
fbe740 |
index b56ccbdc3c..03f058051d 100644
|
|
|
fbe740 |
--- a/src/qemu/qemu_migration.c
|
|
|
fbe740 |
+++ b/src/qemu/qemu_migration.c
|
|
|
fbe740 |
@@ -931,7 +931,7 @@ qemuMigrationSrcNBDStorageCopyOne(virQEMUDriverPtr driver,
|
|
|
fbe740 |
|
|
|
fbe740 |
if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV)) {
|
|
|
fbe740 |
jobname = diskAlias;
|
|
|
fbe740 |
- sourcename = disk->src->nodeformat;
|
|
|
fbe740 |
+ sourcename = qemuDomainDiskGetTopNodename(disk);
|
|
|
fbe740 |
persistjob = true;
|
|
|
fbe740 |
} else {
|
|
|
fbe740 |
jobname = NULL;
|
|
|
fbe740 |
--
|
|
|
fbe740 |
2.25.0
|
|
|
fbe740 |
|