|
 |
397dc2 |
From a1af99a1129058f2aa312e3c9d125f5bc7693912 Mon Sep 17 00:00:00 2001
|
|
|
397dc2 |
Message-Id: <a1af99a1129058f2aa312e3c9d125f5bc7693912@dist-git>
|
|
|
397dc2 |
From: Michal Privoznik <mprivozn@redhat.com>
|
|
|
397dc2 |
Date: Wed, 7 Oct 2020 18:45:37 +0200
|
|
|
397dc2 |
Subject: [PATCH] numa_conf: Make virDomainNumaSetNodeCpumask() return void
|
|
|
397dc2 |
MIME-Version: 1.0
|
|
|
397dc2 |
Content-Type: text/plain; charset=UTF-8
|
|
|
397dc2 |
Content-Transfer-Encoding: 8bit
|
|
|
397dc2 |
|
|
|
397dc2 |
There is only one caller of virDomainNumaSetNodeCpumask() which
|
|
|
397dc2 |
checks for the return value but because the function will return
|
|
|
397dc2 |
NULL iff the @cpumask was NULL in the first place. But in that
|
|
|
397dc2 |
place @cpumask can't be NULL because it was just allocated by
|
|
|
397dc2 |
virBitmapParse().
|
|
|
397dc2 |
|
|
|
397dc2 |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
397dc2 |
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
|
|
|
397dc2 |
(cherry picked from commit 1050c6beb1f2238cd847d93eab17d658720b08e1)
|
|
|
397dc2 |
|
|
|
397dc2 |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1749518
|
|
|
397dc2 |
|
|
|
397dc2 |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
397dc2 |
Message-Id: <8564849f4fc4aaca69eec3d2b7e59d03234ea39f.1602087923.git.mprivozn@redhat.com>
|
|
|
397dc2 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
397dc2 |
---
|
|
|
397dc2 |
src/conf/numa_conf.c | 4 +---
|
|
|
397dc2 |
src/conf/numa_conf.h | 6 +++---
|
|
|
397dc2 |
src/libxl/xen_xl.c | 4 ++--
|
|
|
397dc2 |
3 files changed, 6 insertions(+), 8 deletions(-)
|
|
|
397dc2 |
|
|
|
397dc2 |
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
|
|
|
397dc2 |
index 38fcf9d9aa..c9cc8ac22e 100644
|
|
|
397dc2 |
--- a/src/conf/numa_conf.c
|
|
|
397dc2 |
+++ b/src/conf/numa_conf.c
|
|
|
397dc2 |
@@ -1318,14 +1318,12 @@ virDomainNumaGetNodeCpumask(virDomainNumaPtr numa,
|
|
|
397dc2 |
}
|
|
|
397dc2 |
|
|
|
397dc2 |
|
|
|
397dc2 |
-virBitmapPtr
|
|
|
397dc2 |
+void
|
|
|
397dc2 |
virDomainNumaSetNodeCpumask(virDomainNumaPtr numa,
|
|
|
397dc2 |
size_t node,
|
|
|
397dc2 |
virBitmapPtr cpumask)
|
|
|
397dc2 |
{
|
|
|
397dc2 |
numa->mem_nodes[node].cpumask = cpumask;
|
|
|
397dc2 |
-
|
|
|
397dc2 |
- return numa->mem_nodes[node].cpumask;
|
|
|
397dc2 |
}
|
|
|
397dc2 |
|
|
|
397dc2 |
|
|
|
397dc2 |
diff --git a/src/conf/numa_conf.h b/src/conf/numa_conf.h
|
|
|
397dc2 |
index ce865cbfbb..6808439a7c 100644
|
|
|
397dc2 |
--- a/src/conf/numa_conf.h
|
|
|
397dc2 |
+++ b/src/conf/numa_conf.h
|
|
|
397dc2 |
@@ -156,9 +156,9 @@ size_t virDomainNumaSetNodeDistanceCount(virDomainNumaPtr numa,
|
|
|
397dc2 |
size_t ndistances)
|
|
|
397dc2 |
ATTRIBUTE_NONNULL(1);
|
|
|
397dc2 |
|
|
|
397dc2 |
-virBitmapPtr virDomainNumaSetNodeCpumask(virDomainNumaPtr numa,
|
|
|
397dc2 |
- size_t node,
|
|
|
397dc2 |
- virBitmapPtr cpumask)
|
|
|
397dc2 |
+void virDomainNumaSetNodeCpumask(virDomainNumaPtr numa,
|
|
|
397dc2 |
+ size_t node,
|
|
|
397dc2 |
+ virBitmapPtr cpumask)
|
|
|
397dc2 |
ATTRIBUTE_NONNULL(1);
|
|
|
397dc2 |
|
|
|
397dc2 |
/*
|
|
|
397dc2 |
diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c
|
|
|
397dc2 |
index 91b1825399..edea30a86a 100644
|
|
|
397dc2 |
--- a/src/libxl/xen_xl.c
|
|
|
397dc2 |
+++ b/src/libxl/xen_xl.c
|
|
|
397dc2 |
@@ -508,10 +508,10 @@ xenParseXLVnuma(virConfPtr conf,
|
|
|
397dc2 |
goto cleanup;
|
|
|
397dc2 |
}
|
|
|
397dc2 |
|
|
|
397dc2 |
- if ((virBitmapParse(vtoken, &cpumask, VIR_DOMAIN_CPUMASK_LEN) < 0) ||
|
|
|
397dc2 |
- (virDomainNumaSetNodeCpumask(numa, vnodeCnt, cpumask) == NULL))
|
|
|
397dc2 |
+ if (virBitmapParse(vtoken, &cpumask, VIR_DOMAIN_CPUMASK_LEN) < 0)
|
|
|
397dc2 |
goto cleanup;
|
|
|
397dc2 |
|
|
|
397dc2 |
+ virDomainNumaSetNodeCpumask(numa, vnodeCnt, cpumask);
|
|
|
397dc2 |
vcpus += virBitmapCountBits(cpumask);
|
|
|
397dc2 |
|
|
|
397dc2 |
} else if (STRPREFIX(str, "vdistances")) {
|
|
|
397dc2 |
--
|
|
|
397dc2 |
2.29.2
|
|
|
397dc2 |
|