|
 |
edecca |
From 9996e3dd0e17e3019881e097bc38ac25527cddb1 Mon Sep 17 00:00:00 2001
|
|
|
edecca |
Message-Id: <9996e3dd0e17e3019881e097bc38ac25527cddb1@dist-git>
|
|
|
edecca |
From: Michal Privoznik <mprivozn@redhat.com>
|
|
|
edecca |
Date: Wed, 25 Jul 2018 13:52:55 +0200
|
|
|
edecca |
Subject: [PATCH] domain_nwfilter: Return early if net has no name in
|
|
|
edecca |
virDomainConfNWFilterTeardownImpl
|
|
|
edecca |
MIME-Version: 1.0
|
|
|
edecca |
Content-Type: text/plain; charset=UTF-8
|
|
|
edecca |
Content-Transfer-Encoding: 8bit
|
|
|
edecca |
|
|
|
edecca |
https://bugzilla.redhat.com/show_bug.cgi?id=1607831
|
|
|
edecca |
|
|
|
edecca |
This function is called from various clean up paths (e.g.
|
|
|
edecca |
from qemuBuildInterfaceCommandLine). However, depending on the
|
|
|
edecca |
stage the interface creation process failed at, net->ifname might
|
|
|
edecca |
still be not filled in when control jumps to cleanup label. If
|
|
|
edecca |
that is the case return early (avoiding useless error message
|
|
|
edecca |
produced in virNWFilterBindingLookupByPortDev) as there is no
|
|
|
edecca |
NWFilter to tear down anyway.
|
|
|
edecca |
|
|
|
edecca |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
edecca |
Reviewed-by: Erik Skultety <eskultet@redhat.com>
|
|
|
edecca |
(cherry picked from commit 3087b27cffdd46ad0e953e061d6f3c519aefd5d8)
|
|
|
edecca |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
edecca |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
edecca |
---
|
|
|
edecca |
src/conf/domain_nwfilter.c | 3 +++
|
|
|
edecca |
1 file changed, 3 insertions(+)
|
|
|
edecca |
|
|
|
edecca |
diff --git a/src/conf/domain_nwfilter.c b/src/conf/domain_nwfilter.c
|
|
|
edecca |
index 24b5f42ddd..f39c8a1f9b 100644
|
|
|
edecca |
--- a/src/conf/domain_nwfilter.c
|
|
|
edecca |
+++ b/src/conf/domain_nwfilter.c
|
|
|
edecca |
@@ -133,6 +133,9 @@ virDomainConfNWFilterTeardownImpl(virConnectPtr conn,
|
|
|
edecca |
{
|
|
|
edecca |
virNWFilterBindingPtr binding;
|
|
|
edecca |
|
|
|
edecca |
+ if (!net->ifname)
|
|
|
edecca |
+ return;
|
|
|
edecca |
+
|
|
|
edecca |
binding = virNWFilterBindingLookupByPortDev(conn, net->ifname);
|
|
|
edecca |
if (!binding)
|
|
|
edecca |
return;
|
|
|
edecca |
--
|
|
|
edecca |
2.18.0
|
|
|
edecca |
|