|
 |
99cbc7 |
From 01d4d47593cc3e8c10c37a899b9edb70234c0547 Mon Sep 17 00:00:00 2001
|
|
|
99cbc7 |
Message-Id: <01d4d47593cc3e8c10c37a899b9edb70234c0547@dist-git>
|
|
|
99cbc7 |
From: Michal Privoznik <mprivozn@redhat.com>
|
|
|
99cbc7 |
Date: Wed, 25 Jul 2018 13:52:55 +0200
|
|
|
99cbc7 |
Subject: [PATCH] domain_nwfilter: Return early if net has no name in
|
|
|
99cbc7 |
virDomainConfNWFilterTeardownImpl
|
|
|
99cbc7 |
MIME-Version: 1.0
|
|
|
99cbc7 |
Content-Type: text/plain; charset=UTF-8
|
|
|
99cbc7 |
Content-Transfer-Encoding: 8bit
|
|
|
99cbc7 |
|
|
|
99cbc7 |
https://bugzilla.redhat.com/show_bug.cgi?id=1607831
|
|
|
99cbc7 |
|
|
|
99cbc7 |
This function is called from various clean up paths (e.g.
|
|
|
99cbc7 |
from qemuBuildInterfaceCommandLine). However, depending on the
|
|
|
99cbc7 |
stage the interface creation process failed at, net->ifname might
|
|
|
99cbc7 |
still be not filled in when control jumps to cleanup label. If
|
|
|
99cbc7 |
that is the case return early (avoiding useless error message
|
|
|
99cbc7 |
produced in virNWFilterBindingLookupByPortDev) as there is no
|
|
|
99cbc7 |
NWFilter to tear down anyway.
|
|
|
99cbc7 |
|
|
|
99cbc7 |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
99cbc7 |
Reviewed-by: Erik Skultety <eskultet@redhat.com>
|
|
|
99cbc7 |
(cherry picked from commit 3087b27cffdd46ad0e953e061d6f3c519aefd5d8)
|
|
|
99cbc7 |
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
99cbc7 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
99cbc7 |
---
|
|
|
99cbc7 |
src/conf/domain_nwfilter.c | 3 +++
|
|
|
99cbc7 |
1 file changed, 3 insertions(+)
|
|
|
99cbc7 |
|
|
|
99cbc7 |
diff --git a/src/conf/domain_nwfilter.c b/src/conf/domain_nwfilter.c
|
|
|
99cbc7 |
index 24b5f42ddd..f39c8a1f9b 100644
|
|
|
99cbc7 |
--- a/src/conf/domain_nwfilter.c
|
|
|
99cbc7 |
+++ b/src/conf/domain_nwfilter.c
|
|
|
99cbc7 |
@@ -133,6 +133,9 @@ virDomainConfNWFilterTeardownImpl(virConnectPtr conn,
|
|
|
99cbc7 |
{
|
|
|
99cbc7 |
virNWFilterBindingPtr binding;
|
|
|
99cbc7 |
|
|
|
99cbc7 |
+ if (!net->ifname)
|
|
|
99cbc7 |
+ return;
|
|
|
99cbc7 |
+
|
|
|
99cbc7 |
binding = virNWFilterBindingLookupByPortDev(conn, net->ifname);
|
|
|
99cbc7 |
if (!binding)
|
|
|
99cbc7 |
return;
|
|
|
99cbc7 |
--
|
|
|
99cbc7 |
2.18.0
|
|
|
99cbc7 |
|