99cbc7
From 3fbdec4eee43aec8501e0e2cb93133b477d4b354 Mon Sep 17 00:00:00 2001
99cbc7
Message-Id: <3fbdec4eee43aec8501e0e2cb93133b477d4b354@dist-git>
99cbc7
From: Peter Krempa <pkrempa@redhat.com>
99cbc7
Date: Thu, 20 Jun 2019 17:45:01 +0200
99cbc7
Subject: [PATCH] docs: snapshot: Encourage people ot use disk 'target' to
99cbc7
 refer to disks
99cbc7
99cbc7
Change the example and add a recommendation to use disk target rather
99cbc7
than path.
99cbc7
99cbc7
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
99cbc7
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
99cbc7
(cherry picked from commit c79ef73c37b1f91d38745cb1197026e702ce42fe)
99cbc7
https: //bugzilla.redhat.com/show_bug.cgi?id=1584682
99cbc7
Message-Id: <bdb8fa41c605bdda49eaf0436f8dc74992c54bd1.1561045343.git.pkrempa@redhat.com>
99cbc7
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
99cbc7
---
99cbc7
 docs/formatsnapshot.html.in | 6 +++---
99cbc7
 1 file changed, 3 insertions(+), 3 deletions(-)
99cbc7
99cbc7
diff --git a/docs/formatsnapshot.html.in b/docs/formatsnapshot.html.in
99cbc7
index fbbecfd242..23f20d7c33 100644
99cbc7
--- a/docs/formatsnapshot.html.in
99cbc7
+++ b/docs/formatsnapshot.html.in
99cbc7
@@ -143,8 +143,8 @@
99cbc7
           
This sub-element describes the snapshot properties of a
99cbc7
             specific disk.  The attribute name is
99cbc7
             mandatory, and must match either the <target
99cbc7
-            dev='name'/> or an unambiguous <source
99cbc7
-            file='name'/> of one of
99cbc7
+            dev='name'/> (recommended) or an unambiguous
99cbc7
+            <source file='name'/> of one of
99cbc7
             the disk
99cbc7
             devices specified for the domain at the time of the
99cbc7
             snapshot.  The attribute snapshot is
99cbc7
@@ -251,7 +251,7 @@
99cbc7
 <domainsnapshot>
99cbc7
   <description>Snapshot of OS install and updates</description>
99cbc7
   <disks>
99cbc7
-    <disk name='/path/to/old'>
99cbc7
+    <disk name='vda'>
99cbc7
       <source file='/path/to/new'/>
99cbc7
     </disk>
99cbc7
     <disk name='vdb' snapshot='no'/>
99cbc7
-- 
99cbc7
2.22.1
99cbc7