From c9aea427cc39190d178c584548b71e099a66df71 Mon Sep 17 00:00:00 2001

Message-Id: <c9aea427cc39190d178c584548b71e099a66df71@dist-git>

From: Martin Kletzander <mkletzan@redhat.com>

Date: Fri, 3 Oct 2014 22:54:55 +0200

Subject: [PATCH] docs, conf, schema: add support for shmem device

https://bugzilla.redhat.com/show_bug.cgi?id=1126991

This patch adds parsing/formatting code as well as documentation for

shared memory devices.  This will currently be only accessible in QEMU

using it's ivshmem device, but is designed as generic as possible to

allow future expansion for other hypervisors.

In the devices section in the domain XML users may specify:

- For shmem device using a server:

 <shmem name='shmem0'>

   <server path='/tmp/socket-ivshmem0'/>

   <size unit='M'>32</size>

   <msi vectors='32' ioeventfd='on'/>

 </shmem>

- For ivshmem device not using an ivshmem server:

 <shmem name='shmem1'>

   <size unit='M'>32</size>

 </shmem>

Most of the configuration is made optional so it also allows

specifications like:

 <shmem name='shmem2'>

   <server/>

 </shmem>

Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>

(cherry picked from commit 540a84ec89c1634d5e17ba7b8d96049c960bb1b4)

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

---

 docs/formatdomain.html.in                          |  52 ++++++

 docs/schemas/domaincommon.rng                      |  39 +++++

 src/conf/domain_conf.c                             | 184 ++++++++++++++++++++-

 src/conf/domain_conf.h                             |  24 +++

 src/qemu/qemu_hotplug.c                            |   1 +

 .../qemuxml2argv-shmem-msi-only.xml                |  24 +++

 tests/qemuxml2argvdata/qemuxml2argv-shmem.xml      |  51 ++++++

 tests/qemuxml2argvtest.c                           |   2 +

 tests/qemuxml2xmltest.c                            |   1 +

 9 files changed, 377 insertions(+), 1 deletion(-)

 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem-msi-only.xml

 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem.xml

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in

index ee00eca..dac81ab 100644

--- a/docs/formatdomain.html.in

+++ b/docs/formatdomain.html.in

@@ -5582,6 +5582,58 @@ qemu-kvm -net nic,model=? /dev/null

+  
Shared memory device

+

+    

+      A shared memory device allows to share a memory region between

+      different virtual machines and the host.

+      Since 1.2.9, QEMU and KVM only

+    

+

+

+  ...

+  <devices>

+    <shmem name='my_shmem0'>

+      <size unit='M'>4</size>

+    </shmem>

+    <shmem name='shmem_server'>

+      <size unit='M'>2</size>

+      <server path='/tmp/socket-shmem'/>

+      <msi vectors='32' ioeventfd='on'/>

+    </shmem>

+  </devices>

+  ...

+

+

+  

+    
shmem

+    

+      The shmem element has one mandatory attribute,

+      name to identify the shared memory.

+    

+    
size

+    

+      The optional size element specifies the size of the shared

+      memory. This must be power of 2 and greater than or equal to 1 MiB.

+    

+    
server

+    

+      The optional server element can be used to configure a server

+      socket the device is supposed to connect to.  The optional

+      path attribute specifies the path to the unix socket and

+      defaults to /var/lib/libvirt/shmem/$shmem-$name-sock.

+    

+    
msi

+    

+      The optional msi element enables/disables (values "on"/"off",

+      respectively) MSI interrupts. This option can currently be used only

+      together with the server element. The vectors

+      attribute can be used to specify the number of interrupt

+      vectors. The ioeventd attribute enables/disables (values

+      "on"/"off", respectively) ioeventfd.

+    

+  

+

     
Security label

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng

index e561486..8d96daa 100644

--- a/docs/schemas/domaincommon.rng

+++ b/docs/schemas/domaincommon.rng

@@ -3274,6 +3274,44 @@

       </optional>

     </element>

   </define>

+

+  <define name="shmem">

+    <element name="shmem">

+      <attribute name="name"/>

+      <interleave>

+        <optional>

+          <element name="size">

+            <ref name="scaledInteger"/>

+          </element>

+        </optional>

+        <optional>

+          <element name="server">

+            <optional>

+              <attribute name="path">

+                <ref name="absFilePath"/>

+              </attribute>

+            </optional>

+          </element>

+        </optional>

+        <optional>

+          <element name="msi">

+            <optional>

+              <ref name="ioeventfd"/>

+            </optional>

+            <optional>

+              <attribute name="vectors">

+                <ref name="unsignedInt"/>

+              </attribute>

+            </optional>

+          </element>

+        </optional>

+        <optional>

+          <ref name="address"/>

+        </optional>

+      </interleave>

+    </element>

+  </define>

+

   <define name="memballoon">

     <element name="memballoon">

       <attribute name="model">

@@ -3860,6 +3898,7 @@

             <ref name="redirfilter"/>

             <ref name="rng"/>

             <ref name="tpm"/>

+            <ref name="shmem"/>

           </choice>

         </zeroOrMore>

         <optional>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

index 40626b8..2768660 100644

--- a/src/conf/domain_conf.c

+++ b/src/conf/domain_conf.c

@@ -252,7 +252,8 @@ VIR_ENUM_IMPL(virDomainDevice, VIR_DOMAIN_DEVICE_LAST,

               "chr",

               "memballoon",

               "nvram",

-              "rng")

+              "rng",

+              "shmem")

 VIR_ENUM_IMPL(virDomainDeviceAddress, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_LAST,

               "none",

@@ -1717,6 +1718,17 @@ void virDomainWatchdogDefFree(virDomainWatchdogDefPtr def)

     VIR_FREE(def);

 }

+void virDomainShmemDefFree(virDomainShmemDefPtr def)

+{

+    if (!def)

+        return;

+

+    virDomainDeviceInfoClear(&def->info);

+    VIR_FREE(def->server.path);

+    VIR_FREE(def->name);

+    VIR_FREE(def);

+}

+

 void virDomainVideoDefFree(virDomainVideoDefPtr def)

 {

     if (!def)

@@ -1918,6 +1930,9 @@ void virDomainDeviceDefFree(virDomainDeviceDefPtr def)

     case VIR_DOMAIN_DEVICE_NVRAM:

         virDomainNVRAMDefFree(def->data.nvram);

         break;

+    case VIR_DOMAIN_DEVICE_SHMEM:

+        virDomainShmemDefFree(def->data.shmem);

+        break;

     case VIR_DOMAIN_DEVICE_LAST:

     case VIR_DOMAIN_DEVICE_NONE:

         break;

@@ -2178,6 +2193,10 @@ void virDomainDefFree(virDomainDefPtr def)

     virDomainRedirFilterDefFree(def->redirfilter);

+    for (i = 0; i < def->nshmems; i++)

+        virDomainShmemDefFree(def->shmems[i]);

+    VIR_FREE(def->shmems);

+

     if (def->namespaceData && def->ns.free)

         (def->ns.free)(def->namespaceData);

@@ -2610,6 +2629,8 @@ virDomainDeviceGetInfo(virDomainDeviceDefPtr device)

         return &device->data.memballoon->info;

     case VIR_DOMAIN_DEVICE_NVRAM:

         return &device->data.nvram->info;

+    case VIR_DOMAIN_DEVICE_SHMEM:

+        return &device->data.shmem->info;

     case VIR_DOMAIN_DEVICE_RNG:

         return &device->data.rng->info;

@@ -2825,6 +2846,12 @@ virDomainDeviceInfoIterateInternal(virDomainDefPtr def,

         if (cb(def, &device, &def->hubs[i]->info, opaque) < 0)

             return -1;

     }

+    device.type = VIR_DOMAIN_DEVICE_SHMEM;

+    for (i = 0; i < def->nshmems; i++) {

+        device.data.shmem = def->shmems[i];

+        if (cb(def, &device, &def->shmems[i]->info, opaque) < 0)

+            return -1;

+    }

     /* Coverity is not very happy with this - all dead_error_condition */

 #if !STATIC_ANALYSIS

@@ -2853,6 +2880,7 @@ virDomainDeviceInfoIterateInternal(virDomainDefPtr def,

     case VIR_DOMAIN_DEVICE_CHR:

     case VIR_DOMAIN_DEVICE_MEMBALLOON:

     case VIR_DOMAIN_DEVICE_NVRAM:

+    case VIR_DOMAIN_DEVICE_SHMEM:

     case VIR_DOMAIN_DEVICE_LAST:

     case VIR_DOMAIN_DEVICE_RNG:

         break;

@@ -9687,6 +9715,84 @@ virDomainNVRAMDefParseXML(xmlNodePtr node,

     return NULL;

 }

+static virDomainShmemDefPtr

+virDomainShmemDefParseXML(xmlNodePtr node,

+                          xmlXPathContextPtr ctxt,

+                          unsigned int flags)

+{

+    char *tmp = NULL;

+    virDomainShmemDefPtr def = NULL;

+    virDomainShmemDefPtr ret = NULL;

+    xmlNodePtr msi = NULL;

+    xmlNodePtr save = ctxt->node;

+    xmlNodePtr server = NULL;

+

+

+    if (VIR_ALLOC(def) < 0)

+        return NULL;

+

+    ctxt->node = node;

+

+    if (!(def->name = virXMLPropString(node, "name"))) {

+        virReportError(VIR_ERR_XML_ERROR, "%s",

+                       _("shmem element must contain 'name' attribute"));

+        goto cleanup;

+    }

+

+    if (virDomainParseScaledValue("./size[1]", ctxt, &def->size,

+                                    1, ULLONG_MAX, false) < 0)

+        goto cleanup;

+

+    if ((server = virXPathNode("./server", ctxt))) {

+        def->server.enabled = true;

+

+        if ((tmp = virXMLPropString(server, "path")))

+            def->server.path = virFileSanitizePath(tmp);

+        VIR_FREE(tmp);

+    }

+

+    if ((msi = virXPathNode("./msi", ctxt))) {

+        def->msi.enabled = true;

+

+        if ((tmp = virXMLPropString(msi, "vectors")) &&

+            virStrToLong_uip(tmp, NULL, 0, &def->msi.vectors) < 0) {

+            virReportError(VIR_ERR_XML_ERROR,

+                           _("invalid number of vectors for shmem: '%s'"),

+                           tmp);

+            goto cleanup;

+        }

+        VIR_FREE(tmp);

+

+        if ((tmp = virXMLPropString(msi, "ioeventfd")) &&

+            (def->msi.ioeventfd = virTristateSwitchTypeFromString(tmp)) <= 0) {

+            virReportError(VIR_ERR_XML_ERROR,

+                           _("invalid msi ioeventfd setting for shmem: '%s'"),

+                           tmp);

+            goto cleanup;

+        }

+        VIR_FREE(tmp);

+    }

+

+    /* msi option is only relevant with a server */

+    if (def->msi.enabled && !def->server.enabled) {

+        virReportError(VIR_ERR_XML_ERROR, "%s",

+                       _("msi option is only supported with a server"));

+        goto cleanup;

+    }

+

+    if (virDomainDeviceInfoParseXML(node, NULL, &def->info, flags) < 0)

+        goto cleanup;

+

+

+    ret = def;

+    def = NULL;

+ cleanup:

+    ctxt->node = save;

+    VIR_FREE(tmp);

+    virDomainShmemDefFree(def);

+    return ret;

+}

+

 static virSysinfoDefPtr

 virSysinfoParseXML(xmlNodePtr node,

                   xmlXPathContextPtr ctxt,

@@ -10543,6 +10649,10 @@ virDomainDeviceDefParse(const char *xmlStr,

         if (!(dev->data.nvram = virDomainNVRAMDefParseXML(node, flags)))

             goto error;

         break;

+    case VIR_DOMAIN_DEVICE_SHMEM:

+        if (!(dev->data.shmem = virDomainShmemDefParseXML(node, ctxt, flags)))

+            goto error;

+        break;

     case VIR_DOMAIN_DEVICE_NONE:

     case VIR_DOMAIN_DEVICE_LAST:

         break;

@@ -13630,6 +13740,25 @@ virDomainDefParseXML(xmlDocPtr xml,

         VIR_FREE(nodes);

     }

+    /* analysis of the shmem devices */

+    if ((n = virXPathNodeSet("./devices/shmem", ctxt, &nodes)) < 0) {

+        goto error;

+    }

+    if (n && VIR_ALLOC_N(def->shmems, n) < 0)

+        goto error;

+

+    node = ctxt->node;

+    for (i = 0; i < n; i++) {

+        virDomainShmemDefPtr shmem;

+        ctxt->node = nodes[i];

+        shmem = virDomainShmemDefParseXML(nodes[i], ctxt, flags);

+        if (!shmem)

+            goto error;

+

+        def->shmems[def->nshmems++] = shmem;

+    }

+    ctxt->node = node;

+    VIR_FREE(nodes);

     /* analysis of the user namespace mapping */

     if ((n = virXPathNodeSet("./idmap/uid", ctxt, &nodes)) < 0)

@@ -17419,6 +17548,54 @@ static int virDomainPanicDefFormat(virBufferPtr buf,

 }

 static int

+virDomainShmemDefFormat(virBufferPtr buf,

+                        virDomainShmemDefPtr def,

+                        unsigned int flags)

+{

+    virBufferAsprintf(buf, "<shmem name='%s'", def->name);

+

+    if (!def->size &&

+        !def->server.enabled &&

+        !def->msi.enabled &&

+        !virDomainDeviceInfoIsSet(&def->info, flags)) {

+        virBufferAddLit(buf, "/>\n");

+        return 0;

+    } else {

+        virBufferAddLit(buf, ">\n");

+    }

+

+    virBufferAdjustIndent(buf, 2);

+

+    if (def->size)

+        virBufferAsprintf(buf, "<size unit='M'>%llu</size>\n",

+                          VIR_DIV_UP(def->size, 1024 * 1024));

+

+    if (def->server.enabled) {

+        virBufferAddLit(buf, "

+        virBufferEscapeString(buf, " path='%s'", def->server.path);

+        virBufferAddLit(buf, "/>\n");

+    }

+

+    if (def->msi.enabled) {

+        virBufferAddLit(buf, "

+        if (def->msi.vectors)

+            virBufferAsprintf(buf, " vectors='%u'", def->msi.vectors);

+        if (def->msi.ioeventfd)

+            virBufferAsprintf(buf, " ioeventfd='%s'",

+                              virTristateSwitchTypeToString(def->msi.ioeventfd));

+        virBufferAddLit(buf, "/>\n");

+    }

+

+    if (virDomainDeviceInfoFormat(buf, &def->info, flags) < 0)

+        return -1;

+

+    virBufferAdjustIndent(buf, -2);

+    virBufferAddLit(buf, "</shmem>\n");

+

+    return 0;

+}

+

+static int

 virDomainRNGDefFormat(virBufferPtr buf,

                       virDomainRNGDefPtr def,

                       unsigned int flags)

@@ -19038,6 +19215,10 @@ virDomainDefFormatInternal(virDomainDefPtr def,

         virDomainPanicDefFormat(buf, def->panic) < 0)

         goto error;

+    for (n = 0; n < def->nshmems; n++)

+        if (virDomainShmemDefFormat(buf, def->shmems[n], flags) < 0)

+            goto error;

+

     virBufferAdjustIndent(buf, -2);

     virBufferAddLit(buf, "</devices>\n");

@@ -20403,6 +20584,7 @@ virDomainDeviceDefCopy(virDomainDeviceDefPtr src,

     case VIR_DOMAIN_DEVICE_SMARTCARD:

     case VIR_DOMAIN_DEVICE_MEMBALLOON:

     case VIR_DOMAIN_DEVICE_NVRAM:

+    case VIR_DOMAIN_DEVICE_SHMEM:

     case VIR_DOMAIN_DEVICE_LAST:

         virReportError(VIR_ERR_INTERNAL_ERROR,

                        _("Copying definition of '%d' type "

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h

index b981020..9da6d2d 100644

--- a/src/conf/domain_conf.h

+++ b/src/conf/domain_conf.h

@@ -136,6 +136,9 @@ typedef virDomainPanicDef *virDomainPanicDefPtr;

 typedef struct _virDomainChrSourceDef virDomainChrSourceDef;

 typedef virDomainChrSourceDef *virDomainChrSourceDefPtr;

+typedef struct _virDomainShmemDef virDomainShmemDef;

+typedef virDomainShmemDef *virDomainShmemDefPtr;

+

 /* Flags for the 'type' field in virDomainDeviceDef */

 typedef enum {

     VIR_DOMAIN_DEVICE_NONE = 0,

@@ -157,6 +160,7 @@ typedef enum {

     VIR_DOMAIN_DEVICE_MEMBALLOON,

     VIR_DOMAIN_DEVICE_NVRAM,

     VIR_DOMAIN_DEVICE_RNG,

+    VIR_DOMAIN_DEVICE_SHMEM,

     VIR_DOMAIN_DEVICE_LAST

 } virDomainDeviceType;

@@ -184,6 +188,7 @@ struct _virDomainDeviceDef {

         virDomainMemballoonDefPtr memballoon;

         virDomainNVRAMDefPtr nvram;

         virDomainRNGDefPtr rng;

+        virDomainShmemDefPtr shmem;

     } data;

 };

@@ -1507,6 +1512,21 @@ struct _virDomainNVRAMDef {

     virDomainDeviceInfo info;

 };

+struct _virDomainShmemDef {

+    char *name;

+    unsigned long long size;

+    struct {

+        bool enabled;

+        char *path;

+    } server;

+    struct {

+        bool enabled;

+        unsigned vectors;

+        virTristateSwitch ioeventfd;

+    } msi;

+    virDomainDeviceInfo info;

+};

+

 typedef enum {

     VIR_DOMAIN_SMBIOS_NONE = 0,

     VIR_DOMAIN_SMBIOS_EMULATE,

@@ -2063,6 +2083,9 @@ struct _virDomainDef {

     size_t nrngs;

     virDomainRNGDefPtr *rngs;

+    size_t nshmems;

+    virDomainShmemDefPtr *shmems;

+

     /* Only 1 */

     virDomainWatchdogDefPtr watchdog;

     virDomainMemballoonDefPtr memballoon;

@@ -2260,6 +2283,7 @@ void virDomainHostdevDefFree(virDomainHostdevDefPtr def);

 void virDomainHubDefFree(virDomainHubDefPtr def);

 void virDomainRedirdevDefFree(virDomainRedirdevDefPtr def);

 void virDomainRedirFilterDefFree(virDomainRedirFilterDefPtr def);

+void virDomainShmemDefFree(virDomainShmemDefPtr def);

 void virDomainDeviceDefFree(virDomainDeviceDefPtr def);

 virDomainDeviceDefPtr virDomainDeviceDefCopy(virDomainDeviceDefPtr src,

                                              const virDomainDef *def,

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c

index 33e2dff..8eb2419 100644

--- a/src/qemu/qemu_hotplug.c

+++ b/src/qemu/qemu_hotplug.c

@@ -2858,6 +2858,7 @@ qemuDomainRemoveDevice(virQEMUDriverPtr driver,

     case VIR_DOMAIN_DEVICE_MEMBALLOON:

     case VIR_DOMAIN_DEVICE_NVRAM:

     case VIR_DOMAIN_DEVICE_RNG:

+    case VIR_DOMAIN_DEVICE_SHMEM:

     case VIR_DOMAIN_DEVICE_LAST:

         virReportError(VIR_ERR_OPERATION_UNSUPPORTED,

                        _("don't know how to remove a %s device"),

diff --git a/tests/qemuxml2argvdata/qemuxml2argv-shmem-msi-only.xml b/tests/qemuxml2argvdata/qemuxml2argv-shmem-msi-only.xml

new file mode 100644

index 0000000..d70279c

--- /dev/null

+++ b/tests/qemuxml2argvdata/qemuxml2argv-shmem-msi-only.xml

@@ -0,0 +1,24 @@

+<domain type='qemu'>

+  <name>QEMUGuest1</name>

+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>

+  <memory unit='KiB'>219136</memory>

+  <currentMemory unit='KiB'>219136</currentMemory>

+  <vcpu placement='static'>1</vcpu>

+  <os>

+    <type arch='i686' machine='pc'>hvm</type>

+    <boot dev='hd'/>

+  </os>

+  <clock offset='utc'/>

+  <on_poweroff>destroy</on_poweroff>

+  <on_reboot>restart</on_reboot>

+  <on_crash>destroy</on_crash>

+  <devices>

+    <emulator>/usr/bin/qemu</emulator>

+    <controller type='usb' index='0'/>

+    <controller type='pci' index='0' model='pci-root'/>

+    <memballoon model='none'/>

+    <shmem name='shmem0'>

+      <msi/>

+    </shmem>

+  </devices>

+</domain>

diff --git a/tests/qemuxml2argvdata/qemuxml2argv-shmem.xml b/tests/qemuxml2argvdata/qemuxml2argv-shmem.xml

new file mode 100644

index 0000000..fd79c89

--- /dev/null

+++ b/tests/qemuxml2argvdata/qemuxml2argv-shmem.xml

@@ -0,0 +1,51 @@

+<domain type='qemu'>

+  <name>QEMUGuest1</name>

+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>

+  <memory unit='KiB'>219136</memory>

+  <currentMemory unit='KiB'>219136</currentMemory>

+  <vcpu placement='static'>1</vcpu>

+  <os>

+    <type arch='i686' machine='pc'>hvm</type>

+    <boot dev='hd'/>

+  </os>

+  <clock offset='utc'/>

+  <on_poweroff>destroy</on_poweroff>

+  <on_reboot>restart</on_reboot>

+  <on_crash>destroy</on_crash>

+  <devices>

+    <emulator>/usr/bin/qemu</emulator>

+    <controller type='usb' index='0'/>

+    <controller type='pci' index='0' model='pci-root'/>

+    <memballoon model='none'/>

+    <shmem name='shmem0'/>

+    <shmem name='shmem1'>

+      <size unit='M'>128</size>

+    </shmem>

+    <shmem name='shmem2'>

+      <size unit='M'>256</size>

+    </shmem>

+    <shmem name='shmem3'>

+      <size unit='M'>512</size>

+      <server/>

+    </shmem>

+    <shmem name='shmem4'>

+      <size unit='M'>1024</size>

+      <server path='/tmp/shmem4-sock'/>

+    </shmem>

+    <shmem name='shmem5'>

+      <size unit='M'>2048</size>

+      <server path='/tmp/shmem5-sock'/>

+      <msi ioeventfd='off'/>

+    </shmem>

+    <shmem name='shmem6'>

+      <size unit='M'>4096</size>

+      <server path='/tmp/shmem6-sock'/>

+      <msi vectors='16'/>

+    </shmem>

+    <shmem name='shmem7'>

+      <size unit='M'>8192</size>

+      <server path='/tmp/shmem7-sock'/>

+      <msi vectors='32' ioeventfd='on'/>

+    </shmem>

+  </devices>

+</domain>

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c

index 410540f..ae8bbfc 100644

--- a/tests/qemuxml2argvtest.c

+++ b/tests/qemuxml2argvtest.c

@@ -1463,6 +1463,8 @@ mymain(void)

     DO_TEST("fips-enabled", QEMU_CAPS_ENABLE_FIPS);

+    DO_TEST_PARSE_ERROR("shmem-msi-only", NONE);

+

     virObjectUnref(driver.config);

     virObjectUnref(driver.caps);

     virObjectUnref(driver.xmlopt);

diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c

index 6e71cb2..f29e4ed 100644

--- a/tests/qemuxml2xmltest.c

+++ b/tests/qemuxml2xmltest.c

@@ -403,6 +403,7 @@ mymain(void)

     DO_TEST("bios-nvram");

     DO_TEST("tap-vhost");

+    DO_TEST("shmem");

     virObjectUnref(driver.caps);

     virObjectUnref(driver.xmlopt);

-- 

2.1.2