|
 |
c313de |
From 84ee95b9504d89236078952a44c1a8b7dba148ca Mon Sep 17 00:00:00 2001
|
|
|
c313de |
Message-Id: <84ee95b9504d89236078952a44c1a8b7dba148ca@dist-git>
|
|
|
c313de |
From: Jiri Denemark <jdenemar@redhat.com>
|
|
|
c313de |
Date: Fri, 21 Jun 2019 09:24:58 +0200
|
|
|
c313de |
Subject: [PATCH] cpu_x86: Make sure CPU model names are unique in cpu_map
|
|
|
c313de |
MIME-Version: 1.0
|
|
|
c313de |
Content-Type: text/plain; charset=UTF-8
|
|
|
c313de |
Content-Transfer-Encoding: 8bit
|
|
|
c313de |
|
|
|
c313de |
Having multiple CPU model definitions with the same name could result in
|
|
|
c313de |
unexpected behavior.
|
|
|
c313de |
|
|
|
c313de |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
c313de |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c313de |
(cherry picked from commit 8d7245441a473bc1f73005fd378d4a925870cce6)
|
|
|
c313de |
|
|
|
c313de |
https://bugzilla.redhat.com/show_bug.cgi?id=1686895
|
|
|
c313de |
|
|
|
c313de |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
c313de |
Message-Id: <c5dcc42f39009e8a659acb56b89cc18da1c3b7b8.1561068591.git.jdenemar@redhat.com>
|
|
|
c313de |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c313de |
---
|
|
|
c313de |
src/cpu/cpu_x86.c | 8 +++++++-
|
|
|
c313de |
1 file changed, 7 insertions(+), 1 deletion(-)
|
|
|
c313de |
|
|
|
c313de |
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
|
|
|
c313de |
index 91362198ab..51cb9b7143 100644
|
|
|
c313de |
--- a/src/cpu/cpu_x86.c
|
|
|
c313de |
+++ b/src/cpu/cpu_x86.c
|
|
|
c313de |
@@ -1291,9 +1291,15 @@ x86ModelParse(xmlXPathContextPtr ctxt,
|
|
|
c313de |
void *data)
|
|
|
c313de |
{
|
|
|
c313de |
virCPUx86MapPtr map = data;
|
|
|
c313de |
- virCPUx86ModelPtr model;
|
|
|
c313de |
+ virCPUx86ModelPtr model = NULL;
|
|
|
c313de |
int ret = -1;
|
|
|
c313de |
|
|
|
c313de |
+ if (x86ModelFind(map, name)) {
|
|
|
c313de |
+ virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
c313de |
+ _("Multiple definitions of CPU model '%s'"), name);
|
|
|
c313de |
+ goto cleanup;
|
|
|
c313de |
+ }
|
|
|
c313de |
+
|
|
|
c313de |
if (!(model = x86ModelNew()))
|
|
|
c313de |
goto cleanup;
|
|
|
c313de |
|
|
|
c313de |
--
|
|
|
c313de |
2.22.0
|
|
|
c313de |
|