7548c0
From b91bb231645300a29ab82994a003ba22835ee994 Mon Sep 17 00:00:00 2001
7548c0
Message-Id: <b91bb231645300a29ab82994a003ba22835ee994@dist-git>
7548c0
From: Jiri Denemark <jdenemar@redhat.com>
7548c0
Date: Thu, 8 Oct 2020 18:01:26 +0200
7548c0
Subject: [PATCH] cpu_map: Remove monitor feature from EPYC-Rome
7548c0
MIME-Version: 1.0
7548c0
Content-Type: text/plain; charset=UTF-8
7548c0
Content-Transfer-Encoding: 8bit
7548c0
7548c0
The feature is filtered by KVM and never automatically enabled. So even
7548c0
though QEMU definition of EPYC-Rome contains this feature, the guest
7548c0
won't see it. Also domain capabilities will show it as disabled for KVM
7548c0
domains. Thus the feature should not really be included in our
7548c0
definition of EPYC-Rome.
7548c0
7548c0
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
7548c0
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
7548c0
(cherry picked from commit 3bf6f9fe22dfbd3c1dcc614b31f2f4fe8b71a2f2)
7548c0
7548c0
https://bugzilla.redhat.com/show_bug.cgi?id=1861506
7548c0
7548c0
Conflicts:
7548c0
	tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml
7548c0
	tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml
7548c0
	tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml
7548c0
	tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml
7548c0
	tests/domaincapsdata/qemu_5.1.0.x86_64.xml
7548c0
	tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml
7548c0
	tests/domaincapsdata/qemu_5.2.0.x86_64.xml
7548c0
            - not present downstream
7548c0
7548c0
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
7548c0
Message-Id: <74b9257f49925312b025a99dd934a9613ca295d4.1602172344.git.jdenemar@redhat.com>
7548c0
Reviewed-by: Ján Tomko <jtomko@redhat.com>
7548c0
---
7548c0
 src/cpu_map/x86_EPYC-Rome.xml                              | 1 -
7548c0
 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +
7548c0
 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml  | 1 +
7548c0
 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml  | 1 -
7548c0
 4 files changed, 2 insertions(+), 2 deletions(-)
7548c0
7548c0
diff --git a/src/cpu_map/x86_EPYC-Rome.xml b/src/cpu_map/x86_EPYC-Rome.xml
7548c0
index 99fc015fdd..e54d0a48d8 100644
7548c0
--- a/src/cpu_map/x86_EPYC-Rome.xml
7548c0
+++ b/src/cpu_map/x86_EPYC-Rome.xml
7548c0
@@ -37,7 +37,6 @@
7548c0
     <feature name='misalignsse'/>
7548c0
     <feature name='mmx'/>
7548c0
     <feature name='mmxext'/>
7548c0
-    <feature name='monitor'/>
7548c0
     <feature name='movbe'/>
7548c0
     <feature name='msr'/>
7548c0
     <feature name='mtrr'/>
7548c0
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
7548c0
index cb2caab6f5..6d95b508b2 100644
7548c0
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
7548c0
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
7548c0
@@ -2,6 +2,7 @@
7548c0
   <model fallback='forbid'>EPYC-Rome</model>
7548c0
   <vendor>AMD</vendor>
7548c0
   <feature policy='require' name='ht'/>
7548c0
+  <feature policy='require' name='monitor'/>
7548c0
   <feature policy='require' name='osxsave'/>
7548c0
   <feature policy='require' name='cmt'/>
7548c0
   <feature policy='require' name='xsaves'/>
7548c0
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
7548c0
index b6784f9eba..65eaeabdd0 100644
7548c0
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
7548c0
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
7548c0
@@ -3,6 +3,7 @@
7548c0
   <model>EPYC-Rome</model>
7548c0
   <vendor>AMD</vendor>
7548c0
   <feature name='ht'/>
7548c0
+  <feature name='monitor'/>
7548c0
   <feature name='osxsave'/>
7548c0
   <feature name='cmt'/>
7548c0
   <feature name='xsaves'/>
7548c0
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
7548c0
index 86466c0547..febfdfcf2b 100644
7548c0
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
7548c0
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
7548c0
@@ -17,5 +17,4 @@
7548c0
   <feature policy='require' name='skip-l1dfl-vmentry'/>
7548c0
   <feature policy='require' name='mds-no'/>
7548c0
   <feature policy='require' name='pschange-mc-no'/>
7548c0
-  <feature policy='disable' name='monitor'/>
7548c0
 </cpu>
7548c0
-- 
7548c0
2.29.2
7548c0