c313de
From 77ad41e460c2e91f2c2e187c80581069654b741d Mon Sep 17 00:00:00 2001
c313de
Message-Id: <77ad41e460c2e91f2c2e187c80581069654b741d@dist-git>
c313de
From: Jiri Denemark <Jiri.Denemark@gmail.com>
c313de
Date: Fri, 21 Jun 2019 09:25:16 +0200
c313de
Subject: [PATCH] cpu_map: Add more signatures for Broadwell CPU models
c313de
MIME-Version: 1.0
c313de
Content-Type: text/plain; charset=UTF-8
c313de
Content-Transfer-Encoding: 8bit
c313de
c313de
This fixes several CPUs which were incorrectly detected as
c313de
Skylake-Client.
c313de
c313de
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
c313de
Reviewed-by: Ján Tomko <jtomko@redhat.com>
c313de
(cherry picked from commit 4ff74a806ad42820eef3877c8ec146770914d8df)
c313de
c313de
https://bugzilla.redhat.com/show_bug.cgi?id=1686895
c313de
c313de
Conflicts:
c313de
	src/cpu_map/x86_Broadwell-IBRS.xml
c313de
	src/cpu_map/x86_Broadwell-noTSX-IBRS.xml
c313de
	src/cpu_map/x86_Broadwell-noTSX.xml
c313de
	src/cpu_map/x86_Broadwell.xml
c313de
            - cpu_map split not backported
c313de
c313de
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
c313de
Message-Id: <543534b544d2d09470c218aeb6c7d945facaf2c8.1561068591.git.jdenemar@redhat.com>
c313de
Reviewed-by: Ján Tomko <jtomko@redhat.com>
c313de
---
c313de
 src/cpu/cpu_map.xml                                  | 12 ++++++++++++
c313de
 .../x86_64-cpuid-Xeon-E5-2623-v4-guest.xml           | 11 +++++++----
c313de
 .../x86_64-cpuid-Xeon-E5-2623-v4-json.xml            | 11 +++++++----
c313de
 .../x86_64-cpuid-Xeon-E5-2630-v4-guest.xml           | 11 +++++++----
c313de
 .../x86_64-cpuid-Xeon-E5-2630-v4-json.xml            | 11 +++++++----
c313de
 .../x86_64-cpuid-Xeon-E5-2650-v4-guest.xml           | 11 +++++++----
c313de
 .../x86_64-cpuid-Xeon-E5-2650-v4-json.xml            | 11 +++++++----
c313de
 7 files changed, 54 insertions(+), 24 deletions(-)
c313de
c313de
diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
c313de
index ed6006643b..04369d1eda 100644
c313de
--- a/src/cpu/cpu_map.xml
c313de
+++ b/src/cpu/cpu_map.xml
c313de
@@ -1473,6 +1473,9 @@
c313de
 
c313de
     <model name='Broadwell-noTSX'>
c313de
       <signature family='6' model='61'/> 
c313de
+      <signature family='6' model='71'/> 
c313de
+      <signature family='6' model='79'/> 
c313de
+      <signature family='6' model='86'/> 
c313de
       <vendor name='Intel'/>
c313de
       <feature name='3dnowprefetch'/>
c313de
       <feature name='adx'/>
c313de
@@ -1530,6 +1533,9 @@
c313de
 
c313de
     <model name='Broadwell-noTSX-IBRS'>
c313de
       <signature family='6' model='61'/> 
c313de
+      <signature family='6' model='71'/> 
c313de
+      <signature family='6' model='79'/> 
c313de
+      <signature family='6' model='86'/> 
c313de
       <vendor name='Intel'/>
c313de
       <feature name='3dnowprefetch'/>
c313de
       <feature name='adx'/>
c313de
@@ -1588,6 +1594,9 @@
c313de
 
c313de
     <model name='Broadwell'>
c313de
       <signature family='6' model='61'/> 
c313de
+      <signature family='6' model='71'/> 
c313de
+      <signature family='6' model='79'/> 
c313de
+      <signature family='6' model='86'/> 
c313de
       <vendor name='Intel'/>
c313de
       <feature name='3dnowprefetch'/>
c313de
       <feature name='adx'/>
c313de
@@ -1647,6 +1656,9 @@
c313de
 
c313de
     <model name='Broadwell-IBRS'>
c313de
       <signature family='6' model='61'/> 
c313de
+      <signature family='6' model='71'/> 
c313de
+      <signature family='6' model='79'/> 
c313de
+      <signature family='6' model='86'/> 
c313de
       <vendor name='Intel'/>
c313de
       <feature name='3dnowprefetch'/>
c313de
       <feature name='adx'/>
c313de
diff --git a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-guest.xml b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-guest.xml
c313de
index 7718d7ca59..a5c6d9b471 100644
c313de
--- a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-guest.xml
c313de
+++ b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-guest.xml
c313de
@@ -1,6 +1,7 @@
c313de
 <cpu mode='custom' match='exact'>
c313de
-  <model fallback='forbid'>Skylake-Client-IBRS</model>
c313de
+  <model fallback='forbid'>Broadwell-IBRS</model>
c313de
   <vendor>Intel</vendor>
c313de
+  <feature policy='require' name='vme'/>
c313de
   <feature policy='require' name='ds'/>
c313de
   <feature policy='require' name='acpi'/>
c313de
   <feature policy='require' name='ss'/>
c313de
@@ -18,15 +19,17 @@
c313de
   <feature policy='require' name='pdcm'/>
c313de
   <feature policy='require' name='dca'/>
c313de
   <feature policy='require' name='osxsave'/>
c313de
+  <feature policy='require' name='f16c'/>
c313de
+  <feature policy='require' name='rdrand'/>
c313de
+  <feature policy='require' name='arat'/>
c313de
   <feature policy='require' name='tsc_adjust'/>
c313de
   <feature policy='require' name='cmt'/>
c313de
   <feature policy='require' name='intel-pt'/>
c313de
   <feature policy='require' name='stibp'/>
c313de
+  <feature policy='require' name='xsaveopt'/>
c313de
   <feature policy='require' name='mbm_total'/>
c313de
   <feature policy='require' name='mbm_local'/>
c313de
   <feature policy='require' name='pdpe1gb'/>
c313de
+  <feature policy='require' name='abm'/>
c313de
   <feature policy='require' name='invtsc'/>
c313de
-  <feature policy='disable' name='mpx'/>
c313de
-  <feature policy='disable' name='xsavec'/>
c313de
-  <feature policy='disable' name='xgetbv1'/>
c313de
 </cpu>
c313de
diff --git a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-json.xml b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-json.xml
c313de
index 167a9028ab..de082dbd93 100644
c313de
--- a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-json.xml
c313de
+++ b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-json.xml
c313de
@@ -1,11 +1,14 @@
c313de
 <cpu mode='custom' match='exact'>
c313de
-  <model fallback='forbid'>Skylake-Client-IBRS</model>
c313de
+  <model fallback='forbid'>Broadwell-IBRS</model>
c313de
   <vendor>Intel</vendor>
c313de
+  <feature policy='require' name='vme'/>
c313de
   <feature policy='require' name='ss'/>
c313de
+  <feature policy='require' name='f16c'/>
c313de
+  <feature policy='require' name='rdrand'/>
c313de
   <feature policy='require' name='hypervisor'/>
c313de
+  <feature policy='require' name='arat'/>
c313de
   <feature policy='require' name='tsc_adjust'/>
c313de
+  <feature policy='require' name='xsaveopt'/>
c313de
   <feature policy='require' name='pdpe1gb'/>
c313de
-  <feature policy='disable' name='mpx'/>
c313de
-  <feature policy='disable' name='xsavec'/>
c313de
-  <feature policy='disable' name='xgetbv1'/>
c313de
+  <feature policy='require' name='abm'/>
c313de
 </cpu>
c313de
diff --git a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-guest.xml b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-guest.xml
c313de
index cd7e25b52a..e2999db8e9 100644
c313de
--- a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-guest.xml
c313de
+++ b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-guest.xml
c313de
@@ -1,6 +1,7 @@
c313de
 <cpu mode='custom' match='exact'>
c313de
-  <model fallback='forbid'>Skylake-Client</model>
c313de
+  <model fallback='forbid'>Broadwell</model>
c313de
   <vendor>Intel</vendor>
c313de
+  <feature policy='require' name='vme'/>
c313de
   <feature policy='require' name='ds'/>
c313de
   <feature policy='require' name='acpi'/>
c313de
   <feature policy='require' name='ss'/>
c313de
@@ -18,14 +19,16 @@
c313de
   <feature policy='require' name='pdcm'/>
c313de
   <feature policy='require' name='dca'/>
c313de
   <feature policy='require' name='osxsave'/>
c313de
+  <feature policy='require' name='f16c'/>
c313de
+  <feature policy='require' name='rdrand'/>
c313de
+  <feature policy='require' name='arat'/>
c313de
   <feature policy='require' name='tsc_adjust'/>
c313de
   <feature policy='require' name='cmt'/>
c313de
   <feature policy='require' name='intel-pt'/>
c313de
+  <feature policy='require' name='xsaveopt'/>
c313de
   <feature policy='require' name='mbm_total'/>
c313de
   <feature policy='require' name='mbm_local'/>
c313de
   <feature policy='require' name='pdpe1gb'/>
c313de
+  <feature policy='require' name='abm'/>
c313de
   <feature policy='require' name='invtsc'/>
c313de
-  <feature policy='disable' name='mpx'/>
c313de
-  <feature policy='disable' name='xsavec'/>
c313de
-  <feature policy='disable' name='xgetbv1'/>
c313de
 </cpu>
c313de
diff --git a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-json.xml b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-json.xml
c313de
index 5dfce947b2..5b8891093a 100644
c313de
--- a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-json.xml
c313de
+++ b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-v4-json.xml
c313de
@@ -1,11 +1,14 @@
c313de
 <cpu mode='custom' match='exact'>
c313de
-  <model fallback='forbid'>Skylake-Client</model>
c313de
+  <model fallback='forbid'>Broadwell</model>
c313de
   <vendor>Intel</vendor>
c313de
+  <feature policy='require' name='vme'/>
c313de
   <feature policy='require' name='ss'/>
c313de
+  <feature policy='require' name='f16c'/>
c313de
+  <feature policy='require' name='rdrand'/>
c313de
   <feature policy='require' name='hypervisor'/>
c313de
+  <feature policy='require' name='arat'/>
c313de
   <feature policy='require' name='tsc_adjust'/>
c313de
+  <feature policy='require' name='xsaveopt'/>
c313de
   <feature policy='require' name='pdpe1gb'/>
c313de
-  <feature policy='disable' name='mpx'/>
c313de
-  <feature policy='disable' name='xsavec'/>
c313de
-  <feature policy='disable' name='xgetbv1'/>
c313de
+  <feature policy='require' name='abm'/>
c313de
 </cpu>
c313de
diff --git a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-guest.xml b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-guest.xml
c313de
index cd7e25b52a..e2999db8e9 100644
c313de
--- a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-guest.xml
c313de
+++ b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-guest.xml
c313de
@@ -1,6 +1,7 @@
c313de
 <cpu mode='custom' match='exact'>
c313de
-  <model fallback='forbid'>Skylake-Client</model>
c313de
+  <model fallback='forbid'>Broadwell</model>
c313de
   <vendor>Intel</vendor>
c313de
+  <feature policy='require' name='vme'/>
c313de
   <feature policy='require' name='ds'/>
c313de
   <feature policy='require' name='acpi'/>
c313de
   <feature policy='require' name='ss'/>
c313de
@@ -18,14 +19,16 @@
c313de
   <feature policy='require' name='pdcm'/>
c313de
   <feature policy='require' name='dca'/>
c313de
   <feature policy='require' name='osxsave'/>
c313de
+  <feature policy='require' name='f16c'/>
c313de
+  <feature policy='require' name='rdrand'/>
c313de
+  <feature policy='require' name='arat'/>
c313de
   <feature policy='require' name='tsc_adjust'/>
c313de
   <feature policy='require' name='cmt'/>
c313de
   <feature policy='require' name='intel-pt'/>
c313de
+  <feature policy='require' name='xsaveopt'/>
c313de
   <feature policy='require' name='mbm_total'/>
c313de
   <feature policy='require' name='mbm_local'/>
c313de
   <feature policy='require' name='pdpe1gb'/>
c313de
+  <feature policy='require' name='abm'/>
c313de
   <feature policy='require' name='invtsc'/>
c313de
-  <feature policy='disable' name='mpx'/>
c313de
-  <feature policy='disable' name='xsavec'/>
c313de
-  <feature policy='disable' name='xgetbv1'/>
c313de
 </cpu>
c313de
diff --git a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-json.xml b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-json.xml
c313de
index 5dfce947b2..5b8891093a 100644
c313de
--- a/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-json.xml
c313de
+++ b/tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-v4-json.xml
c313de
@@ -1,11 +1,14 @@
c313de
 <cpu mode='custom' match='exact'>
c313de
-  <model fallback='forbid'>Skylake-Client</model>
c313de
+  <model fallback='forbid'>Broadwell</model>
c313de
   <vendor>Intel</vendor>
c313de
+  <feature policy='require' name='vme'/>
c313de
   <feature policy='require' name='ss'/>
c313de
+  <feature policy='require' name='f16c'/>
c313de
+  <feature policy='require' name='rdrand'/>
c313de
   <feature policy='require' name='hypervisor'/>
c313de
+  <feature policy='require' name='arat'/>
c313de
   <feature policy='require' name='tsc_adjust'/>
c313de
+  <feature policy='require' name='xsaveopt'/>
c313de
   <feature policy='require' name='pdpe1gb'/>
c313de
-  <feature policy='disable' name='mpx'/>
c313de
-  <feature policy='disable' name='xsavec'/>
c313de
-  <feature policy='disable' name='xgetbv1'/>
c313de
+  <feature policy='require' name='abm'/>
c313de
 </cpu>
c313de
-- 
c313de
2.22.0
c313de