|
 |
c1c534 |
From 77bc396146f85ba8f767fd51f0238037cb9784cc Mon Sep 17 00:00:00 2001
|
|
|
c1c534 |
Message-Id: <77bc396146f85ba8f767fd51f0238037cb9784cc@dist-git>
|
|
|
c1c534 |
From: Andrea Bolognani <abologna@redhat.com>
|
|
|
c1c534 |
Date: Wed, 29 Nov 2017 16:22:59 +0100
|
|
|
c1c534 |
Subject: [PATCH] conf: Drop virDomainChrDeviceType.targetTypeAttr
|
|
|
c1c534 |
|
|
|
c1c534 |
This attribute was used to decide whether to format the type
|
|
|
c1c534 |
attribute of the <target> element, but the logic didn't take into
|
|
|
c1c534 |
account all possible cases and as such could lead to unexpected
|
|
|
c1c534 |
results. Moreover, it's one more thing to keep track of, and can
|
|
|
c1c534 |
easily fall out of sync with other attributes.
|
|
|
c1c534 |
|
|
|
c1c534 |
Now that we have VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE, we can
|
|
|
c1c534 |
use that value to signal that no specific target type has been
|
|
|
c1c534 |
configured for the serial device and as such the attribute should
|
|
|
c1c534 |
not be formatted at all. All other values are now formatted.
|
|
|
c1c534 |
|
|
|
c1c534 |
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
|
|
|
c1c534 |
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c1c534 |
(cherry picked from commit 4fb8ff9987b7e34d331c4af8f573db11579a0e88)
|
|
|
c1c534 |
|
|
|
c1c534 |
https://bugzilla.redhat.com/show_bug.cgi?id=1449265
|
|
|
c1c534 |
https://bugzilla.redhat.com/show_bug.cgi?id=1511421
|
|
|
c1c534 |
https://bugzilla.redhat.com/show_bug.cgi?id=1512929
|
|
|
c1c534 |
https://bugzilla.redhat.com/show_bug.cgi?id=1512934
|
|
|
c1c534 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
c1c534 |
---
|
|
|
c1c534 |
src/conf/domain_conf.c | 11 ++++-------
|
|
|
c1c534 |
src/conf/domain_conf.h | 1 -
|
|
|
c1c534 |
src/vz/vz_sdk.c | 3 +--
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml | 2 +-
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml | 2 +-
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml | 2 +-
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml | 4 ++--
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml | 2 +-
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-tcp-telnet.xml | 2 +-
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml | 2 +-
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml | 4 ++--
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml | 2 +-
|
|
|
c1c534 |
tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml | 2 +-
|
|
|
c1c534 |
.../qemuhotplug-console-compat-2-live+console-virtio.xml | 4 ++--
|
|
|
c1c534 |
.../qemuhotplug-console-compat-2-live.xml | 4 ++--
|
|
|
c1c534 |
.../qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 4 ++--
|
|
|
c1c534 |
tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml | 4 ++--
|
|
|
c1c534 |
.../qemuxml2xmlout-bios-nvram-os-interleave.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-chardev-label.xml | 4 ++--
|
|
|
c1c534 |
.../qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat2.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmloutdata/qemuxml2xmlout-console-virtio-many.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-driver.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-server.xml | 4 ++--
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth2.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-panic-pseries.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmlout-pseries-cpu-compat-power9.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmlout-pseries-panic-missing.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmlout-pseries-panic-no-address.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmlout-q35-virt-manager-basic.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmlout-serial-spiceport-nospice.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport.xml | 2 +-
|
|
|
c1c534 |
.../qemuxml2xmlout-serial-target-port-auto.xml | 6 +++---
|
|
|
c1c534 |
.../qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml | 4 ++--
|
|
|
c1c534 |
.../qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml | 2 +-
|
|
|
c1c534 |
tests/qemuxml2xmloutdata/qemuxml2xmlout-vhost_queues.xml | 2 +-
|
|
|
c1c534 |
43 files changed, 56 insertions(+), 61 deletions(-)
|
|
|
c1c534 |
|
|
|
c1c534 |
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
|
|
|
c1c534 |
index 3a5ecd3a9d..586a840672 100644
|
|
|
c1c534 |
--- a/src/conf/domain_conf.c
|
|
|
c1c534 |
+++ b/src/conf/domain_conf.c
|
|
|
c1c534 |
@@ -11499,8 +11499,7 @@ virDomainChrDefaultTargetType(int devtype)
|
|
|
c1c534 |
}
|
|
|
c1c534 |
|
|
|
c1c534 |
static int
|
|
|
c1c534 |
-virDomainChrTargetTypeFromString(virDomainChrDefPtr def,
|
|
|
c1c534 |
- int devtype,
|
|
|
c1c534 |
+virDomainChrTargetTypeFromString(int devtype,
|
|
|
c1c534 |
const char *targetType)
|
|
|
c1c534 |
{
|
|
|
c1c534 |
int ret = -1;
|
|
|
c1c534 |
@@ -11528,8 +11527,6 @@ virDomainChrTargetTypeFromString(virDomainChrDefPtr def,
|
|
|
c1c534 |
break;
|
|
|
c1c534 |
}
|
|
|
c1c534 |
|
|
|
c1c534 |
- def->targetTypeAttr = true;
|
|
|
c1c534 |
-
|
|
|
c1c534 |
return ret;
|
|
|
c1c534 |
}
|
|
|
c1c534 |
|
|
|
c1c534 |
@@ -11546,7 +11543,7 @@ virDomainChrDefParseTargetXML(virDomainChrDefPtr def,
|
|
|
c1c534 |
char *stateStr = NULL;
|
|
|
c1c534 |
|
|
|
c1c534 |
if ((def->targetType =
|
|
|
c1c534 |
- virDomainChrTargetTypeFromString(def, def->deviceType,
|
|
|
c1c534 |
+ virDomainChrTargetTypeFromString(def->deviceType,
|
|
|
c1c534 |
targetType)) < 0) {
|
|
|
c1c534 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
|
|
c1c534 |
_("unknown target type '%s' specified for character device"),
|
|
|
c1c534 |
@@ -16466,7 +16463,7 @@ virDomainChrEquals(virDomainChrDefPtr src,
|
|
|
c1c534 |
break;
|
|
|
c1c534 |
|
|
|
c1c534 |
case VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL:
|
|
|
c1c534 |
- if (src->targetTypeAttr != tgt->targetTypeAttr)
|
|
|
c1c534 |
+ if (src->targetType != tgt->targetType)
|
|
|
c1c534 |
return false;
|
|
|
c1c534 |
|
|
|
c1c534 |
ATTRIBUTE_FALLTHROUGH;
|
|
|
c1c534 |
@@ -24026,7 +24023,7 @@ virDomainChrDefFormat(virBufferPtr buf,
|
|
|
c1c534 |
break;
|
|
|
c1c534 |
|
|
|
c1c534 |
case VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL:
|
|
|
c1c534 |
- if (def->targetTypeAttr) {
|
|
|
c1c534 |
+ if (def->targetType != VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE) {
|
|
|
c1c534 |
virBufferAsprintf(buf,
|
|
|
c1c534 |
"<target type='%s' port='%d'/>\n",
|
|
|
c1c534 |
virDomainChrTargetTypeToString(def->deviceType,
|
|
|
c1c534 |
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
|
|
|
c1c534 |
index 9502573b34..bbb056cf21 100644
|
|
|
c1c534 |
--- a/src/conf/domain_conf.h
|
|
|
c1c534 |
+++ b/src/conf/domain_conf.h
|
|
|
c1c534 |
@@ -1199,7 +1199,6 @@ struct _virDomainChrSourceDef {
|
|
|
c1c534 |
struct _virDomainChrDef {
|
|
|
c1c534 |
int deviceType; /* enum virDomainChrDeviceType */
|
|
|
c1c534 |
|
|
|
c1c534 |
- bool targetTypeAttr;
|
|
|
c1c534 |
int targetType; /* enum virDomainChrConsoleTargetType ||
|
|
|
c1c534 |
enum virDomainChrChannelTargetType ||
|
|
|
c1c534 |
enum virDomainChrSerialTargetType according to deviceType */
|
|
|
c1c534 |
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
|
|
|
c1c534 |
index 3910deeb3a..c8de1b9598 100644
|
|
|
c1c534 |
--- a/src/vz/vz_sdk.c
|
|
|
c1c534 |
+++ b/src/vz/vz_sdk.c
|
|
|
c1c534 |
@@ -1191,7 +1191,6 @@ prlsdkGetSerialInfo(PRL_HANDLE serialPort, virDomainChrDefPtr chr)
|
|
|
c1c534 |
int ret = -1;
|
|
|
c1c534 |
|
|
|
c1c534 |
chr->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL;
|
|
|
c1c534 |
- chr->targetTypeAttr = false;
|
|
|
c1c534 |
pret = PrlVmDev_GetIndex(serialPort, &serialPortIndex);
|
|
|
c1c534 |
prlsdkCheckRetGoto(pret, cleanup);
|
|
|
c1c534 |
chr->target.port = serialPortIndex;
|
|
|
c1c534 |
@@ -2864,7 +2863,7 @@ static int prlsdkCheckSerialUnsupportedParams(virDomainChrDefPtr chr)
|
|
|
c1c534 |
return -1;
|
|
|
c1c534 |
}
|
|
|
c1c534 |
|
|
|
c1c534 |
- if (chr->targetTypeAttr) {
|
|
|
c1c534 |
+ if (chr->targetType != VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE) {
|
|
|
c1c534 |
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
|
|
c1c534 |
_("Specified character device target type is not "
|
|
|
c1c534 |
"supported by vz driver."));
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml b/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml
|
|
|
c1c534 |
index f512844427..7c106f145c 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml
|
|
|
c1c534 |
@@ -28,7 +28,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml
|
|
|
c1c534 |
index aac814d59f..e76d0211dc 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml
|
|
|
c1c534 |
@@ -29,7 +29,7 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='dev'>
|
|
|
c1c534 |
<source path='/dev/ttyS2'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='dev'>
|
|
|
c1c534 |
<source path='/dev/ttyS2'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml
|
|
|
c1c534 |
index 64819a48ae..ed67ada0d8 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml
|
|
|
c1c534 |
@@ -29,7 +29,7 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='file'>
|
|
|
c1c534 |
<source path='/tmp/serial.log'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='file'>
|
|
|
c1c534 |
<source path='/tmp/serial.log'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml
|
|
|
c1c534 |
index e00afe317f..420771dc9c 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml
|
|
|
c1c534 |
@@ -28,11 +28,11 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='file'>
|
|
|
c1c534 |
<source path='/tmp/serial.log'/>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml
|
|
|
c1c534 |
index f512844427..7c106f145c 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml
|
|
|
c1c534 |
@@ -28,7 +28,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp-telnet.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp-telnet.xml
|
|
|
c1c534 |
index c35a4ca73a..3fe61ffa05 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp-telnet.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp-telnet.xml
|
|
|
c1c534 |
@@ -30,7 +30,7 @@
|
|
|
c1c534 |
<serial type='tcp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='9999'/>
|
|
|
c1c534 |
<protocol type='telnet'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='tcp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='9999'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml
|
|
|
c1c534 |
index 0d218f5482..3fc9fd39b0 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml
|
|
|
c1c534 |
@@ -30,7 +30,7 @@
|
|
|
c1c534 |
<serial type='tcp'>
|
|
|
c1c534 |
<source mode='connect' host='127.0.0.1' service='9999'/>
|
|
|
c1c534 |
<protocol type='raw'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='tcp'>
|
|
|
c1c534 |
<source mode='connect' host='127.0.0.1' service='9999'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml
|
|
|
c1c534 |
index f7069d541f..5b4af3fe95 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml
|
|
|
c1c534 |
@@ -30,11 +30,11 @@
|
|
|
c1c534 |
<serial type='udp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='9999'/>
|
|
|
c1c534 |
<source mode='connect' host='127.0.0.1' service='9998'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='udp'>
|
|
|
c1c534 |
<source mode='connect' service='9999'/>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='udp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='9999'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml
|
|
|
c1c534 |
index 14fc8fc7c9..6bb291ff7f 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml
|
|
|
c1c534 |
@@ -29,7 +29,7 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='unix'>
|
|
|
c1c534 |
<source mode='connect' path='/tmp/serial.sock'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='unix'>
|
|
|
c1c534 |
<source mode='connect' path='/tmp/serial.sock'/>
|
|
|
c1c534 |
diff --git a/tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml b/tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml
|
|
|
c1c534 |
index 95aa1c7b9b..41954fc85d 100644
|
|
|
c1c534 |
--- a/tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml
|
|
|
c1c534 |
+++ b/tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml
|
|
|
c1c534 |
@@ -28,7 +28,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='vc'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='vc'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+console-virtio.xml b/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+console-virtio.xml
|
|
|
c1c534 |
index 4e1dd49c22..427f431cce 100644
|
|
|
c1c534 |
--- a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+console-virtio.xml
|
|
|
c1c534 |
+++ b/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+console-virtio.xml
|
|
|
c1c534 |
@@ -72,13 +72,13 @@
|
|
|
c1c534 |
<alias name='serial0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<alias name='serial1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='tcp'>
|
|
|
c1c534 |
<source mode='bind' host='0.0.0.0' service='2445'/>
|
|
|
c1c534 |
<protocol type='raw'/>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
<alias name='serial2'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml b/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml
|
|
|
c1c534 |
index c56d13ef4a..144f6eff7a 100644
|
|
|
c1c534 |
--- a/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml
|
|
|
c1c534 |
+++ b/tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml
|
|
|
c1c534 |
@@ -72,13 +72,13 @@
|
|
|
c1c534 |
<alias name='serial0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<alias name='serial1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='tcp'>
|
|
|
c1c534 |
<source mode='bind' host='0.0.0.0' service='2445'/>
|
|
|
c1c534 |
<protocol type='raw'/>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
<alias name='serial2'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml
|
|
|
c1c534 |
index a95e29ad8a..e6c4adb6f3 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml
|
|
|
c1c534 |
@@ -29,12 +29,12 @@
|
|
|
c1c534 |
<serial type='udp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='1111'/>
|
|
|
c1c534 |
<source mode='connect' host='127.0.0.1' service='2222'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='tcp'>
|
|
|
c1c534 |
<source mode='connect' host='127.0.0.1' service='5555' tls='no'/>
|
|
|
c1c534 |
<protocol type='raw'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='udp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='1111'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml b/tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml
|
|
|
c1c534 |
index c760098fe0..f9724d320e 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml
|
|
|
c1c534 |
@@ -110,10 +110,10 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml
|
|
|
c1c534 |
index 033e86d3a3..5ee73b527e 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml
|
|
|
c1c534 |
@@ -33,7 +33,7 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-chardev-label.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-chardev-label.xml
|
|
|
c1c534 |
index 840bf69f61..ad77f62d9e 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-chardev-label.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-chardev-label.xml
|
|
|
c1c534 |
@@ -25,13 +25,13 @@
|
|
|
c1c534 |
<source path='/tmp/serial.file'>
|
|
|
c1c534 |
<seclabel model='dac' relabel='no'/>
|
|
|
c1c534 |
</source>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='unix'>
|
|
|
c1c534 |
<source mode='connect' path='/tmp/serial.sock'>
|
|
|
c1c534 |
<seclabel model='dac' relabel='no'/>
|
|
|
c1c534 |
</source>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='file'>
|
|
|
c1c534 |
<source path='/tmp/serial.file'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
|
|
|
c1c534 |
index e76f857aee..cd9d75c4b7 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
|
|
|
c1c534 |
@@ -27,7 +27,7 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat.xml
|
|
|
c1c534 |
index 8dc361dfc6..0c0bd7b348 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat.xml
|
|
|
c1c534 |
@@ -28,7 +28,7 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat2.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat2.xml
|
|
|
c1c534 |
index 858b2c6750..305c53eab7 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat2.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat2.xml
|
|
|
c1c534 |
@@ -31,7 +31,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio-many.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio-many.xml
|
|
|
c1c534 |
index f9f9abd2df..b38b3ce987 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio-many.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio-many.xml
|
|
|
c1c534 |
@@ -30,7 +30,7 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-driver.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-driver.xml
|
|
|
c1c534 |
index 1c55017678..06192fbb4a 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-driver.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-driver.xml
|
|
|
c1c534 |
@@ -47,7 +47,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-server.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-server.xml
|
|
|
c1c534 |
index 95b6e2df1a..a6eaa38079 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-server.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-server.xml
|
|
|
c1c534 |
@@ -104,10 +104,10 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth.xml
|
|
|
c1c534 |
index 7fe69bd6cb..e6ad234240 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth.xml
|
|
|
c1c534 |
@@ -55,7 +55,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth2.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth2.xml
|
|
|
c1c534 |
index b631e5b515..66448ec3dd 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth2.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth2.xml
|
|
|
c1c534 |
@@ -44,7 +44,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml
|
|
|
c1c534 |
index fd5fdbece5..b1240b8ed1 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml
|
|
|
c1c534 |
@@ -57,7 +57,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml
|
|
|
c1c534 |
index 4571b6a829..4f7ad323ed 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml
|
|
|
c1c534 |
@@ -54,7 +54,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-panic-pseries.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-panic-pseries.xml
|
|
|
c1c534 |
index 7fb49feb0f..a563b6dddf 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-panic-pseries.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-panic-pseries.xml
|
|
|
c1c534 |
@@ -22,7 +22,7 @@
|
|
|
c1c534 |
<target index='0'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<address type='spapr-vio' reg='0x30000000'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat-power9.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat-power9.xml
|
|
|
c1c534 |
index f020056219..59587b3c32 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat-power9.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat-power9.xml
|
|
|
c1c534 |
@@ -25,7 +25,7 @@
|
|
|
c1c534 |
<target index='0'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<address type='spapr-vio' reg='0x30000000'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml
|
|
|
c1c534 |
index 3cbce9fe6a..a39e1fd015 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml
|
|
|
c1c534 |
@@ -25,7 +25,7 @@
|
|
|
c1c534 |
<target index='0'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<address type='spapr-vio' reg='0x30000000'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml
|
|
|
c1c534 |
index d69b387686..666eede1a5 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml
|
|
|
c1c534 |
@@ -26,7 +26,7 @@
|
|
|
c1c534 |
<target index='0'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<address type='spapr-vio' reg='0x30000000'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-missing.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-missing.xml
|
|
|
c1c534 |
index 7fb49feb0f..a563b6dddf 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-missing.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-missing.xml
|
|
|
c1c534 |
@@ -22,7 +22,7 @@
|
|
|
c1c534 |
<target index='0'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<address type='spapr-vio' reg='0x30000000'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-no-address.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-no-address.xml
|
|
|
c1c534 |
index 7fb49feb0f..a563b6dddf 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-no-address.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-no-address.xml
|
|
|
c1c534 |
@@ -22,7 +22,7 @@
|
|
|
c1c534 |
<target index='0'/>
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
<address type='spapr-vio' reg='0x30000000'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml
|
|
|
c1c534 |
index c4ccd98aac..27baaa3f14 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml
|
|
|
c1c534 |
@@ -79,7 +79,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport-nospice.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport-nospice.xml
|
|
|
c1c534 |
index 79c4ebc734..63462e6f94 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport-nospice.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport-nospice.xml
|
|
|
c1c534 |
@@ -28,7 +28,7 @@
|
|
|
c1c534 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
c1c534 |
<serial type='spiceport'>
|
|
|
c1c534 |
<source channel='org.qemu.console.serial.0'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='spiceport'>
|
|
|
c1c534 |
<source channel='org.qemu.console.serial.0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport.xml
|
|
|
c1c534 |
index 9527b2d15f..c90bbeb7d5 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport.xml
|
|
|
c1c534 |
@@ -28,7 +28,7 @@
|
|
|
c1c534 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
c1c534 |
<serial type='spiceport'>
|
|
|
c1c534 |
<source channel='org.qemu.console.serial.0'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='spiceport'>
|
|
|
c1c534 |
<source channel='org.qemu.console.serial.0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
|
|
|
c1c534 |
index 71516a31a9..a8790b5098 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
|
|
|
c1c534 |
@@ -27,13 +27,13 @@
|
|
|
c1c534 |
</controller>
|
|
|
c1c534 |
<controller type='pci' index='0' model='pci-root'/>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='null'>
|
|
|
c1c534 |
- <target port='1'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='1'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='stdio'>
|
|
|
c1c534 |
- <target port='2'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='2'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml
|
|
|
c1c534 |
index 18f51e5383..a8af87b53b 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml
|
|
|
c1c534 |
@@ -29,12 +29,12 @@
|
|
|
c1c534 |
<serial type='udp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='1111'/>
|
|
|
c1c534 |
<source mode='connect' host='127.0.0.1' service='2222'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<serial type='tcp'>
|
|
|
c1c534 |
<source mode='connect' host='127.0.0.1' service='5555'/>
|
|
|
c1c534 |
<protocol type='raw'/>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='udp'>
|
|
|
c1c534 |
<source mode='bind' host='127.0.0.1' service='1111'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml
|
|
|
c1c534 |
index 3a95b6088c..6d847de3a2 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml
|
|
|
c1c534 |
@@ -40,7 +40,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml
|
|
|
c1c534 |
index 759b844395..30989658f4 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml
|
|
|
c1c534 |
@@ -47,7 +47,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-vhost_queues.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-vhost_queues.xml
|
|
|
c1c534 |
index 8c27470ddf..72cbcc4cb5 100644
|
|
|
c1c534 |
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-vhost_queues.xml
|
|
|
c1c534 |
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-vhost_queues.xml
|
|
|
c1c534 |
@@ -46,7 +46,7 @@
|
|
|
c1c534 |
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
|
|
|
c1c534 |
</interface>
|
|
|
c1c534 |
<serial type='pty'>
|
|
|
c1c534 |
- <target port='0'/>
|
|
|
c1c534 |
+ <target type='isa-serial' port='0'/>
|
|
|
c1c534 |
</serial>
|
|
|
c1c534 |
<console type='pty'>
|
|
|
c1c534 |
<target type='serial' port='0'/>
|
|
|
c1c534 |
--
|
|
|
c1c534 |
2.15.1
|
|
|
c1c534 |
|