982648
From 99968171f09ae0f374b5e9c961032ffa6bd4dd11 Mon Sep 17 00:00:00 2001
982648
Message-Id: <99968171f09ae0f374b5e9c961032ffa6bd4dd11@dist-git>
982648
From: John Ferlan <jferlan@redhat.com>
982648
Date: Mon, 27 Aug 2018 08:27:47 -0400
982648
Subject: [PATCH] access: Fix nwfilter-binding ACL access API name generation
982648
MIME-Version: 1.0
982648
Content-Type: text/plain; charset=UTF-8
982648
Content-Transfer-Encoding: 8bit
982648
982648
https://bugzilla.redhat.com/show_bug.cgi?id=1611320
982648
982648
Generation of the ACL API policy is a "automated process"
982648
based on this perl script which "worked" with the changes to
982648
add nwfilter binding API's because they had the "nwfilter"
982648
prefix; however, the generated output name was incorrect
982648
based on the remote protocol algorithm which expected to
982648
generate names such as 'nwfilter-binding.action' instead
982648
of 'nwfilter.binding-action'.
982648
982648
This effectively changes src/access/org.libvirt.api.policy entries:
982648
982648
  org.libvirt.api.nwfilter.binding-create ==>
982648
      org.libvirt.api.nwfilter-binding.create
982648
982648
  org.libvirt.api.nwfilter.binding-delete ==>
982648
      org.libvirt.api.nwfilter-binding.delete
982648
982648
  org.libvirt.api.nwfilter.binding-getattr ==>
982648
      org.libvirt.api.nwfilter-binding.getattr
982648
982648
  org.libvirt.api.nwfilter.binding-read ==>
982648
      org.libvirt.api.nwfilter-binding.read
982648
982648
Signed-off-by: John Ferlan <jferlan@redhat.com>
982648
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
982648
(cherry picked from commit 6ef65e3c96d5d1f16a16daca83b81b818d461e64)
982648
https: //bugzilla.redhat.com/show_bug.cgi?id=1622540
982648
Reviewed-by: Erik Skultety <eskultet@redhat.com>
982648
---
982648
 src/access/genpolkit.pl | 4 ++--
982648
 1 file changed, 2 insertions(+), 2 deletions(-)
982648
982648
diff --git a/src/access/genpolkit.pl b/src/access/genpolkit.pl
982648
index 968cb8c55c..e074c90eb6 100755
982648
--- a/src/access/genpolkit.pl
982648
+++ b/src/access/genpolkit.pl
982648
@@ -22,8 +22,8 @@ use warnings;
982648
 
982648
 my @objects = (
982648
     "CONNECT", "DOMAIN", "INTERFACE",
982648
-    "NETWORK","NODE_DEVICE", "NWFILTER",
982648
-     "SECRET", "STORAGE_POOL", "STORAGE_VOL",
982648
+    "NETWORK","NODE_DEVICE", "NWFILTER_BINDING", "NWFILTER",
982648
+    "SECRET", "STORAGE_POOL", "STORAGE_VOL",
982648
     );
982648
 
982648
 my $objects = join ("|", @objects);
982648
-- 
982648
2.18.0
982648