51d9a2
From 99968171f09ae0f374b5e9c961032ffa6bd4dd11 Mon Sep 17 00:00:00 2001
51d9a2
Message-Id: <99968171f09ae0f374b5e9c961032ffa6bd4dd11@dist-git>
51d9a2
From: John Ferlan <jferlan@redhat.com>
51d9a2
Date: Mon, 27 Aug 2018 08:27:47 -0400
51d9a2
Subject: [PATCH] access: Fix nwfilter-binding ACL access API name generation
51d9a2
MIME-Version: 1.0
51d9a2
Content-Type: text/plain; charset=UTF-8
51d9a2
Content-Transfer-Encoding: 8bit
51d9a2
51d9a2
https://bugzilla.redhat.com/show_bug.cgi?id=1611320
51d9a2
51d9a2
Generation of the ACL API policy is a "automated process"
51d9a2
based on this perl script which "worked" with the changes to
51d9a2
add nwfilter binding API's because they had the "nwfilter"
51d9a2
prefix; however, the generated output name was incorrect
51d9a2
based on the remote protocol algorithm which expected to
51d9a2
generate names such as 'nwfilter-binding.action' instead
51d9a2
of 'nwfilter.binding-action'.
51d9a2
51d9a2
This effectively changes src/access/org.libvirt.api.policy entries:
51d9a2
51d9a2
  org.libvirt.api.nwfilter.binding-create ==>
51d9a2
      org.libvirt.api.nwfilter-binding.create
51d9a2
51d9a2
  org.libvirt.api.nwfilter.binding-delete ==>
51d9a2
      org.libvirt.api.nwfilter-binding.delete
51d9a2
51d9a2
  org.libvirt.api.nwfilter.binding-getattr ==>
51d9a2
      org.libvirt.api.nwfilter-binding.getattr
51d9a2
51d9a2
  org.libvirt.api.nwfilter.binding-read ==>
51d9a2
      org.libvirt.api.nwfilter-binding.read
51d9a2
51d9a2
Signed-off-by: John Ferlan <jferlan@redhat.com>
51d9a2
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
51d9a2
(cherry picked from commit 6ef65e3c96d5d1f16a16daca83b81b818d461e64)
51d9a2
https: //bugzilla.redhat.com/show_bug.cgi?id=1622540
51d9a2
Reviewed-by: Erik Skultety <eskultet@redhat.com>
51d9a2
---
51d9a2
 src/access/genpolkit.pl | 4 ++--
51d9a2
 1 file changed, 2 insertions(+), 2 deletions(-)
51d9a2
51d9a2
diff --git a/src/access/genpolkit.pl b/src/access/genpolkit.pl
51d9a2
index 968cb8c55c..e074c90eb6 100755
51d9a2
--- a/src/access/genpolkit.pl
51d9a2
+++ b/src/access/genpolkit.pl
51d9a2
@@ -22,8 +22,8 @@ use warnings;
51d9a2
 
51d9a2
 my @objects = (
51d9a2
     "CONNECT", "DOMAIN", "INTERFACE",
51d9a2
-    "NETWORK","NODE_DEVICE", "NWFILTER",
51d9a2
-     "SECRET", "STORAGE_POOL", "STORAGE_VOL",
51d9a2
+    "NETWORK","NODE_DEVICE", "NWFILTER_BINDING", "NWFILTER",
51d9a2
+    "SECRET", "STORAGE_POOL", "STORAGE_VOL",
51d9a2
     );
51d9a2
 
51d9a2
 my $objects = join ("|", @objects);
51d9a2
-- 
51d9a2
2.18.0
51d9a2