|
 |
6d3351 |
From 71aa3b75eb2f6e01c0c8e0d1bc5c0d29e310d3fd Mon Sep 17 00:00:00 2001
|
|
|
6d3351 |
Message-Id: <71aa3b75eb2f6e01c0c8e0d1bc5c0d29e310d3fd@dist-git>
|
|
|
6d3351 |
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
|
|
|
6d3351 |
Date: Fri, 9 Jun 2017 12:48:54 +0200
|
|
|
6d3351 |
Subject: [PATCH] Use a separate buffer for <filesystem><driver>
|
|
|
6d3351 |
MIME-Version: 1.0
|
|
|
6d3351 |
Content-Type: text/plain; charset=UTF-8
|
|
|
6d3351 |
Content-Transfer-Encoding: 8bit
|
|
|
6d3351 |
|
|
|
6d3351 |
Format the attributes in a separate buffer and only
|
|
|
6d3351 |
print the element if it's not empty.
|
|
|
6d3351 |
|
|
|
6d3351 |
(cherry picked from commit 8d704e6cf7da60156a0b25b165d4780e99a0fa2f)
|
|
|
6d3351 |
Signed-off-by: Ján Tomko <jtomko@redhat.com>
|
|
|
6d3351 |
|
|
|
6d3351 |
https://bugzilla.redhat.com/show_bug.cgi?id=1283251
|
|
|
6d3351 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
6d3351 |
---
|
|
|
6d3351 |
src/conf/domain_conf.c | 12 +++++++++---
|
|
|
6d3351 |
1 file changed, 9 insertions(+), 3 deletions(-)
|
|
|
6d3351 |
|
|
|
6d3351 |
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
|
|
|
6d3351 |
index 242a79a7e7..e004559f9f 100644
|
|
|
6d3351 |
--- a/src/conf/domain_conf.c
|
|
|
6d3351 |
+++ b/src/conf/domain_conf.c
|
|
|
6d3351 |
@@ -21504,6 +21504,7 @@ virDomainFSDefFormat(virBufferPtr buf,
|
|
|
6d3351 |
const char *fsdriver = virDomainFSDriverTypeToString(def->fsdriver);
|
|
|
6d3351 |
const char *wrpolicy = virDomainFSWrpolicyTypeToString(def->wrpolicy);
|
|
|
6d3351 |
const char *src = def->src->path;
|
|
|
6d3351 |
+ virBuffer driverBuf = VIR_BUFFER_INITIALIZER;
|
|
|
6d3351 |
|
|
|
6d3351 |
if (!type) {
|
|
|
6d3351 |
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
6d3351 |
@@ -21523,16 +21524,21 @@ virDomainFSDefFormat(virBufferPtr buf,
|
|
|
6d3351 |
type, accessmode);
|
|
|
6d3351 |
virBufferAdjustIndent(buf, 2);
|
|
|
6d3351 |
if (def->fsdriver) {
|
|
|
6d3351 |
- virBufferAsprintf(buf, "
|
|
|
6d3351 |
+ virBufferAsprintf(&driverBuf, " type='%s'", fsdriver);
|
|
|
6d3351 |
|
|
|
6d3351 |
if (def->format)
|
|
|
6d3351 |
- virBufferAsprintf(buf, " format='%s'",
|
|
|
6d3351 |
+ virBufferAsprintf(&driverBuf, " format='%s'",
|
|
|
6d3351 |
virStorageFileFormatTypeToString(def->format));
|
|
|
6d3351 |
|
|
|
6d3351 |
/* Don't generate anything if wrpolicy is set to default */
|
|
|
6d3351 |
if (def->wrpolicy)
|
|
|
6d3351 |
- virBufferAsprintf(buf, " wrpolicy='%s'", wrpolicy);
|
|
|
6d3351 |
+ virBufferAsprintf(&driverBuf, " wrpolicy='%s'", wrpolicy);
|
|
|
6d3351 |
|
|
|
6d3351 |
+ }
|
|
|
6d3351 |
+
|
|
|
6d3351 |
+ if (virBufferUse(&driverBuf)) {
|
|
|
6d3351 |
+ virBufferAddLit(buf, "
|
|
|
6d3351 |
+ virBufferAddBuffer(buf, &driverBuf);
|
|
|
6d3351 |
virBufferAddLit(buf, "/>\n");
|
|
|
6d3351 |
}
|
|
|
6d3351 |
|
|
|
6d3351 |
--
|
|
|
6d3351 |
2.13.1
|
|
|
6d3351 |
|